From: Joe Perches <joe@perches.com>
To: Ryan Kosta <ryanpkosta@gmail.com>, gregkh@linuxfoundation.org
Cc: marvin24@gmx.de, p.zabel@pengutronix.de,
ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: nvec: nvec: fix double next comment
Date: Sun, 27 Sep 2020 09:45:19 -0700 [thread overview]
Message-ID: <4bff3adc94d909be7132151b1af211ed862b4126.camel@perches.com> (raw)
In-Reply-To: <20200927163504.7546-1-ryanpkosta@gmail.com>
On Sun, 2020-09-27 at 09:35 -0700, Ryan Kosta wrote:
> Changes since v1:
> * Made commit message more clear
> * Added description
> Note: previous patch named
> "[PATCH] fix double next comment in drivers/staging/nvec/nvec.c"
> > 8------------------------------------------------------8<
> Fixes a comment typo.
Hi Ryan.
That comment should be _below_ the --- separator line
There's no need to double the nvec: word in the subject either.
And please use the imperative.
So the email message should look something like:
---------------------------------------------------------
From: <you>
Subject: [PATCH V2] staging: nvec: Remove repeated word typo in a comment
Fix a comment typo.
Signed-off-by: <you>
---
V2: Add a commit description
<patch>
prev parent reply other threads:[~2020-09-27 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 16:35 Ryan Kosta
2020-09-27 16:45 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bff3adc94d909be7132151b1af211ed862b4126.camel@perches.com \
--to=joe@perches.com \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=p.zabel@pengutronix.de \
--cc=ryanpkosta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®