From: Dmitry Osipenko <digetx@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"David Heidelberg" <david@ixit.cz>,
"Peter Geis" <pgwipeout@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Pedro Ângelo" <pangelo@void.io>,
"Matt Merhar" <mattmerhar@protonmail.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7
Date: Thu, 2 Apr 2020 17:52:51 +0300 [thread overview]
Message-ID: <4c059f4a-111a-086b-c165-eb8ae798d606@gmail.com> (raw)
In-Reply-To: <20200402045008.GB11124@qmqm.qmqm.pl>
02.04.2020 07:50, Michał Mirosław пишет:
> On Wed, Apr 01, 2020 at 12:43:26AM +0300, Dmitry Osipenko wrote:
>> Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
>> index 7fd0b66c69b2..fb3bbf7a5fb4 100644
>> --- a/Documentation/devicetree/bindings/arm/tegra.yaml
>> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml
>> @@ -62,6 +62,13 @@ properties:
>> - toradex,colibri_t30-eval-v3
>> - const: toradex,colibri_t30
>> - const: nvidia,tegra30
>> + - items:
>> + - const: asus,grouper
>> + - const: nvidia,tegra30
>> + - items:
>> + - const: asus,tilapia
>> + - const: asus,grouper
>> + - const: nvidia,tegra30
>> - items:
>> - enum:
>> - nvidia,dalmore
>
> Is it really necessary to list every possible device using a SoC chip?
Yes, otherwise make dtbs_check will give you a warning about the unknown
compatible.
> Wouldn't it be enough to just list SoC value nvidia,tegraXYZ and allow
> any other supplemental "compatibles"?
I don't know what was the initial intention of having boards defined in
a way it's currently done, maybe Rob;Thierry;Stephen;Jon could clarify?
next prev parent reply other threads:[~2020-04-02 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 21:43 [PATCH v1 0/6] Support NVIDIA Tegra-based Acer A500 and Nexus 7 devices Dmitry Osipenko
2020-03-31 21:43 ` [PATCH v1 1/6] ARM: tegra: Add device-tree for Acer Iconia Tab A500 Dmitry Osipenko
2020-03-31 21:43 ` [PATCH v1 2/6] ARM: tegra: Add device-tree for ASUS Google Nexus 7 Dmitry Osipenko
2020-03-31 21:43 ` [PATCH v1 3/6] dt-bindings: Add vendor prefix for Acer Inc Dmitry Osipenko
2020-03-31 21:43 ` [PATCH v1 4/6] dt-bindings: ARM: tegra: Add Acer Iconia Tab A500 Dmitry Osipenko
2020-03-31 21:43 ` [PATCH v1 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7 Dmitry Osipenko
2020-04-02 4:50 ` Michał Mirosław
2020-04-02 14:52 ` Dmitry Osipenko [this message]
2020-03-31 21:43 ` [PATCH v1 6/6] ARM: tegra_defconfig: Enable options useful for Nexus 7 and Acer A500 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c059f4a-111a-086b-c165-eb8ae798d606@gmail.com \
--to=digetx@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pangelo@void.io \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome