From: Paolo Abeni <pabeni@redhat.com>
To: netdev-bot+sashiko@kernel.org, leonard@lausen.nl
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
horms@kernel.org, pablo@netfilter.org, fw@strlen.de, phil@nwl.cc,
shuah@kernel.org, daniel@iogearbox.net,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] ipv6: honor rule suppression in raw FIB lookups
Date: Tue, 17 Nov 2026 13:53:36 +0100 [thread overview]
Message-ID: <4c074303-367f-4a8f-843e-aae152260aea@redhat.com> (raw)
In-Reply-To: <179469689962.2199510.1299009420613186748@kernel.org>
On 11/14/26 23:54, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] For raw lookups, fib6_rule_suppress() (net/ipv6/fib6_rules.c)
> evaluates suppress_ifgroup against a different nexthop than the dst-…
>
> --
>
> ipv6: honor rule suppression in raw FIB lookups
>
> This patch makes fib6_rule_suppress() apply suppress_prefixlength and
> suppress_ifgroup to raw fib6_table_lookup() results. For those results it
> takes the prefix length from res->f6i and the device from res->nh. Raw
> results marked RTF_REJECT are never suppressed, so a later rule cannot
> bypass the rejection.
>
> Link: https://github.com/firewalld/firewalld/issues/1600
>
>> diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
>> index 0ffd7b47a0460..e8a44b540291d 100644
>> --- a/net/ipv6/fib6_rules.c
>> +++ b/net/ipv6/fib6_rules.c
>> @@ -283,19 +283,29 @@ INDIRECT_CALLABLE_SCOPE bool fib6_rule_suppress(struct fib_rule *rule,
>> struct fib_lookup_arg *arg)
>> {
>> struct fib6_result *res = arg->result;
>> - struct rt6_info *rt = res->rt6;
>> + struct rt6_info *rt = NULL;
>> struct net_device *dev = NULL;
>> -
>> - if (!rt)
>> - return false;
>> -
>> - if (rt->rt6i_idev)
>> - dev = rt->rt6i_idev->dev;
>> + int plen;
>> +
>> + if (arg->lookup_ptr == fib6_table_lookup) {
>> + /* Raw lookups report reject routes without an error. */
>> + if (res->fib6_flags & RTF_REJECT)
>> + return false;
>> + plen = res->f6i->fib6_dst.plen;
>> + dev = res->nh->fib_nh_dev;
>
> [Severity: Medium]
> For multipath routes, is this the same nexthop that the dst-based path
> checks?
The AI comment Looks relevant.
I think this is net-next material: I would not push behavior
change to net.
Can this be solved within nft? The wording in the commit message
sounds like it's using the wrong API.
/P
next prev parent reply other threads:[~2026-11-17 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 13:16 [PATCH net 0/2] " Leonard Lausen
2026-11-10 13:16 ` [PATCH net 1/2] " Leonard Lausen
2026-11-14 22:54 ` netdev-bot+sashiko
2026-11-17 12:53 ` Paolo Abeni [this message]
2026-11-10 13:16 ` [PATCH net 2/2] selftests: netfilter: cover IPv6 FIB rule suppression Leonard Lausen
2026-11-14 22:55 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c074303-367f-4a8f-843e-aae152260aea@redhat.com \
--to=pabeni@redhat.com \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonard@lausen.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®