From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B9FC2D0E4 for ; Mon, 14 Sep 2020 15:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D49521741 for ; Mon, 14 Sep 2020 15:01:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QJAfUbbS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725988AbgINPBf (ORCPT ); Mon, 14 Sep 2020 11:01:35 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:53570 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbgINO6S (ORCPT ); Mon, 14 Sep 2020 10:58:18 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08EEw4hP062199; Mon, 14 Sep 2020 09:58:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600095484; bh=1SvU/nMr7DHcQxF2Z5uncpmTAaIf4CZUxGtLW8DYjDU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=QJAfUbbSkgr4VBI/T4ha1n4BjE8jT2OZhuS8/KgUlhjDxpZfn2ySioOiOWd/+6vcw VflHWiF3Kv4O+N6zOQlcZLUtR8gmS90jf+NlWmqqaF695C+yYgaAIyiJCE0ioqEtLY ZGwWT7C9EdbKbQXPYfh068QpH2SQkE4xoUxDrGwM= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08EEw4hs028853 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Sep 2020 09:58:04 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 14 Sep 2020 09:58:04 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 14 Sep 2020 09:58:04 -0500 Received: from [10.250.232.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08EEw1kC007191; Mon, 14 Sep 2020 09:58:02 -0500 Subject: Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes To: Nishanth Menon CC: Rob Herring , Tero Kristo , , , References: <20200901140628.8800-1-kishon@ti.com> <20200901140628.8800-2-kishon@ti.com> <20200901145204.ayybrzqjcfhiqnfq@akan> <5f23246a-a9d7-495d-a4ec-d392ad95a450@ti.com> <4b17cace-09d5-af8c-6e7f-9358cfdceb4d@ti.com> <20200914115207.wq4pmgrszhtgctdu@akan> <9fe50c76-8d78-c1fe-e8f5-b43eecd32db8@ti.com> <20200914131436.fxtvximxcrtnqddm@akan> From: Kishon Vijay Abraham I Message-ID: <4c0a5b85-1ff9-fd3b-8d0e-82839187ecf9@ti.com> Date: Mon, 14 Sep 2020 20:28:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200914131436.fxtvximxcrtnqddm@akan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nishanth, On 14/09/20 6:44 pm, Nishanth Menon wrote: > On 17:43-20200914, Kishon Vijay Abraham I wrote: >> Hi Nishanth, >> >> On 14/09/20 5:22 pm, Nishanth Menon wrote: >>> On 16:53-20200914, Kishon Vijay Abraham I wrote: >>>> Hi Rob, >>>> >>>> On 02/09/20 1:07 pm, Kishon Vijay Abraham I wrote: >>>>> Hi Rob, >>>>> >>>>> On 02/09/20 10:24 am, Kishon Vijay Abraham I wrote: >>>>>> Hi Nishanth, >>>>>> >>>>>> On 01/09/20 8:22 pm, Nishanth Menon wrote: >>>>>>> On 19:36-20200901, Kishon Vijay Abraham I wrote: >>>>>>>> Add PCIe device tree node (both RC and EP) for the four >>>>>>>> PCIe instances here. >>>>>>>> >>>>>>>> Signed-off-by: Kishon Vijay Abraham I >>>>>>>> --- >>>>>>>>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 >>>>>>>> ++++++++++++++++++++++ >>>>>>>>   arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +- >>>>>>>>   2 files changed, 222 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> >>>>>>> Did you look at the diff of the dtbs_check before and after this >>>>>>> series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/ >>>>>> >>>>>> I didn't see any errors when I checked for individual bindings >>>>>> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check >>>>>> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml" >>>>>> >>>>>>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml >>>>>>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >>>>>>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >>>>>>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >>>>>>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >>>>>> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check >>>>>> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml" >>>>>> >>>>>>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus >>>>>>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >>>>>>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >>>>>>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >>>>>>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >>>>> >>>>> Can you give hint on why I get ranges is too long error >>>>> https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 >>>>> dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"? >>>> >>>> I debugged this and looks like PCIe "ranges" property conflicts with >>>> simple-bus. >>>> >>>> A diff like below helps to solve the issue >>>> diff --git a/schemas/simple-bus.yaml b/schemas/simple-bus.yaml >>>> index 248ac9d..ed818ef 100644 >>>> --- a/schemas/simple-bus.yaml >>>> +++ b/schemas/simple-bus.yaml >>>> @@ -39,7 +39,7 @@ patternProperties: >>>> oneOf: >>>> - items: >>>> minItems: 3 >>>> - maxItems: 6 >>>> + maxItems: 7 >>>> minItems: 0 >>>> maxItems: 1024 >>>> - $ref: "types.yaml#/definitions/flag" >>>> >>>> If this looks right to you, I can post a patch for it. Without fixing >>>> this we would see false errors for PCIe DT nodes. >>> >>> https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214 >>> >>> Part of v2020.08.1? Am i missing something? >> >> I think I was using a different repo >> https://github.com/robherring/dt-schema.git. >> >> Do you see the following issues you reported earlier with v2020.08.1? >> >> +/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: >> bus@100000: pcie@2900000:ranges: [[16777216, 0, 268439552, 0, 268439552, >> 0, 65536], [33554432, 0, 268505088, 0, 268505088, 0, 134148096]] is not >> valid under any of the given schemas (Possible causes of the failure): >> + >> /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: >> bus@100000: pcie@2900000:ranges: True was expected >> + >> /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: >> bus@100000: pcie@2900000:ranges:0: [16777216, 0, 268439552, 0, >> 268439552, 0, 65536] is too long >> + >> /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: >> bus@100000: pcie@2900000:ranges:1: [33554432, 0, 268505088, 0, >> 268505088, 0, 134148096] is too long > > > Arrgh.. you are right.. Looks like one of my PCs still had 2020.8 > instead of 2020.8.1. We just need to figure out what is going on with > syscon.yaml as against ti,j721e-system-controller.yaml.. I think I'll use the existing TI specific compatible string for syscon here. Thanks Kishon