From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753939AbdKXOjt (ORCPT ); Fri, 24 Nov 2017 09:39:49 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35309 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593AbdKXOjp (ORCPT ); Fri, 24 Nov 2017 09:39:45 -0500 X-Google-Smtp-Source: AGs4zMbWSCD6VAMqS7FxK9jQLFNUKcjQVRiaWgQIOd0WLDZ3PRDLq+7Qzh1P5Z0Rjr6BV71Uz9Ucuw== Subject: Re: [PATCH v7 07/13] slimbus: Add support for 'clock-pause' feature To: Charles Keepax Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, sdharia@codeaurora.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vinod.koul@intel.com, arnd@arndb.de References: <20171115141043.29202-1-srinivas.kandagatla@linaro.org> <20171115141043.29202-8-srinivas.kandagatla@linaro.org> <20171123072800.z2pkmelom374zr63@localhost.localdomain> From: Srinivas Kandagatla Message-ID: <4c0c8dae-fad2-8e95-c12f-cb5542fecb95@linaro.org> Date: Fri, 24 Nov 2017 14:39:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171123072800.z2pkmelom374zr63@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the Review, On 23/11/17 07:28, Charles Keepax wrote: > On Wed, Nov 15, 2017 at 02:10:37PM +0000, srinivas.kandagatla@linaro.org wrote: >> From: Sagar Dharia >> >> Per slimbus specification, a reconfiguration sequence known as >> 'clock pause' needs to be broadcast over the bus while entering low- >> power mode. Clock-pause is initiated by the controller driver. >> To exit clock-pause, controller typically wakes up the framer device. >> Since wakeup precedure is controller-specific, framework calls it via >> controller's function pointer to invoke it. >> >> Signed-off-by: Sagar Dharia >> Signed-off-by: Srinivas Kandagatla >> --- >> +/** >> + * struct slim_sched: Framework uses this structure internally for scheduling. > > Missing kernel doc for clkgear here. Will add that in next version. > >> + * @clk_state: Controller's clock state from enum slim_clk_state >> + * @pause_comp: Signals completion of clock pause sequence. This is useful when >> + * client tries to call slimbus transaction when controller is entering >> + * clock pause. >> + * @m_reconf: This mutex is held until current reconfiguration (data channel >> + * scheduling, message bandwidth reservation) is done. Message APIs can >> + * use the bus concurrently when this mutex is held since elemental access >> + * messages can be sent on the bus when reconfiguration is in progress. >> + */ >> +struct slim_sched { >> + int clkgear; >> + enum slim_clk_state clk_state; >> + struct completion pause_comp; >> + struct mutex m_reconf; >> +}; > > Thanks, > Charles >