From: Ping-Ke Shih <pkshih@realtek.com>
To: "David Härdeman" <david@hardeman.nu>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Leonard Lausen" <leonard@lausen.nl>,
Alastair D'Silva <alastair@d-silva.org>,
"Luka Gejak" <luka.gejak@linux.dev>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: RE: [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips
Date: Tue, 17 Nov 2026 07:46:44 +0000 [thread overview]
Message-ID: <4c0d81f7a207468d8bca3c3c1a5b8dc5@realtek.com> (raw)
In-Reply-To: <20261116190145.2736364-1-david@hardeman.nu>
David Härdeman <david@hardeman.nu> wrote:
> Known issue, not addressed here: when the client goes off-channel (for
> example for a background scan), the chip sometimes gives up on an MPDU
> of an A-MPDU session without sending a BAR, and keeps sending up to 64
> frames past it.
What do you expect?
rtw88 client
TX A-MPDU -->
TX BAR -->
<-- BA
I have not seen BAR for a long time. Do you really need it?
> rtw88 reports every SDIO data frame as acked, so
> mac80211 doesn't know either and can't send a BAR.
Can you check air sniffer if the A-MPDU is actually acked, or firmware
report incorrect ack?
I think mac80211 has no way to send a BAR. How can it do? Driver
tells mac80211 once it TX a set of frames?
> The client's
> reorder window then stalls until it is pushed past the hole, which
> costs a short throughput dip.
Are there some frames get missed but hardware somehow considers it
has acked them already? (I think need to check air sniffer)
> With iwlwifi clients it turned into
> bursts of up to 63 lost frames per hole because of a reorder buffer
> bug there, for which I have sent fixes:
> https://lore.kernel.org/linux-wireless/20261116155609.535595-1-david@hardeman.nu/
> I tried the hardware BAR settings (REG_BAR_MODE_CTRL thresholds, the
> BAR retry bits in the TX descriptor), a longer retry limit, MACID sleep
> for dozing clients, per-frame TX reports and a BAR sent by the driver
> after the client wakes up; none of them helped, and per-frame reports
> only came back for about one frame per A-MPDU. Ping-Ke, is there a way
> for the firmware to report which MPDU it dropped,
I think hardware's retry buffer will do it properly. If a frame exceeds
retry limit, TX report tells driver a frame is dropped. But this is only
for specific frames with SN (see rtw_tx_report_enqueue()).
> or to send the BAR
> itself?
As I know BAR is to ask peer to send BA, what does your expectation if
you can send BAR?
prev parent reply other threads:[~2026-11-17 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:01 David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 1/5] wifi: rtw88: sdio: cache the free TX page counts of " David Härdeman
2026-11-17 7:20 ` Luka Gejak
2026-11-16 19:01 ` [PATCH rtw-next 2/5] wifi: rtw88: sdio: aggregate TX frames " David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 3/5] wifi: rtw88: sdio: limit the TX queue length " David Härdeman
2026-11-17 7:21 ` Luka Gejak
2026-11-16 19:01 ` [PATCH rtw-next 4/5] wifi: rtw88: sdio: let TX in while receiving on " David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 5/5] wifi: rtw88: sdio: read neighbouring registers of the 88xx chips at once David Härdeman
2026-11-16 21:59 ` [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips Luka Gejak
2026-11-17 7:46 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c0d81f7a207468d8bca3c3c1a5b8dc5@realtek.com \
--to=pkshih@realtek.com \
--cc=alastair@d-silva.org \
--cc=david@hardeman.nu \
--cc=jernej.skrabec@gmail.com \
--cc=leonard@lausen.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®