From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbcERRJK (ORCPT ); Wed, 18 May 2016 13:09:10 -0400 Received: from mail-am1on0055.outbound.protection.outlook.com ([157.56.112.55]:10608 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752772AbcERRJH (ORCPT ); Wed, 18 May 2016 13:09:07 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; Subject: Re: [PATCH v12 06/13] task_isolation: support PR_TASK_ISOLATION_STRICT mode To: Peter Zijlstra References: <1459877922-15512-1-git-send-email-cmetcalf@mellanox.com> <1459877922-15512-7-git-send-email-cmetcalf@mellanox.com> <20160518134406.GI3193@twins.programming.kicks-ass.net> CC: Gilad Ben Yossef , Steven Rostedt , Ingo Molnar , Andrew Morton , Rik van Riel , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , "Paul E. McKenney" , Christoph Lameter , Viresh Kumar , Catalin Marinas , Will Deacon , Andy Lutomirski , , , From: Chris Metcalf Message-ID: <4c0e9098-248c-eca1-03f6-b7b2eee997a9@mellanox.com> Date: Wed, 18 May 2016 12:34:59 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160518134406.GI3193@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: DM3PR13CA0033.namprd13.prod.outlook.com (10.164.193.43) To HE1PR05MB1690.eurprd05.prod.outlook.com (10.169.119.156) X-MS-Office365-Filtering-Correlation-Id: f9f5fa35-7ca1-4a5b-8514-08d37f3a6502 X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1690;2:X8yKkbP4oA0vQEXYlZP7Duq0sJpfGGSL5PcxYJx5Ylh1Kmiw7KQnJa3tRqTnN0U6HRQwWlLEqG2Bg1cjByLvTECWVp7ENjn1oAz3U2/5uVUpfD57CwG9xXRzTlPoNZImOfT032MT/m/4Z6LCOoNuRqUxDWpqkFRzZHXJuYPxG6H0RMFH/3cnIrc99fk/Juvj;3:GwGZSE8sEBouAl/qAiI17zlDCh+v9QnAQh5vvMYIdLcnmBnaMFFvbWkZFtlJjEyvpqZZTdEBY4EFzDiA/zqfgGpnRyOYmdyXzn4wBOYpN57yUVTL9c+L35M+0/CTMNxW;25:U+vs6wc8f5cK2aoF10LLBJ75RmPVyh0du4FP92eo+4MSTOS5Tw6+mge1vR47MVsR6SPC90ih41umDrVL94rdBaPCoDvXC+G1bYNwxWVXK3BcIwIMLr9sYWcS3BupcNcN3WUOVBQ6MuwxXv51EA1ng4FGqk8b83AH3A4bDTa/wyMGLqLfa5yj6WuhXvLHp4neGO1bmA7RoHfxA1N+TD1k063pS760ub8G39XMQB95iLJOgRKzxF6HDKNzZhOhEDh8oV7GTdMsACTlpPslMRWy1QpOaLz/+QDcmdMzj4RV7QLjCkMgecnJ2jUajG8KsDpv9Tr7qLbgNGN+MmYpFm0LGM1FLbhBulnGZX6x/soDOE7nkCwe6SUTUbfN7g0LsIViCEV6TXiuDt7AWKVUejh1pWrLcziqMxx8J1iYJE6DyHw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1690; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1690;20:GKxEnKoH5p8HFMWse3KLxH1KCp1D9EoRlPrYQZMz7BlsYZ7Ry96SBcSl/65lZHEHgcM+C4evGTJ0lYGVEOt4qFPNdLkc1GahkWal9RuMEFY+Q8VlRnbftUr8RnWqc45o//gmHXhuvkXMefInBmdANgPfWKVtST5R4RO6KNKX4EhzzglEjybdKpCjrDR9IteYh1JEfIR2+BEOGcC2T/BBRMpzRF0Gj7jVBPOXSpYJu3bOfs5GeKAP9QXi4DURMYtdMQqCZayFTYBMPmebcdyW4MbhE7M1PADWQSXACrpFNfCH2gYYn6uqa5W8DX/9y5XV5O+tASHLfcJgqllU1G1nNeNGrLnAer2zkShSrR/SpQjXaNlpGTLYSXx0PIyIkabVe9bFJAgulYootb+df7h2UcVAVQ0QaiialaZf49TPe9qHu5Eksn7VUBb6+8l2GK4SG0r6lVgnholAwRXYWFzXKd1UK9sXO4gjA7WHug+72TR2F3JXNMDSEQYULGZ4oTTx;4:CbItX3SQtglud3TCM8qNLR4dXYjjQNyKfBrYV4Ntxk1Y4zN8ftG6HlCE1xHw1eWVwN4xPL9/PJZKieVmUnHIz0fsUKBExMUH5rNNAsCfvnOxphS5kjhvvK32tJ/LLmksohEh2TDacdlaroWHywcUJYGAAe26ZHicHlgvgcLbouz6Gm7drO3qi5UjGSyynJv+dGvchyc68JRmdTM0TtB466fovIkzhqsY35oQvVY9k+5ZPgICuKnduMh1mqVkz3958B32EU66ZQJl/BTj4JGsMYNNQyriXQNWed/Z612RHmsuxPNR4T0/OPJiWyFORsdEPd44FMF0IPU4sz0n5khNFTPWfjGkjCk/9EkKKSMcJewJXhh4uk1oCJp7GqvuoO/ZVWrF13iMr5VbFIVwqYsUPQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:HE1PR05MB1690;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1690; X-Forefront-PRVS: 0946DC87A1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(24454002)(377454003)(92566002)(42186005)(5004730100002)(230700001)(2906002)(66066001)(50466002)(33646002)(23746002)(189998001)(47776003)(4326007)(86362001)(50986999)(76176999)(110136002)(19580395003)(77096005)(2950100001)(5008740100001)(64126003)(4001350100001)(31696002)(6116002)(36756003)(31686004)(54356999)(15975445007)(83506001)(81166006)(586003)(8676002)(65826006)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB1690;H:[10.15.7.169];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR05MB1690;23:qjdpNTviviGsKj4B1/JNYeGzMvqbhtiYVP/mP?= =?Windows-1252?Q?VCdHKb2/il+ty0IjEP1Q9n9twLNvd63IijQAtD+JC2cB1o2rI3rb1J/v?= =?Windows-1252?Q?rHJmIMDnB/wC1eAivGtI7SMfwTdC83jKGfyxdBs8gc9jFCp/8VDRGnRP?= =?Windows-1252?Q?mqS7OT978BT5+/pZ40XSr7URPbnqTkG//zGEigVmM8Au/fys+Fn/GgNb?= =?Windows-1252?Q?JObDjrWkzwtCIH/dw3uxsWynVHsD5RGHAP400OtjEbt4tvD0wAG+tMBy?= =?Windows-1252?Q?eP04Wdossjl+w4FT7KuKHBVCoxTCv+TCeOdhoBoIc/QTPhuhB9ImqUwj?= =?Windows-1252?Q?RUUnrxHMavmscL7fCZvPecrTa6DBHRfEEHarc+oo9FcHDMK7KKKgc0Tc?= =?Windows-1252?Q?huVOz5G7GD8zyy4bKhKKdT1rFcW0JYGCjqRuUdITqVTz4WMgaY4RIxNQ?= =?Windows-1252?Q?6JvqUc6K7tDVZwU0HR8XNSNyXyqle25KkREn7/J7NUsOgUnYeYtIPjx+?= =?Windows-1252?Q?4PCjsbHM8253tF/5fSsQV94dPT/hqW+FC2WLJlwEDvl62fHA7fAW11c0?= =?Windows-1252?Q?cofacTZ5/yWzRQ/v3BVuIuS4Q6rtzbsUt2h5iqFGtRHrpQ/otjWFB9pR?= =?Windows-1252?Q?o8pHFIwEC4QGAJN0RUWLIenT3UDuN99ku3a9qnHKH0TXojvc+54V1ieg?= =?Windows-1252?Q?ZIu/l9hsDiwBIqlPC4n/XBcLljFhwB+6zmXWuI/ApmVeD7xtW+8K38Jn?= =?Windows-1252?Q?UhT3bALUz2ZvwSQZ8K1SiSugcCBlwjVjFzde/leAYDWvP2N2dgDQE2ty?= =?Windows-1252?Q?KrcRgximnTFsFS6zYGOHh76nAskmJgZLWV+HoVgx3uDwhyLbdy3h0ZlX?= =?Windows-1252?Q?/3oJtdtFGlk/xpoKIDITS5z9lkoaAqIUsaPOXHTGJ8Go8+k2+YJpL/JD?= =?Windows-1252?Q?nKp4wCO2OoOyOB9hagYZV0uU7WoGjiznh1CrE7/z/uCmLfaAhOpMaq6d?= =?Windows-1252?Q?5tla/yl+z2Pu6tVaUf9j88cVp5RAoR40WTXoiMjzPhJjw7cVOv7HdpjS?= =?Windows-1252?Q?oxIMoYovtlkqsxOojIbCUoKvitWJymFuMEkyqpOY2/wYPC2jMEI/WicI?= =?Windows-1252?Q?TbzL9s11B0pFi0iQfNkUPE=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1690;5:5X17NTdcYTBYH2tJg72gl/Y9FzAUdjos0GpC7unsCoy/j0B74Xder2d9yEyO+fLbcS2e47VykHOQfgkVigy7gF614uw3jrwPFUIudkc8HGRFN59wXO3ZXfTGmucRdXOH2dXHS8Dnhq/BJT8dHaYVqQ==;24:ExvCx1q72RLMssblJqeAXMeVrM6dzVfgmukXaEhMETyXUwq6BllSCFwPgE8QgdztamXMAXO3fJSve1CQaomfN0y3jGZAdKxdTvf54YSkZvE=;7:zrx06xYEulEuAvozamIh3dXQ+Wb5JI0JRNv0EcYFTp6m9vBELczA0cnz0qVGfHnji9PzKK5KNemDZd5msFCWampf0ioJAlCiHF06nv30kIXZCoVYmbSPtRj3wkoRkFI2nsUfpL2PHcNQl8noYLMLOu0rf+ibSPTJA+NkBGwDhuQ= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2016 16:35:12.8709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1690 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/2016 9:44 AM, Peter Zijlstra wrote: > On Tue, Apr 05, 2016 at 01:38:35PM -0400, Chris Metcalf wrote: >> +void task_isolation_interrupt(struct task_struct *task, const char *buf) >> +{ >> + siginfo_t info = {}; >> + int sig; >> + >> + pr_warn("%s/%d: task_isolation strict mode violated by %s\n", >> + task->comm, task->pid, buf); >> + > So the function name suggests this is called for interrupts, except its > purpose is to deliver a signal. Fair point. I'll name it task_isolation_deliver_signal() in the next patch series. > Now, in case of exceptions the violation isn't necessarily _by_ the task > itself. You might want to change that to report the exception > type/number instead of the affected task. Well, we do report whatever exception information we have. For example a page fault exception will report the address or whatever other info is handy; it's easy to tune since it's just a vsnprintf of some varargs from the architecture layer. For things like IPIs or TLB invalidations or whatever, the code currently just reports "interrupt"; I could arrange to pass down more informative varargs from the caller for that as well. Let me look into it. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com