From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Eugen Hristev <eugen.hristev@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool
Date: Mon, 27 Nov 2023 14:05:50 +0100 [thread overview]
Message-ID: <4c15c9a4-bf04-492d-9e02-d630092b6caa@collabora.com> (raw)
In-Reply-To: <CAGXv+5GmjZbzLbxADoNXDiF8dTAwnxva29vuM0FG8vY-6wTJcQ@mail.gmail.com>
Il 27/11/23 05:00, Chen-Yu Tsai ha scritto:
> On Mon, Oct 23, 2023 at 5:05 PM Eugen Hristev
> <eugen.hristev@collabora.com> wrote:
>>
>> On 10/13/23 02:02, Chen-Yu Tsai wrote:
>>> Tentacruel and Tentacool are MT8186 based Chromebooks based on the
>>> Krabby design.
>>>
>>> Tentacruel, also known as the ASUS Chromebook CM14 Flip CM1402F, is a
>>> convertible device with touchscreen and stylus.
>>>
>>> Tentacool, also known as the ASUS Chromebook CM14 CM1402C, is a laptop
>>> device. It does not have a touchscreen or stylus.
>>>
>>> The two devices both have two variants. The difference is a second
>>> source touchpad controller that shares the same address as the original,
>>> but is incompatible.
>>>
>>> The extra SKU IDs for the Tentacruel devices map to different sensor
>>> components attached to the Embedded Controller. These are not visible
>>> to the main processor.
>>>
>>> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
>>> ---
>>> arch/arm64/boot/dts/mediatek/Makefile | 4 +
>>> .../dts/mediatek/mt8186-corsola-krabby.dtsi | 130 ++
>>> .../mt8186-corsola-tentacool-sku327681.dts | 49 +
>>> .../mt8186-corsola-tentacool-sku327683.dts | 26 +
>>> .../mt8186-corsola-tentacruel-sku262144.dts | 44 +
>>> .../mt8186-corsola-tentacruel-sku262148.dts | 28 +
>>> .../boot/dts/mediatek/mt8186-corsola.dtsi | 1704 +++++++++++++++++
>>> 7 files changed, 1985 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-krabby.dtsi
>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327681.dts
>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts
>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262144.dts
>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts
>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>>>
>
> [...]
>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>>> new file mode 100644
>>> index 000000000000..42ebab1bafeb
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>>> @@ -0,0 +1,1704 @@
>
> [...]
>
>>
>> Hi Chen-Yu,
>>
>> These two aud_gpio_tdm empty entries cause this message to be printed:
>>
>> [ 12.949519] mt8186_mt6366_rt1019_rt5682s sound: there is not valid
>> maps for state aud_gpio_tdm_off
>> [ 12.959025] mt8186_mt6366_rt1019_rt5682s sound: there is not valid
>> maps for state aud_gpio_tdm_on
>
> I guess we need to teach the sound driver to ignore empty pinmux states?
...and we need to teach to the bindings that the aud_gpio_tdm_{off,on} are
optional states and can be omitted.
Cheers,
Angelo
>
> ChenYu
next prev parent reply other threads:[~2023-11-27 13:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 23:02 [PATCH 0/9] arm64: dts: mediatek: Add MT8186 Corsola Chromebooks Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 1/9] dt-bindings: arm: mediatek: Sort entries by SoC then board compatibles Chen-Yu Tsai
2023-10-13 15:04 ` Conor Dooley
2023-10-12 23:02 ` [PATCH 2/9] dt-bindings: arm: mediatek: Add MT8186 Tentacruel / Tentacool Chromebooks Chen-Yu Tsai
2023-10-13 15:11 ` Conor Dooley
2023-10-13 17:29 ` Chen-Yu Tsai
2023-10-13 17:55 ` Conor Dooley
2023-10-13 18:19 ` Chen-Yu Tsai
2023-10-14 13:40 ` Conor Dooley
2023-10-16 6:15 ` Chen-Yu Tsai
2023-10-18 15:07 ` Conor Dooley
2023-10-20 9:12 ` Krzysztof Kozlowski
2023-10-20 10:06 ` Chen-Yu Tsai
2023-11-24 14:08 ` Conor Dooley
2023-11-27 2:23 ` Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 3/9] dt-bindings: arm: mediatek: Add MT8186 Steelix Chromebook Chen-Yu Tsai
2023-10-13 15:12 ` Conor Dooley
2023-10-12 23:02 ` [PATCH 4/9] dt-bindings: arm: mediatek: Add MT8186 Rusty Chromebook Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 5/9] dt-bindings: arm: mediatek: Add MT8186 Magneton Chromebooks Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 6/9] arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool Chen-Yu Tsai
2023-10-16 9:19 ` AngeloGioacchino Del Regno
2023-10-16 22:09 ` Chen-Yu Tsai
2023-10-16 9:21 ` Eugen Hristev
2023-10-16 17:12 ` Chen-Yu Tsai
2023-10-23 9:05 ` Eugen Hristev
2023-11-27 4:00 ` Chen-Yu Tsai
2023-11-27 13:05 ` AngeloGioacchino Del Regno [this message]
2023-12-01 15:32 ` Eugen Hristev
2023-10-12 23:02 ` [PATCH 7/9] arm64: dts: mediatek: Introduce MT8186 Steelix Chen-Yu Tsai
2023-10-16 8:36 ` Eugen Hristev
2023-11-27 3:56 ` Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 8/9] arm64: dts: mediatek: Add MT8186 Steelix platform based Rusty Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 9/9] arm64: dts: mediatek: Add MT8186 Magneton Chromebooks Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c15c9a4-bf04-492d-9e02-d630092b6caa@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®