mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Nam Tran <trannamatk@gmail.com>, andy@kernel.org
Cc: geert@linux-m68k.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, christophe.jaillet@wanadoo.fr,
	corbet@lwn.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	florian.fainelli@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/5] auxdisplay: add TI LP5812 4×3 Matrix RGB LED Driver
Date: Sun, 27 Apr 2025 09:04:12 -0700	[thread overview]
Message-ID: <4c17ae51-475e-4bd2-8bbf-c5e3233ef319@infradead.org> (raw)
In-Reply-To: <20250427082447.138359-3-trannamatk@gmail.com>

Hi--

On 4/27/25 1:24 AM, Nam Tran wrote:
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index bedc6133f970..896f02b9a06b 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -539,6 +539,23 @@ config ARM_CHARLCD
>  	  line and the Linux version on the second line, but that's
>  	  still useful.
>  
> +#
> +# TI LP5812 matrix RGB LED driver section
> +#
> +config LP5812

Missing one tab of indentation on all lines below here:

> +tristate "Enable LP5812 support LED matrix 4x3"
> +depends on I2C
> +help
> +  If you say Y here you get support for TI LP5812 LED driver.
> +
> +  The LP5812 is a 4 × 3 matrix RGB LED driver with autonomous
> +  animation engine control.
> +
> +  To compile this driver as a module, choose M here: the
> +  module will be called lp5812.
> +
> +  If unsure, say N.
> +
>  endif # AUXDISPLAY

-- 
~Randy


  reply	other threads:[~2025-04-27 16:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-27  8:24 [PATCH v8 0/5] auxdisplay: add support for TI LP5812 4x3 Matrix LED driver Nam Tran
2025-04-27  8:24 ` [PATCH v8 1/5] dt-bindings: auxdisplay: add TI LP5812 4×3 Matrix RGB LED Driver Nam Tran
2025-04-27  8:24 ` [PATCH v8 2/5] " Nam Tran
2025-04-27 16:04   ` Randy Dunlap [this message]
2025-04-28 17:39     ` Nam Tran
2025-04-27  8:24 ` [PATCH v8 3/5] docs: ABI: Document LP5812 sysfs interfaces Nam Tran
2025-04-27  8:24 ` [PATCH v8 4/5] docs: auxdisplay: document TI LP5812 RGB LED driver Nam Tran
2025-04-27  8:24 ` [PATCH v8 5/5] arm64: dts: Add LP5812 node for Raspberry Pi 4 Model B Nam Tran
2025-04-27  9:35 ` [PATCH v8 0/5] auxdisplay: add support for TI LP5812 4x3 Matrix LED driver Andy Shevchenko
2025-04-28 10:37   ` Pavel Machek
2025-04-28 11:34     ` Geert Uytterhoeven
2025-04-28 17:29       ` Nam Tran
2025-04-28 20:18         ` Pavel Machek
2025-04-29 17:02           ` Nam Tran
2025-04-29 19:47             ` Andy Shevchenko
2025-05-07 16:42               ` Nam Tran
2025-05-08  8:24                 ` Andy Shevchenko
2025-05-08 13:26                   ` Lee Jones
2025-05-08 14:26                     ` Nam Tran
2025-05-08 14:46                       ` Andy Shevchenko
2025-05-08 15:01                         ` Lee Jones
2025-05-10  7:48                           ` Nam Tran
2025-05-12  6:05                             ` Andy Shevchenko
2025-05-12 17:38                               ` Nam Tran
2025-05-12 17:44                                 ` Andy Shevchenko
2025-05-13  8:35                                   ` Lee Jones
2025-05-13  8:10                                 ` Geert Uytterhoeven
2025-05-13  8:50                                   ` Lee Jones
2025-04-30  7:15             ` Pavel Machek
2025-05-05  7:24               ` Nam Tran
2025-05-08  8:38             ` Pavel Machek
2025-04-28 16:37   ` Nam Tran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c17ae51-475e-4bd2-8bbf-c5e3233ef319@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andy@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=trannamatk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®