From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out.smtpout.orange.fr (out-18.smtpout.orange.fr [193.252.22.18]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4296114A09E; Wed, 19 Mar 2025 15:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742399304; cv=none; b=mU6QAuICi6j/5Eh7G31jpYktqFV50kcA65cknZDG3bH4kxnNejoq8P8clNVt9qLLlR2HpVtxvIOgXMNQLi9iy4AudhzehlULUj5vGz8ZINhDn40qg026v22VoX4i1f7u6ADUn+c/69YV5d0XOFmN6CBEFsl6CX5716QEglbAiQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742399304; c=relaxed/simple; bh=TWNrwxifGY3EzCLYJfiO7rO1Ae11gGERZQ9pPIpWJFk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=sYucbtikZPmpqDrEU/x03xum5hPijKVPvkZbisJ4EKu6FS7HldINFwkzXJZGCmUIPbfkeZgRCK8uklXwktaBpGLhPuefmekg1wFGfky8AzdibGyYTiO1GLFLNvsKxbgYAljABfFNTSZVSi0NzIhDVQ2CVHlNOOyn8EgjV59DTQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr; spf=pass smtp.mailfrom=wanadoo.fr; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b=RTXnJnGX; arc=none smtp.client-ip=193.252.22.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b="RTXnJnGX" Received: from [172.16.82.72] ([124.33.176.97]) by smtp.orange.fr with ESMTPA id uveJtyP6dQBhYuveOtlLnP; Wed, 19 Mar 2025 16:48:17 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1742399297; bh=drRXaJR0UoQ5nPULEuhz5/B+tox7MBOIWrTIUebRvQg=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=RTXnJnGX4JF+onW8BdM2h1yrn9bbnTWZ+u8CV4sHASwQ7dD1n9Otl1R7l5ne9HkTf 9f4Nbs0mls1/zZgh98YNzlK4e9Uka5uXCRGaWHx4E4ENOI4Q4lSFrf2f1niqHC+VlX pt+tqg6EAX1Q6FUfEds6dcKCbUDhma2aPSQCBJjAHB50ZWie7JLbnBPZmBKpbv+ku6 WCaTdTkQJWMSM7L8WE6v2h9PL0gzUaRpvm2DIGzrShlabVFjwZg+77svuJEW0q20gg 14rFIHTfWJ3ThQJJ+tnrv6ioFLI8WAuJ0X6Ui/Ty5+OqFfcQz0eenD9MjGqydJxbG8 xrwaG/mJJBfBw== X-ME-Helo: [172.16.82.72] X-ME-Auth: bWFpbGhvbC52aW5jZW50QHdhbmFkb28uZnI= X-ME-Date: Wed, 19 Mar 2025 16:48:17 +0100 X-ME-IP: 124.33.176.97 Message-ID: <4c221c24-05c4-4be2-ad9b-e5a58968b5b0@wanadoo.fr> Date: Thu, 20 Mar 2025 00:48:06 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: can-transceiver: Re-instate "mux-states" property presence check From: Vincent Mailhol To: Geert Uytterhoeven Cc: linux-can@vger.kernel.org, linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Marc Kleine-Budde , Vinod Koul , Kishon Vijay Abraham I , Peter Rosin , Aswath Govindraju References: <6bcfde63b3a6b25640a56be2e24a357e41f8400f.1742390569.git.geert+renesas@glider.be> <9875d99a-4e16-4f0e-9249-69f0acc4c890@wanadoo.fr> Content-Language: en-US Autocrypt: addr=mailhol.vincent@wanadoo.fr; keydata= xjMEZluomRYJKwYBBAHaRw8BAQdAf+/PnQvy9LCWNSJLbhc+AOUsR2cNVonvxhDk/KcW7FvN LFZpbmNlbnQgTWFpbGhvbCA8bWFpbGhvbC52aW5jZW50QHdhbmFkb28uZnI+wrIEExYKAFoC GwMFCQp/CJcFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQTtj3AFdOZ/IOV06OKrX+uI bbuZwgUCZx41XhgYaGtwczovL2tleXMub3BlbnBncC5vcmcACgkQq1/riG27mcIYiwEAkgKK BJ+ANKwhTAAvL1XeApQ+2NNNEwFWzipVAGvTRigA+wUeyB3UQwZrwb7jsQuBXxhk3lL45HF5 8+y4bQCUCqYGzjgEZx4y8xIKKwYBBAGXVQEFAQEHQJrbYZzu0JG5w8gxE6EtQe6LmxKMqP6E yR33sA+BR9pLAwEIB8J+BBgWCgAmFiEE7Y9wBXTmfyDldOjiq1/riG27mcIFAmceMvMCGwwF CQPCZwAACgkQq1/riG27mcJU7QEA+LmpFhfQ1aij/L8VzsZwr/S44HCzcz5+jkxnVVQ5LZ4B ANOCpYEY+CYrld5XZvM8h2EntNnzxHHuhjfDOQ3MAkEK In-Reply-To: <9875d99a-4e16-4f0e-9249-69f0acc4c890@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19/03/2025 at 23:06, Vincent Mailhol wrote: > For some reasons, I received your message twice (with a two minutes > interval between both messages). These look identical. I am answering > the most recent. :) > > On 19/03/2025 at 22:27, Geert Uytterhoeven wrote: >> On the Renesas Gray Hawk Single development board: >> >> can-transceiver-phy can-phy0: /can-phy0: failed to get mux-state (0) >> >> "mux-states" is an optional property for CAN transceivers. However, >> mux_get() always prints an error message in case of an error, including >> when the property is not present, confusing the user. > > Hmmm, I understand why you are doing this patch. But on the long term, > wouldn't it make more sense to have a devm_mux_state_get_optional()? Or > maybe add a property somewhere to inform devm_mux_state_get() that this > is optional? > > Regardless, just see this as an open question. I am OK with the approach > of your patch. Ah, and I just realized that you mentioned the exact same thing under the --- cutter, which for some reasons my eyes refused to see. Sorry for the noise. >> Fix this by re-instating the property presence check. >> >> This is bascially a revert of commit d02dfd4ceb2e9f34 ("phy: >> can-transceiver: Drop unnecessary "mux-states" property presence >> check"), with two changes: >> 1. Use the proper API for checking whether a property is present, >> 2. Do not print an error message, as the mux core already takes care >> of that. >> >> Fixes: d02dfd4ceb2e9f34 ("phy: can-transceiver: Drop unnecessary "mux-states" property presence check")> Signed-off-by: Geert Uytterhoeven > > Notwithstanding of above comment: > > Reviewed-by: Vincent Mailhol Yours sincerely, Vincent Mailhol