From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E84C6C433E0 for ; Thu, 4 Mar 2021 20:57:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C55964F69 for ; Thu, 4 Mar 2021 20:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233854AbhCDU52 (ORCPT ); Thu, 4 Mar 2021 15:57:28 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:42618 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbhCDU5N (ORCPT ); Thu, 4 Mar 2021 15:57:13 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 124Ku0we019009; Thu, 4 Mar 2021 14:56:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1614891360; bh=KQoevqNLdq6Vcqe7xjay1VRDOuM0RiWmMq8okhEq7ic=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=fgb3unhSTrmmj9vU82YIe5gyRn1s4ROHL06A7F8wBnz4lc81erEHp5foT8ybuC3HM zTAn1Irg0HB8YInd71KpwuDfCgiRycEoLyPOzjjKqF62oy5Y9czpZWJ37x9ornf3e/ I4NENCXn1IFyO8RyKHSJxcsUndxnixe9400ykAAg= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 124Ku0Dm009620 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Mar 2021 14:56:00 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 4 Mar 2021 14:55:59 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 4 Mar 2021 14:55:59 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 124KtvkN009698; Thu, 4 Mar 2021 14:55:58 -0600 Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put() To: Tony Lindgren , Daniel Lezcano , Thomas Gleixner CC: Keerthy , , , References: <20210304072135.52712-1-tony@atomide.com> <20210304072135.52712-3-tony@atomide.com> From: Grygorii Strashko Message-ID: <4c23ce3e-3304-b10d-5054-f421822b5dc2@ti.com> Date: Thu, 4 Mar 2021 22:55:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210304072135.52712-3-tony@atomide.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 09:21, Tony Lindgren wrote: > We have of_translate_address() already do of_node_put() as needed. > I probably looked at __of_translate_address() earlier by accident > that of_translate_address() uses. I do not see of_node_put() in of_translate_address() and __of_translate_address() is doing of_node_get(dev); ? > > Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") > Signed-off-by: Tony Lindgren > --- > drivers/clocksource/timer-ti-dm-systimer.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c > --- a/drivers/clocksource/timer-ti-dm-systimer.c > +++ b/drivers/clocksource/timer-ti-dm-systimer.c > @@ -265,7 +265,6 @@ static void __init dmtimer_systimer_assign_alwon(void) > pa == 0x48318000) > continue; > > - of_node_put(np); > break; > } > } > @@ -300,7 +299,6 @@ static u32 __init dmtimer_systimer_find_first_available(void) > continue; > } > > - of_node_put(np); > break; > } > } > -- Best regards, grygorii