From: Sean Anderson <sean.anderson@linux.dev>
To: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dma: Trace API
Date: Thu, 29 Aug 2024 10:24:52 -0400 [thread overview]
Message-ID: <4c2c6b24-aee1-495f-ab47-662e1e818f4b@linux.dev> (raw)
In-Reply-To: <20240829041912.GB4408@lst.de>
On 8/29/24 00:19, Christoph Hellwig wrote:
> I'd change the subject to
>
> dma-mapping: add tracing for dma-mapping API calls
OK
> On Mon, Aug 26, 2024 at 04:32:40PM -0400, Sean Anderson wrote:
>> When debugging drivers, it can often be useful to trace when memory gets
>> (un)mapped for DMA (and can be accessed by the device). Add some
>> tracepoints for this purpose.
>>
>> We use unsigned long long instead of phys_addr_t and dma_addr_t (and
>> similarly %llx instead of %pa) because libtraceevent can't handle
>> typedefs.
>
> and a __u64 would seem like the better type here.
libtraceevent can't handle typedefs, including u64.
> otherwise this looks fine to me. I can do the tweaks as I'll apply
> the patch if needed.
>
--Sean
next prev parent reply other threads:[~2024-08-29 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 20:32 Sean Anderson
2024-08-29 4:19 ` Christoph Hellwig
2024-08-29 14:24 ` Sean Anderson [this message]
2024-09-03 7:25 ` Christoph Hellwig
2024-09-03 13:21 ` Steven Rostedt
2024-09-03 14:36 ` Sean Anderson
2024-09-04 0:53 ` Steven Rostedt
2024-09-04 4:15 ` Christoph Hellwig
2024-09-05 17:00 ` Sean Anderson
2024-09-05 16:59 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c2c6b24-aee1-495f-ab47-662e1e818f4b@linux.dev \
--to=sean.anderson@linux.dev \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®