mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sean Young <sean@mess.org>, Brad Love <brad@nextdimension.cc>
Cc: linux-media <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Antti Palosaari <crope@iki.fi>,
	Jan Pieter van Woerkom <jp@jpvw.nl>
Subject: [RFC PATCH][DO NOT COMMIT] media: dvb_frontend: Support concurrent DVB-T/DVB-T2 scan
Date: Thu, 11 Jun 2020 13:57:13 +0200	[thread overview]
Message-ID: <4c32558d-3be7-9a57-b655-65c744c1e532@free.fr> (raw)

Some demodulators (e.g. si2168) are able to scan for DVB-T and DVB-T2
signals concurrently. Use SYS_DVBT_AUTO for this purpose.
---
This is a Request For Comments from media maintainers and users :-)

One issue: suppose DVB Project publishes DVB-T3 in a few years.
Today's demods might handle T/T2, but they won't handle T3, while users
may expect SYS_DVBT_AUTO to mean "all DVB-T standards".

Therefore, perhaps the delsys name should be explicit,
like SYS_DVBT_DVBT2 or SYS_DVBT_1_2.
Then if/when DVB_T3 appears, we can add SYS_DVBT_1_2_3 ???

Or maybe use the FE_CAN_2G_MODULATION and hypothetical FE_CAN_3G_MODULATION

Or maybe, with several standards having a v2 and possibly v3 in the future,
delivery system might move to a bitmask approach? (API issues though)

Reference to related implementation:
https://patchwork.kernel.org/patch/10744999/
---
 drivers/media/dvb-frontends/si2168.c | 2 +-
 include/uapi/linux/dvb/frontend.h    | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 14b93a7d3358..8578b8917955 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -624,7 +624,7 @@ static int si2168_deselect(struct i2c_mux_core *muxc, u32 chan)
 }
 
 static const struct dvb_frontend_ops si2168_ops = {
-	.delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A},
+	.delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBT_AUTO, SYS_DVBC_ANNEX_A},
 	.info = {
 		.name = "Silicon Labs Si2168",
 		.frequency_min_hz      =  48 * MHz,
diff --git a/include/uapi/linux/dvb/frontend.h b/include/uapi/linux/dvb/frontend.h
index 4f9b4551c534..3a6348748041 100644
--- a/include/uapi/linux/dvb/frontend.h
+++ b/include/uapi/linux/dvb/frontend.h
@@ -600,6 +600,8 @@ enum fe_rolloff {
  *	Terrestrial TV: DVB-T
  * @SYS_DVBT2:
  *	Terrestrial TV: DVB-T2
+ * @SYS_DVBT_AUTO:
+ *	Terrestrial TV: Autodetect DVB-T gen
  * @SYS_ISDBT:
  *	Terrestrial TV: ISDB-T
  * @SYS_ATSC:
@@ -645,6 +647,7 @@ enum fe_delivery_system {
 	SYS_DVBT2,
 	SYS_TURBO,
 	SYS_DVBC_ANNEX_C,
+	SYS_DVBT_AUTO,
 };
 
 /* backward compatibility definitions for delivery systems */
-- 
2.17.1

             reply	other threads:[~2020-06-11 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 11:57 Marc Gonzalez [this message]
2021-12-14 15:06 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c32558d-3be7-9a57-b655-65c744c1e532@free.fr \
    --to=marc.w.gonzalez@free.fr \
    --cc=brad@nextdimension.cc \
    --cc=crope@iki.fi \
    --cc=jp@jpvw.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®