From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7619CC43381 for ; Thu, 18 Mar 2021 17:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 259C064F30 for ; Thu, 18 Mar 2021 17:56:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbhCRRzx (ORCPT ); Thu, 18 Mar 2021 13:55:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57114 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbhCRRzf (ORCPT ); Thu, 18 Mar 2021 13:55:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616090134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIthaCPfEMaPsdAY5ThVlMRUnMT/maNnKeXQkXykv2Q=; b=Hzvpy8O76p8X1MbwgAZ1cO3+o7UP5Npk2GsF3U1cgyOtKMf34S6F6qUuCxMtPh73s24mVQ qVHQzVtpkt43FNu1hYiDb10HXZa3KO5J81+yvFgd3AwFOhKX3M1YOiXqq8mXSbzTQzcYw3 1XSoX+qD9MMeBq94vPRqnB5DqgbFR0A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-qnJvSdofNPOkGHUF8v3GVw-1; Thu, 18 Mar 2021 13:55:33 -0400 X-MC-Unique: qnJvSdofNPOkGHUF8v3GVw-1 Received: by mail-wm1-f71.google.com with SMTP id c7so12165778wml.8 for ; Thu, 18 Mar 2021 10:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LIthaCPfEMaPsdAY5ThVlMRUnMT/maNnKeXQkXykv2Q=; b=Wm1lOAEGyHyo1meww0hoQ//lLMi0GX8Kbu5nGx7xc7UOobuQUsDgNpEtxTjLGylqIu sioI2BFsSfL/L9OcHZKcO7GA/uZ4I9NO+Hh+h2Sm7llm3Dz5VSuRtnGGnkN8Q/PvM3U5 qRsBPvtYDj1pCoOq4PKxUDoO6FQsgukGXujqrR4uPR3tm+F1RvUyk3Saurnc9B/nQ8nc 5l83ONod7139o/JrDb8GRyRq+tHGM97dKMlWOl9b2kdgGt1bWjjwZI4SC2G/QYyBUsWi 9K3wRG5hAvu5KJ5ysyuaDeLqo0Pvx0wfsMFbGDWF5ErDnC9hryG1ITwIhBWOlap5zABO +lKw== X-Gm-Message-State: AOAM532RAmCwZAR6lM1dCYYQGP9Mh9OB4GPsWrXpYKyWr1DSAPHrrigD 7ZF5xGfDy7iMKw3UKAKUrzFi45xMRhucEzsjzopMSbCFYRWQ4oLi2ScZWbW7H0eBLJs++6rBc7L TyYRY9+t8ZQL8baVuI5ZDPXZF X-Received: by 2002:a5d:5744:: with SMTP id q4mr489542wrw.390.1616090132304; Thu, 18 Mar 2021 10:55:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzngAEXRO5HNCZLAOI0ZJiIVObmYJ3MwjuzQ6tHtgjDNK7r9zMdUo5YDT7qVH2LRtDU/xCMiA== X-Received: by 2002:a5d:5744:: with SMTP id q4mr489531wrw.390.1616090132098; Thu, 18 Mar 2021 10:55:32 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u2sm4110393wmm.5.2021.03.18.10.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 10:55:31 -0700 (PDT) Subject: Re: [PATCH] KVM: X86: Fix missing local pCPU when executing wbinvd on all dirty pCPUs To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Nadav Amit References: <1615517151-7465-1-git-send-email-wanpengli@tencent.com> From: Paolo Bonzini Message-ID: <4c37a4f6-8b73-9285-0aa5-2e86350b3b06@redhat.com> Date: Thu, 18 Mar 2021 18:55:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1615517151-7465-1-git-send-email-wanpengli@tencent.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/21 03:45, Wanpeng Li wrote: > From: Wanpeng Li > > We should execute wbinvd on all dirty pCPUs when guest wbinvd exits > to maintain datat consistency in order to deal with noncoherent DMA. > smp_call_function_many() does not execute the provided function on > the local core, this patch replaces it by on_each_cpu_mask(). > > Reported-by: Nadav Amit > Cc: Nadav Amit > Signed-off-by: Wanpeng Li > --- > arch/x86/kvm/x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 012d5df..aa6d667 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -6638,7 +6638,7 @@ static int kvm_emulate_wbinvd_noskip(struct kvm_vcpu *vcpu) > int cpu = get_cpu(); > > cpumask_set_cpu(cpu, vcpu->arch.wbinvd_dirty_mask); > - smp_call_function_many(vcpu->arch.wbinvd_dirty_mask, > + on_each_cpu_mask(vcpu->arch.wbinvd_dirty_mask, > wbinvd_ipi, NULL, 1); > put_cpu(); > cpumask_clear(vcpu->arch.wbinvd_dirty_mask); > Queued, thanks. Paolo