From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13BDE312811 for ; Tue, 13 Jan 2026 08:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768294641; cv=none; b=hQhvoqKScfVUjOL3ChkpYLmYxYu5O3BhwqjRe7aw5a+8n5ADi7xPy8IJkpYKXaqc4+4UkDWMiIQSxxwPwV/xbiSIDypwunhTImzQRBOemm0YZbE53vwfU/8qCoRKIzkTdW1dWAdkht8dP7Bo0Rzzeia2ek9tZ/+1/xedu0LDpHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768294641; c=relaxed/simple; bh=koHSxNCeEUmGjnnid4pRpHUKl1uq9JmV7tkYW/NjX3E=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=cRxT+/4sOtbgWOgTJ4v4CwIl+Yqrl8qNpaYTvztwwIflClmg+esjowEr7TJOPYLMtcvwUR+SkNDKt8udpNXIjhUxpvzjS67mU/izmIzIsABrHHiOi7NG6dBRMX2WbW6KgBts0OnsgilKoJKFc7Oli2WaFqOrsBomYWOVLaLaxSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lfTtZSsb; arc=none smtp.client-ip=209.85.221.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lfTtZSsb" Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-42fbad1fa90so6207743f8f.0 for ; Tue, 13 Jan 2026 00:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768294638; x=1768899438; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=jK9iGnImrwXMKC1YV73/07y1jP26PbJgrtzA5NzDhic=; b=lfTtZSsbn9n2tP4YDvsLM7gjXpVLZMZSlE2cdKwzCxPB7CNG5GeXyWzDiKbzxLFhNH seHQFp9mHOPfoWhTsHKktgGvJm4ep4llaBSR6Kr8JfaAFx8tCEUc22IICo9bJHmu2vSn 4ZWg+1oHW2obZ5hgTp73YJ0gExo73mLetHekR0BWlHTzNFU3+WdH4f+t6HjMea9rjmRk ES6sttCUIz8lfUAxhn3iyjHq4QSMKiHnkLPLvTkrerWw0iG+UjADe/C6Bidy5e2NuUWT nViGik2bTURuBTcHhQUJtf4jYFH0q18j5MLWkf/TeD0PJ+vLyO4a9I5S+wCP2EMzVkvr 5yBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768294638; x=1768899438; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jK9iGnImrwXMKC1YV73/07y1jP26PbJgrtzA5NzDhic=; b=RIWhcgKu95F9ZKksZrFRSklN+GAENX+IZeLxSZp1unENztD2OsD3qcn40kJw2ej/AH yCd2nU0jCNDv5nav8ESVbOF43gUawI0hcAMkRpu7ZN/HP8ihj+kTMxOMHhjpMKYRUN3G x6UuwG4T5ic0jrsRMhpLuYxjhyHroi4t8Jy7/TtMOdpVS/sufJUpayLjCb6cBgZgKidQ 1Ec0GAtKOuLDPVJYFeEjq6p7geuWzm5nIOAgGE6cWfcZJZEarI9C1EVvQrx9Tzt8JsJ6 wE+H8q7HEXgkD7MDY5Dxy4kKND8/zh1X7Wpp/G/ympQy/WlC6zq1Ny7xTMQ+eMk2n1Vg zQOA== X-Gm-Message-State: AOJu0YwZBOi2lKPP1BR7gemKJOnjtzopWLo3ckf4Aa54TNWBGA+AkttQ nP1FkyP6DQlnhmdXP29MTTXf5NOqLIrlsc67jqiFX2Pohm04IYgWU11dzHdnCri+hnM= X-Gm-Gg: AY/fxX4xmrJKKlDIdjYO5gEnbg6Stkf7wMUsv8r3d8e9B6oAOtvpYoPpiuHZyGd2hvW AAHNtvO4fCY4cqtJvGvnFd2TTNTM1qoeu1rJJTf90PQ4FPhZNaOwVk9Znecc51d10pm6VmDXpfQ NKzVW8Jubtdhb3wKkN+00b5G84t2KTBmxMAUDgLcz/PxUQs5r0V2XcfoFUa6KEvakY8RjKlEnl2 0oOEDU1iw7hrG1bogjHGyLCb/VMuAOJSR/dH3BdvK+4iGp+AqBMIFjXQ98klvqJzuK3XQ9lEbkX utPFghkDz9FeRxK9ljIICcY2JIayVBBdA9zmDYZPCx0jZrsxhI0QExHyjTtIRr7i7ynIiLzSDRs tVb4gUDl8zLc77ey+uO56Bq/XTbjWYUan8nLSRBPc7zx5bW+eEeS8IAg+wFsDzxwWfsKMFMQhwJ Qrt+w0/KBhI/5ydWx16q9bJF5/YoVs9/BHq/Dyz9HZgqr+OAXxDw== X-Google-Smtp-Source: AGHT+IEoroP5S+dVEfqizCk6v6TXscGzJC2JToIVySdFg4XW8wpYBsON721Sk6e0U9IJbe9zm/YMPg== X-Received: by 2002:a5d:42c5:0:b0:432:dc23:34f with SMTP id ffacd0b85a97d-432dc2307abmr12998698f8f.53.1768294638276; Tue, 13 Jan 2026 00:57:18 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080::fa42:7768? ([2a01:e0a:3d9:2080::fa42:7768]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm43163902f8f.31.2026.01.13.00.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 00:57:17 -0800 (PST) Message-ID: <4c380dd3-ced4-49b1-a4b6-3c3f5bca1124@linaro.org> Date: Tue, 13 Jan 2026 09:57:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi To: Avinal Kumar , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch References: <20260109155203.34886-1-avinal.xlvii@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260109155203.34886-1-avinal.xlvii@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 1/9/26 16:52, Avinal Kumar wrote: > Add mipi_dsi_shutdown_peripheral_multi function and mark > mipi_dsi_shutdown_peripheral fucntion as deprecated. ^^^^^^^^ Please fix typo > > Signed-off-by: Avinal Kumar > --- > drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index a712e177b350..2fed50172a44 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet); > * mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command > * @dsi: DSI peripheral device > * > + * This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() > + * instead. > + * > * Return: 0 on success or a negative error code on failure. > */ > int mipi_dsi_shutdown_peripheral(struct mipi_dsi_device *dsi) > @@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, > } > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline_multi); > > +/** > + * mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command > + * @ctx: Context for multiple DSI transactions > + * > + * Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that > + * makes it convienient to make seeral calls in a row. ^^^^^^^^^^^ Please fix typo > + */ > +void mipi_dsi_shutdown_peripheral_multi(struct mipi_dsi_multi_context *ctx) > +{ > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = &dsi->dev; > + int ret; > + > + if (ctx->accum_err) > + return; > + > + ret = mipi_dsi_shutdown_peripheral(dsi); > + if (ret < 0) { > + ctx->accum_err = ret; > + dev_err(dev, "Failed to shutdown peripheral: %d\n", > + ctx->accum_err); > + } > +} > +EXPORT_SYMBOL(mipi_dsi_shutdown_peripheral_multi); > + > static int mipi_dsi_drv_probe(struct device *dev) > { > struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 3aba7b380c8d..19ccdf5eeb5f 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx, > void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, > u16 scanline); > void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx); > +void mipi_dsi_shutdown_peripheral_multi(struct mipi_dsi_multi_context *ctx); > > /** > * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet Please use scripts/checkpatch.pl on your patches Thanks, Neil