From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
ilia.lin@kernel.org, rafael@kernel.org, viresh.kumar@linaro.org,
ulf.hansson@linaro.org, quic_sibis@quicinc.com,
quic_rjendra@quicinc.com, danila@jiaxyga.com,
neil.armstrong@linaro.org, otto.pflueger@abscue.de,
abel.vesa@linaro.org, luca@z3ntu.xyz, geert+renesas@glider.be,
stephan.gerhold@kernkonzept.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-clk@vger.kernel.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v6 8/9] soc: qcom: cpr3: Add IPQ9574 definitions
Date: Wed, 10 Jul 2024 13:12:19 +0200 [thread overview]
Message-ID: <4c3ada32-1476-4d98-89d7-7b2ffa0f9a65@linaro.org> (raw)
In-Reply-To: <20240710061102.1323550-9-quic_varada@quicinc.com>
On 10.07.2024 8:11 AM, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> * Add thread, scaling factor, CPR descriptor defines to enable
> CPR on IPQ9574.
>
> * Skip 'acc' usage since IPQ9574 does not have acc
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
[...]
>
> /* CPRh disallows MEM-ACC access from the HLOS */
> - if (!(data->acc_desc || desc->cpr_type == CTRL_TYPE_CPRH))
> + if (!(data->acc_desc || desc->cpr_type == CTRL_TYPE_CPRH ||
> + of_device_is_compatible(dev->of_node, "qcom,ipq9574-cpr4")))
> return dev_err_probe(dev, -EINVAL, "Invalid ACC data\n");
This is something I'd also like to fold into v16.. perhaps
if (data->acc_desc && desc->cpr_type == CTRL_TYPE_CPRH)
could work instead? this way we trust the programmer that
acc_desc's presence/absence is intentional and only throw and
error if it's present with type == CPRH
Konrad
next prev parent reply other threads:[~2024-07-10 11:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 6:10 [PATCH v6 0/9] Enable CPR for IPQ9574 Varadarajan Narayanan
2024-07-10 6:10 ` [PATCH v6 1/9] soc: qcom: cpr3: Fix 'acc_desc' usage Varadarajan Narayanan
2024-07-10 11:05 ` Konrad Dybcio
2024-07-10 11:10 ` Varadarajan Narayanan
2024-07-10 6:10 ` [PATCH v6 2/9] cpufreq: qcom-nvmem: Add support for IPQ9574 Varadarajan Narayanan
2024-07-10 11:05 ` Konrad Dybcio
2024-07-10 6:10 ` [PATCH v6 3/9] dt-bindings: power: rpmpd: Add IPQ9574 power domains Varadarajan Narayanan
2024-07-10 6:10 ` [PATCH v6 4/9] dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574 Varadarajan Narayanan
2024-07-10 6:10 ` [PATCH v6 5/9] pmdomain: qcom: rpmpd: Add IPQ9574 power domains Varadarajan Narayanan
2024-07-16 12:15 ` Konrad Dybcio
2024-07-17 9:14 ` Varadarajan Narayanan
2024-07-24 4:32 ` Varadarajan Narayanan
2024-07-24 17:26 ` Dmitry Baryshkov
2024-08-05 10:32 ` Ulf Hansson
2024-08-20 6:19 ` Varadarajan Narayanan
2024-07-10 6:10 ` [PATCH v6 6/9] dt-bindings: clock: Add CPR clock defines for IPQ9574 Varadarajan Narayanan
2024-07-10 6:11 ` [PATCH v6 7/9] clk: qcom: gcc-ipq9574: Add CPR clock definition Varadarajan Narayanan
2024-07-10 6:11 ` [PATCH v6 8/9] soc: qcom: cpr3: Add IPQ9574 definitions Varadarajan Narayanan
2024-07-10 11:12 ` Konrad Dybcio [this message]
2024-07-11 4:58 ` Varadarajan Narayanan
2024-07-10 6:11 ` [PATCH v6 9/9] arm64: dts: qcom: ipq9574: Enable CPR Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c3ada32-1476-4d98-89d7-7b2ffa0f9a65@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=ilia.lin@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=otto.pflueger@abscue.de \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®