From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754600AbcIJJAo (ORCPT ); Sat, 10 Sep 2016 05:00:44 -0400 Received: from mout.web.de ([212.227.17.12]:63351 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbcIJJAm (ORCPT ); Sat, 10 Sep 2016 05:00:42 -0400 Subject: [PATCH 1/4] ATM-ZeitNet: Use kmalloc_array() in start_tx() To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> References: <0b5381e1-d725-0706-1cc0-188df6c201f2@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <4c3bc3b9-3bca-6a79-8093-1ee8d0c3ec8b@users.sourceforge.net> Date: Sat, 10 Sep 2016 11:00:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0b5381e1-d725-0706-1cc0-188df6c201f2@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:PW5p5hDACCv8k3kwfAK3Gd03UpifEsLRjHf3bqyNSd3nyw8mxy4 ApSwT8SFBBF69tlfp24WlQKshm1n96mhbVK9PPcZx9zV3D+5cD7FfuX3oC6w/Y61ix9XIOt mdLRg9CG9O+vSagNq+t+YQQpnwTO8vE4I0mOMZCPnRykIsBd0rRvCWiMEHR4NPFAEkfZPuS +2x/bSLus2bX/l89bZsUw== X-UI-Out-Filterresults: notjunk:1;V01:K0:s7BqitQi2qg=:JeceYWr5IQRdDMPHITnpNS FlKTWuZNIQFla8LlEzBjxCR26r43rfiOkAqMrwYwhMMMfcEbTDRKVZQ76h5pyCRTQxGjxZNyd ZMKrQMiTl/3hg9EM4y2PwTn3azZ/zXdLresvabZL9BHfozr0k0+4GoNHZ6sndnM8EktR2bbb8 oaGM8cBASc6FH1oip6g77D2Z1th/mN1/q3yr4ffJQkk1SfgOx11asU6eJgV7piWG6OIJ4IeMt 7CqjxExyG9jJF2AhR5f8xK7T0hKlS8c/1SHIgQjYLrbxGT+wivYlngadTGuqsa288uVayRRKZ 3bhqdZRum1kjlHxTKrMtzD67X/0SGE1siJrN9kyNkWCe8YyfqKoIoKiaRRidNVB1PPHAYmeUa 4o5lovXjureh6rBttpDg5OD9VJhN4qonU2uddNR+7lvhnClsqZv+MTAXn2+PowiMnOBGEAkBi BTUprucOjPq3abSQ69mFuNBPdHTEK5pBahmpo6PxsIwqjHpMftirDittfookhbf/WOMdN/dHa qFUiE9YLJkikC4BhAQERz/Ps/HoKMec8ZDJ3kujyGf3wR4ti9WI2F6hayLeNl28wYyuK1IXe5 meFeCeMLv/+Xn0Q8GjaOGivcqDcXpeU0QUo3v1SPu+BwmhOtpWww5ym1Y5DRWBDC2v/H7DhU7 79Bpb5vqkXdnYhFUJwzGTFB6ss7HmHzvNmLq0DJEAzNDWvUboyzxJZVzNrshiQYo2iVHZAAey rHdgDVzcnIX2Lby4R5iTdG52Esm6NaU7nRBAH30qF36SSO3mxcd9iKN7arKZqR8Mo8dqAbVHn BxvFjoj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 09:55:53 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/zatm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c index cecfb94..d378ff2 100644 --- a/drivers/atm/zatm.c +++ b/drivers/atm/zatm.c @@ -998,8 +998,9 @@ static int start_tx(struct atm_dev *dev) DPRINTK("start_tx\n"); zatm_dev = ZATM_DEV(dev); - zatm_dev->tx_map = kmalloc(sizeof(struct atm_vcc *)* - zatm_dev->chans,GFP_KERNEL); + zatm_dev->tx_map = kmalloc_array(zatm_dev->chans, + sizeof(*zatm_dev->tx_map), + GFP_KERNEL); if (!zatm_dev->tx_map) return -ENOMEM; zatm_dev->tx_bw = ATM_OC3_PCR; zatm_dev->free_shapers = (1 << NR_SHAPERS)-1; -- 2.10.0