From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB941EF0A5 for ; Wed, 2 Apr 2025 21:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743627855; cv=none; b=EEh6tk/xquT7PaIQFxFnuDSWwGjFVG5t816WHCrnPN0SvBKoriakrIpme+AJnVojfgDVOEHS3/wzEg18+iY+iQRs3kELtdeB7uo9A9+zg6W2XSmslidr7cI3UVTrADVpjLXzCeSMowlNcCKCRPVo9/GaP9Hc+3ray+wIUX3lpyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743627855; c=relaxed/simple; bh=9bl7Al8TcmucJOZ1piV9ws4Byidkq2KDSTJ0/uuMIxQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bx3ENpXSY2V9D3vZ2/SMJReE/zkvee4DJAKhIi2sOGFhB+sSbOTDoYb2NZMHAAb36amM663RZJpZCMZmoJisimvlTtkeoptrrGVL/t6bOd9qFf5Q/mrAZCMtpW7g9czvzlqHXJNtHjNb/aN3i4Xsf0Ttr0x+kgxJZygrSZArOEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=SS+3ShvU; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="SS+3ShvU" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-72a4793d4e2so167833a34.2 for ; Wed, 02 Apr 2025 14:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1743627851; x=1744232651; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EHVmZKYaU8HGt5WXf4UlaDB5Ev+RO33OxezFlT9Bya8=; b=SS+3ShvUqPMNzb+6vyxvjILN42fyLoWSpwng8YktRmx8r/JW8F7p7zZv49W/pzdSDd QYz83PaJTvypPQ16hx9Pyd5H5L6h6/eXeKAV5KkZUi2EfdlRvPRi8bRtdeDJnOF6p3Du yAiFPMS4vr9CFrx8Bnmhq6J6qTLkwLzwEK1NkN0t2ok1qwZceu9bCi+aOiMpkpc2sVfU JYZE/8kj51njSsqXSV36xkh5YcMN7ai+sLeo75V40Eb/wEbqrLP4sbD573E36eQae1av x3CxtBG1Zsr6T1ek1vvB+9mQ+JKiuR6Bz7OAZnPrUVb4482la3OnlVBY9ZdfUy9Ki+Zx AwDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743627851; x=1744232651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EHVmZKYaU8HGt5WXf4UlaDB5Ev+RO33OxezFlT9Bya8=; b=CtXiNOK0Mag6yOHMyXojOc9E8Ge4StgRmfmiY3ki6amCjPS6Br7WtNwhUeBGwAmlVu ngqBeMzmS1ftd2Qxb6KvSw/BE9dBdDuf/di6xFBP1Qid14FcafLjnbGzADNepGsRCLkS S3E4svmSkNi3aMgmEa4W5BCpF9gEKSvlc4tyGzsi7XQ81ruJxuhWPLIaaNaOMDTC1AY3 tGwwDTcYe669Fwb3Ndb30ii3Rk61XHpnOraycHZPioRJmF1wfsaaxBW/g90hGhmVurzW cpTuZHFlT6Lm9fWqm0MOr3RAjvsVno8ASdPkqz7BHPwBzsIku+fsNWu5Z/k+HBBdBton e9Yw== X-Forwarded-Encrypted: i=1; AJvYcCVdrbRnCCD4mqoyAgb32t0hEe7hVbflbx8aZN1CB3W7xz5293VQYGC9ts0Hl9Pff05WJ37XxUhUEzBFD7k=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe2u7hzYIb0faNNh2f149WNy5BFq4WR5BSR0GZgk+1JU8hDbzd nnJzK/orjiovn+5EU7N8NMVhCbPE/1S9hghuqQ6nY4DPSd0X5tt3hwqTXPaV5wY= X-Gm-Gg: ASbGncsWYmHGoq2tj58LW2jHHxVqpLy3H2fqwTOlwQuSOJGmmdSSQfeANbAysjRjqnG gxZ1qN8lNLJDdRGz97nVXZFcOz3nPd+ZAJ6Dfn4LkIG7eDiyAvg6nYgNyR5hX2njTiajXNVx8sN 7LO54cNzP71UGVxaO8jecq5egpqwilCA0Nqny8I9ETB/7wFfWtrG9rNC7ohT3K391YH29QmKXsi 3AQNs+iDOguKjWt3/mab/Zldnp0Z34KMCvJZ6rtt9Cab26bkJoAWeHNkU22Xl/c/Co0NL3AhEQv +9oL4cCehTyfpxtMXNXwCZJuSELlitKsQe7TZcYMF6nJOwUKbnEGAj3XX7pBdHGVVB4RgXqgTZu MHAnt2Q== X-Google-Smtp-Source: AGHT+IEm6MEi4+/aDKfkND/DEKKXrfRXQ/0xgqv8Xqad87ZQdhhW5rDXRo5jjzJ8TnjkHIGd06rHlA== X-Received: by 2002:a05:6830:61c5:b0:72c:320b:fc8c with SMTP id 46e09a7af769-72dae738ce3mr6840871a34.21.1743627851291; Wed, 02 Apr 2025 14:04:11 -0700 (PDT) Received: from [192.168.0.113] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c58285654sm2386290a34.57.2025.04.02.14.04.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Apr 2025 14:04:10 -0700 (PDT) Message-ID: <4c3e0d23-2582-4acf-8e90-542c8f8c385f@baylibre.com> Date: Wed, 2 Apr 2025 16:04:09 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] iio: adc: ti-adc128s052: Simplify using be16_to_cpu() To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nuno Sa , Javier Carrasco , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/2/25 1:09 AM, Matti Vaittinen wrote: > The register data is 12-bit big-endian data. Use be16_to_cpu() to do > the conversion, and simple bitwise AND for masking to make it more > obvious. > > Signed-off-by: Matti Vaittinen > --- > Revision history: > v1 => v2: > - Fix commit msg to reflect the fact there was no bug > - Drop Fixes tag > - Use union for rx / tx buffer to avoid casting > - Keep the shared message protected by the mutex > --- > drivers/iio/adc/ti-adc128s052.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c > index a456ea78462f..3e69a5fce010 100644 > --- a/drivers/iio/adc/ti-adc128s052.c > +++ b/drivers/iio/adc/ti-adc128s052.c > @@ -28,32 +28,34 @@ struct adc128 { > struct regulator *reg; > struct mutex lock; > > - u8 buffer[2] __aligned(IIO_DMA_MINALIGN); > + union { > + __be16 rx_buffer; > + u8 tx_buffer[2]; > + } __aligned(IIO_DMA_MINALIGN); > }; > > static int adc128_adc_conversion(struct adc128 *adc, u8 channel) > { > int ret; > + char *msg = &adc->tx_buffer[0]; > > mutex_lock(&adc->lock); > > - adc->buffer[0] = channel << 3; > - adc->buffer[1] = 0; > + msg[0] = channel << 3; > + msg[1] = 0; > > - ret = spi_write(adc->spi, &adc->buffer, 2); > + ret = spi_write(adc->spi, msg, sizeof(adc->tx_buffer)); > if (ret < 0) { > mutex_unlock(&adc->lock); > return ret; > } > > - ret = spi_read(adc->spi, &adc->buffer, 2); > - > + ret = spi_read(adc->spi, &adc->rx_buffer, 2); > mutex_unlock(&adc->lock); > - > if (ret < 0) > return ret; > > - return ((adc->buffer[0] << 8 | adc->buffer[1]) & 0xFFF); > + return be16_to_cpu(adc->rx_buffer) & 0xFFF; The cast isn't exactly beautiful, but this would save a lot of lines of diff and a few lines of code by avoiding the need for the union and the local msg variable. return be16_to_cpup((__be16 *)adc->buffer) & 0xFFF; > } > > static int adc128_read_raw(struct iio_dev *indio_dev,