From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793626959; b=teFX86Pv9cnvoy9h8Hm2sVKl36LP5fWfmBuOjdr5qstSYdkMpyzHLouWWtrn4mMrMQH3 v6u7F4hRBKVz6PDWzqCygnfPEbvzQ592LKPGnT640o3JOvfyznIsY51h5ADn1WTIwmsPG Abeur61kRofQxCAByV3x/xXukSQX60ulKaSCdsk1eLgOqTQRsHFqBW95K0x62Ds8qAlU1 NwYAteb/UldJeWRmvz0HNvL8A6exjJpbkPmL3DFXfOOJXJbqX2B/f5CUgz3fLcwe4EFQl +4rdALFHT9ZhDyAaGvx49+pNfCr/VTBJYtqbQCWthepPKQ5voNx+OKAjUI8z8rTaMeg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793626959; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=n8krnApcdxXIbrhooq5aa+FZznz/OJP/sKAy+beq8Y4=; b=0GIhKPe5/SJxLaakNZUc5kfN8kg8SAtkrQode6shCUQiVhavgycsdFZTlOkN/1PHMdSe YJA/sBcOev0yiu79+ZSXAr2XoBPG19YfgmHNkEqiImSqEOJ4sSorWJ5O5PbMvOg7H02Sb YpCFj5x92mzb3dqRt2WS6/j4c+gi3WI/vFhmAr6sNOaCVWa+CqU+L6afeQV7V0AsYOibz N6Mw+sU2kJqCz0gbobD0SQByGIP4hc3+iLmyWhtD3jgKLoIXUIJH8s/wcKFgAMIaZyC18 /FM4TXoV7yJoVZZ/dl3/88MPLACiZ5YN7IxEPP3Dz6mdMo9cEG4rficwWgZdlkRXNzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nXbZutSQ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16A26606A326 for ; Mon, 2 Nov 2026 13:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nXbZutSQ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AE861F00A16; Mon, 2 Nov 2026 13:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793626958; bh=n8krnApcdxXIbrhooq5aa+FZznz/OJP/sKAy+beq8Y4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=nXbZutSQBhI9djuwabEGr2dBj61HIzmQw6r2u9j2T6oIK5fxQO7FkBt1KcFQ9auRS Iv+HpKbVbOoN3l0zcRt+rtQo/xd3o0bU9eYY+zS0EejM6hGnNqLjfJ6WdRCncq/lGq 4Of73MdSAm06le2GfQMsaRdi3rHTpYT5bx8uES8VwqFuNAAxU+Qdc87Q6dt8jh5Pgm /S0rJnRLILezvtuK4WKfZ/sLlIIuGDQNsROudVBWfzwkcM7KDGTSOCan2go6H6AYYH A/jRIaGoafhfLLDusZJ9d4yUf0GUwL305IYPc6ihcK8/XcFMq9Jgmfu2wybDixTmPm GFV/5IpLsIxlQ== Message-ID: <4c473b0f-6b7a-4436-8aae-a14118de555d@kernel.org> Date: Mon, 2 Nov 2026 14:42:34 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/11] soc: mediatek: dram-ecc: add error counters and the address lists To: "santino.wang" , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, light.chen@mediatek.com, Fred-WY.Chen@mediatek.com, arnab.layek@mediatek.com References: <20261102092334.138759-1-santino.wang@mediatek.com> <20261102092334.138759-6-santino.wang@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261102092334.138759-6-santino.wang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/11/2026 10:23, santino.wang wrote: > + > +static ssize_t by_ce_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) > +{ > + return sysfs_emit(buf, "%llu\n", mtk_dram_ecc_get_retired_by_ce()); > +} > + > +static ssize_t by_uce_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) > +{ > + return sysfs_emit(buf, "%llu\n", mtk_dram_ecc_get_retired_by_uce()); > +} > + > +static struct kobj_attribute retired_by_ce_attr = __ATTR_RO(by_ce); > +static struct kobj_attribute retired_by_uce_attr = __ATTR_RO(by_uce); > + > +static struct attribute *retired_attrs[] = { > + &retired_by_ce_attr.attr, > + &retired_by_uce_attr.attr, > + NULL, > +}; > + > +static const struct attribute_group retired_group = { > + .attrs = retired_attrs, > +}; > + > +int mtk_dram_ecc_counters_init(struct kobject *parent) > +{ > + int ret; > + > + counters_kobj = kobject_create_and_add("counters", parent); > + if (!counters_kobj) > + return -ENOMEM; > + > + ret = sysfs_create_group(counters_kobj, &group); > + if (ret) { > + kobject_put(counters_kobj); > + return ret; > + } > + Sorry, but no. You do not get your own interface, especially undocumented one. Use existing subsystems. Also, drivers/soc/ cannot expose interface to user space. Best regards, Krzysztof