From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 371DB374C3 for ; Wed, 28 Feb 2024 09:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709113899; cv=none; b=V8JOG0MPTp3M0w0mgveZevvbHjR9RQVHNglsOQVQy2dPujpwseuGrlR1hZlbM2mZOPHR0nSuD//OJpmv2kdF2H9qIBOjVQAxVjaywDgGx3tr2Efps56O0rCvep6SCjqHkgQRFjkOlBZkOm16ztl8LJVpjbzTXOH3VMrrKXkCBCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709113899; c=relaxed/simple; bh=G22s0wkjpFNZosDALoAG8Ufc1M9DBCSDGtlIAeBbjoc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DWwZUfwgPSDKn/lQOKTgJ3OWDseC3lUYkBJrcoz/or+C3p8OD+k0s+S8GKs9a32ESxW1OkuRKUQVdfs6T82f2mGYN2HPs479JALNqpaksaxhHFHh2mgpqjojT0PYjWGLEQkGrFZoT4xnFX+nFm4512Bli2ub+8+ifDhU4NMS6CQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=5Kl+5hJu; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="5Kl+5hJu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709113896; bh=G22s0wkjpFNZosDALoAG8Ufc1M9DBCSDGtlIAeBbjoc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=5Kl+5hJufOEgvXzaCb1w2RqImqwe5YOsnx7tri7w5EMx3e6ocSZI7w6/me2KaH+aj mI0XZaEqLMVmEwkIzCs7OuUnFcXX1hyz8LIA/GHEepkIz1Mz0/iHKIceFzcZbwiL8n OjaUcWOejQbd1b+uxoTuNhtDLo14ts7xH/eCa3EMJ7z6AmqOAu4CJ+5kC56C2sXxDq C/7o9UCqy/Or1uka7QFaCGvDwoKuWA12XTk7R5V00ghlUDmEXkhbvQhwv6W1Npvkma keuTjoJdYLiSBwVb6uR3jlNXP0rdnl9oyJy2ZWFLxYqLtMR3c9ZqRz97eMS7GhuXxL csPBL71Kryc9w== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 4279F3780029; Wed, 28 Feb 2024 09:51:35 +0000 (UTC) Message-ID: <4c57d1f6-3114-4789-94d4-03e78852cbef@collabora.com> Date: Wed, 28 Feb 2024 10:51:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/bridge: anx7625: Don't log an error when DSI host can't be found Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Robert Foss Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31884@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31884@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 26/02/24 22:20, Nícolas F. R. A. Prado ha scritto: > Given that failing to find a DSI host causes the driver to defer probe, > make use of dev_err_probe() to log the reason. This makes the defer > probe reason available and avoids alerting userspace about something > that is not necessarily an error. > > Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found") > Signed-off-by: Nícolas F. R. A. Prado > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 29d91493b101..4ee5614a2623 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2076,10 +2076,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx) > }; > > host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); > - if (!host) { > - DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); > - return -EPROBE_DEFER; > - } > + if (!host) > + return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n"); Agreed, but while at it: 1. This is not the only driver doing this, so you might as well go fix all of them in a series (toshiba tcxxxx, lontium, chipone.... check them, the error message is exactly the same even, that'd take 3 seconds); 2. I've just noticed that, in this driver, of_node_put() is never called for the `mipi_host_node`, so the reference is never dropped... but that can come later and not necessarily in the eventual series that fixes the err message strategy. In the meanwhile, for this commit Reviewed-by: AngeloGioacchino Del Regno > > dsi = devm_mipi_dsi_device_register_full(dev, host, &info); > if (IS_ERR(dsi)) { > > --- > base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29 > change-id: 20240226-anx7625-defer-log-no-dsi-host-c3f9ccbcb287 > > Best regards,