From: Roel Van Nyen <roel.vannyen@gmail.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Forest Bond <forest@alittletooquiet.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6656: Remove the ULONG_PTR and DWORD_PTR defines from ttype.h
Date: Thu, 5 Aug 2010 18:23:21 +0200 [thread overview]
Message-ID: <4c5ae57d.d37b0e0a.1ef9.19ba@mx.google.com> (raw)
In-Reply-To: <1278974997-27141-1-git-send-email-roel.vannyen@gmail.com>
On Tue, Jul 13, 2010 at 12:49:57AM +0200, Roel Van Nyen wrote:
> Remove the ULONG and DWORD PTR defines from ttype.h
>
> Signed-of-by: Roel Van Nyen <roel.vannyen@gmail.com>
> ---
> drivers/staging/vt6656/bssdb.c | 8 ++++----
> drivers/staging/vt6656/ttype.h | 3 ---
> 2 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c
> index 830dd23..0b8584b 100644
> --- a/drivers/staging/vt6656/bssdb.c
> +++ b/drivers/staging/vt6656/bssdb.c
> @@ -469,7 +469,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext,
> unsigned int uLen = pRSNWPA->len + 2;
>
> if (uLen <= (uIELength -
> - (unsigned int) (ULONG_PTR) ((PBYTE) pRSNWPA - pbyIEs))) {
> + (unsigned int) (unsigned long) ((PBYTE) pRSNWPA - pbyIEs))) {
> pBSSList->wWPALen = uLen;
> memcpy(pBSSList->byWPAIE, pRSNWPA, uLen);
> WPA_ParseRSN(pBSSList, pRSNWPA);
> @@ -482,7 +482,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext,
> unsigned int uLen = pRSN->len + 2;
>
> if (uLen <= (uIELength -
> - (unsigned int) (ULONG_PTR) ((PBYTE) pRSN - pbyIEs))) {
> + (unsigned int) (unsigned long) ((PBYTE) pRSN - pbyIEs))) {
> pBSSList->wRSNLen = uLen;
> memcpy(pBSSList->byRSNIE, pRSN, uLen);
> WPA2vParseRSN(pBSSList, pRSN);
> @@ -674,7 +674,7 @@ BOOL BSSbUpdateToBSSList(void *hDeviceContext,
> if (pRSNWPA != NULL) {
> unsigned int uLen = pRSNWPA->len + 2;
> if (uLen <= (uIELength -
> - (unsigned int) (ULONG_PTR) ((PBYTE) pRSNWPA - pbyIEs))) {
> + (unsigned int) (unsigned long) ((PBYTE) pRSNWPA - pbyIEs))) {
> pBSSList->wWPALen = uLen;
> memcpy(pBSSList->byWPAIE, pRSNWPA, uLen);
> WPA_ParseRSN(pBSSList, pRSNWPA);
> @@ -686,7 +686,7 @@ BOOL BSSbUpdateToBSSList(void *hDeviceContext,
> if (pRSN != NULL) {
> unsigned int uLen = pRSN->len + 2;
> if (uLen <= (uIELength -
> - (unsigned int) (ULONG_PTR) ((PBYTE) pRSN - pbyIEs))) {
> + (unsigned int) (unsigned long) ((PBYTE) pRSN - pbyIEs))) {
> pBSSList->wRSNLen = uLen;
> memcpy(pBSSList->byRSNIE, pRSN, uLen);
> WPA2vParseRSN(pBSSList, pRSN);
> diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h
> index 3425773..42091c4 100644
> --- a/drivers/staging/vt6656/ttype.h
> +++ b/drivers/staging/vt6656/ttype.h
> @@ -83,9 +83,6 @@ typedef UQuadWord QWORD; // 64-bit
>
> /****** Common pointer types ***********************************************/
>
> -typedef unsigned long ULONG_PTR; // 32-bit
> -typedef unsigned long DWORD_PTR; // 32-bit
> -
> // boolean pointer
> typedef unsigned int * PUINT;
>
> --
> 1.7.0.4
>
Hi Greg,
I have re-done my patch and this time without any checkpatch.pl errors.
Remove DWORD_PTR and ULONG_PTR from ttype.h
Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com>
---
drivers/staging/vt6656/bssdb.c | 8 ++++----
drivers/staging/vt6656/ttype.h | 4 ----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c
index a9f68bd..024dff3 100644
--- a/drivers/staging/vt6656/bssdb.c
+++ b/drivers/staging/vt6656/bssdb.c
@@ -466,7 +466,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext,
unsigned int uLen = pRSNWPA->len + 2;
if (uLen <= (uIELength -
- (unsigned int) (ULONG_PTR) ((PBYTE) pRSNWPA - pbyIEs))) {
+ (unsigned int) (unsigned long) ((PBYTE) pRSNWPA - pbyIEs))) {
pBSSList->wWPALen = uLen;
memcpy(pBSSList->byWPAIE, pRSNWPA, uLen);
WPA_ParseRSN(pBSSList, pRSNWPA);
@@ -479,7 +479,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext,
unsigned int uLen = pRSN->len + 2;
if (uLen <= (uIELength -
- (unsigned int) (ULONG_PTR) ((PBYTE) pRSN - pbyIEs))) {
+ (unsigned int) (unsigned long) ((PBYTE) pRSN - pbyIEs))) {
pBSSList->wRSNLen = uLen;
memcpy(pBSSList->byRSNIE, pRSN, uLen);
WPA2vParseRSN(pBSSList, pRSN);
@@ -671,7 +671,7 @@ BOOL BSSbUpdateToBSSList(void *hDeviceContext,
if (pRSNWPA != NULL) {
unsigned int uLen = pRSNWPA->len + 2;
if (uLen <= (uIELength -
- (unsigned int) (ULONG_PTR) ((PBYTE) pRSNWPA - pbyIEs))) {
+ (unsigned int) (unsigned long) ((PBYTE) pRSNWPA - pbyIEs))) {
pBSSList->wWPALen = uLen;
memcpy(pBSSList->byWPAIE, pRSNWPA, uLen);
WPA_ParseRSN(pBSSList, pRSNWPA);
@@ -683,7 +683,7 @@ BOOL BSSbUpdateToBSSList(void *hDeviceContext,
if (pRSN != NULL) {
unsigned int uLen = pRSN->len + 2;
if (uLen <= (uIELength -
- (unsigned int) (ULONG_PTR) ((PBYTE) pRSN - pbyIEs))) {
+ (unsigned int) (unsigned long) ((PBYTE) pRSN - pbyIEs))) {
pBSSList->wRSNLen = uLen;
memcpy(pBSSList->byRSNIE, pRSN, uLen);
WPA2vParseRSN(pBSSList, pRSN);
diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h
index 8e9450e..e8ed3ff 100644
--- a/drivers/staging/vt6656/ttype.h
+++ b/drivers/staging/vt6656/ttype.h
@@ -59,10 +59,6 @@ typedef union tagUQuadWord {
typedef UQuadWord QWORD; // 64-bit
/****** Common pointer types ***********************************************/
-
-typedef unsigned long ULONG_PTR; // 32-bit
-typedef unsigned long DWORD_PTR; // 32-bit
-
// boolean pointer
typedef BYTE * PBYTE;
--
1.7.0.4
next prev parent reply other threads:[~2010-08-05 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 22:49 Roel Van Nyen
2010-08-05 16:23 ` Roel Van Nyen [this message]
2010-08-19 10:18 ` Roel Van Nyen
2010-08-19 15:13 ` Greg KH
2010-08-31 18:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c5ae57d.d37b0e0a.1ef9.19ba@mx.google.com \
--to=roel.vannyen@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome