From: Khang D Nguyen <khangng@amperemail.onmicrosoft.com>
To: Jakub Kicinski <kuba@kernel.org>,
Khang Nguyen <khangng@os.amperecomputing.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ampere-linux-kernel@lists.amperecomputing.com,
Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Khanh Pham <khpham@amperecomputing.com>,
Phong Vo <pvo@amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Chanh Nguyen <chanh@os.amperecomputing.com>,
Thu Nguyen <thu@os.amperecomputing.com>,
Hieu Le <hieul@amperecomputing.com>,
openbmc@lists.ozlabs.org, patches@amperecomputing.com
Subject: Re: [PATCH net-next] net: mctp: Expose transport binding identifier via IFLA attribute
Date: Fri, 8 Nov 2024 12:47:36 +0700 [thread overview]
Message-ID: <4c5b08d2-e81e-4492-a1a7-7e1e6445ddc4@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20241107204157.683bca11@kernel.org>
On 08/11/2024 11:41, Jakub Kicinski wrote:
> On Tue, 5 Nov 2024 14:19:15 +0700 Khang Nguyen wrote:
>> However, we currently have no means to get this information from MCTP
>> links.
>
> I'm not opposed to the netlink attribute, but to be clear this info
> is indirectly available in sysfs, right? We link the netdev to
> the parent device so the type of /sys/class/net/$your_ifc/device
> should reveal what the transport is?
Good point, I did not think about using the parent device, that would be
a good workaround for the currently supported interfaces.
For the long term, we should still need the attribute. For example,
vendor-defined transports need their 0xFF code, which cannot be derived
anywhere. Or binding implementations that have parent SoC platform
devices from the device tree, which do not always have a clear type
shown in the sysfs...
(The MCTP-over-serial binding also does not have a parent device
currently, but I believe we can fix that if necessary)
next prev parent reply other threads:[~2024-11-08 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 7:19 Khang Nguyen
2024-11-07 3:05 ` Matt Johnston
2024-11-08 4:41 ` Jakub Kicinski
2024-11-08 5:47 ` Khang D Nguyen [this message]
2024-11-08 8:10 ` Jeremy Kerr
2024-11-09 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c5b08d2-e81e-4492-a1a7-7e1e6445ddc4@amperemail.onmicrosoft.com \
--to=khangng@amperemail.onmicrosoft.com \
--cc=ampere-linux-kernel@lists.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=chanh@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hieul@amperecomputing.com \
--cc=horms@kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=khangng@os.amperecomputing.com \
--cc=khpham@amperecomputing.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=pvo@amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
--cc=thu@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®