From: David Laight <David.Laight@ACULAB.COM>
To: 'Chen Zhongjin' <chenzhongjin@huawei.com>,
Dave Hansen <dave.hansen@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"akpm@linux-foudation.org" <akpm@linux-foudation.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"wuchi.zero@gmail.com" <wuchi.zero@gmail.com>
Subject: RE: [PATCH 1/2] x86: profiling: remove lock functions hack for !FRAME_POINTER
Date: Wed, 12 Apr 2023 10:01:18 +0000 [thread overview]
Message-ID: <4c601a93e55341fc8cff766af43cb5e6@AcuMS.aculab.com> (raw)
In-Reply-To: <1ceb1769-f01b-c417-e912-4ee1149dd0cb@huawei.com>
From: Chen Zhongjin
> Sent: 12 April 2023 08:02
...
> > 4. !CONFIG_FRAME_POINTER is probably even more rare today than it was in
> > 2006
>
> No. !CONFIG_FRAME_POINTER is more common today because of UNWINDER_ORC.
> And that is why the bug is triggered more frequently.
CONFIG_FRAME_POINTER is pretty much required (on x86-64)
for the user copy checks that are enabled in distro kernels.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-04-12 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 2:22 [PATCH 0/2] Fix two bugs for profile Chen Zhongjin
2023-04-10 2:22 ` [PATCH 1/2] x86: profiling: remove lock functions hack for !FRAME_POINTER Chen Zhongjin
2023-04-10 19:34 ` Dave Hansen
2023-04-12 7:01 ` Chen Zhongjin
2023-04-12 10:01 ` David Laight [this message]
2023-04-13 7:53 ` Chen Zhongjin
2023-04-19 16:17 ` Josh Poimboeuf
2023-04-19 15:43 ` Josh Poimboeuf
2023-04-10 2:22 ` [PATCH 2/2] profiling: Check prof_buffer in profile_tick() Chen Zhongjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c601a93e55341fc8cff766af43cb5e6@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foudation.org \
--cc=ben-linux@fluff.org \
--cc=bp@alien8.de \
--cc=chenzhongjin@huawei.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wuchi.zero@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®