From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8236B439F82 for ; Thu, 23 Jul 2026 10:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784802990; cv=none; b=OQBXKcNum24JTb+J2ngBDD22j11dsFvTkhlyVre4QOIoXI7O1boT2rzDX+BZ1B/FbZHBtPOKBBX1zmkkqDrWGNjpcIODLBi79y8/QOnSOIJCz8tho4a++1pM+qFUJZ7W4QwV0kM0gpPssRBrqh3a7KkF5rU1ySPeqP9jn2Zaogs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784802990; c=relaxed/simple; bh=y5qoMU8Plv/qJ+DGaSaEWiuWyV2WGbtvMLTUzlU5Rko=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rIHLkAaITenuXWbLANNjKyI8xh0x7mh3/caFTd7aspb9KavV2guG+44A7d6aiBAPWuZd5I+Ct1+8eMa3+tXkXARAmTCoZHp+xEToGNFRy4HOKMbMNIov3+WjS4Qdpk8HGa0twekfVnoiwWHPWFYZ8zSvhsgGKWB/zCQoVmi9prQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eKOOfrW6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fdDC4P/v; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eKOOfrW6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fdDC4P/v" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N8qbWd3606139 for ; Thu, 23 Jul 2026 10:36:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8bXNiDzJKS+O8RtIxfJvk28Q/736rLVrJ27qCekjzr8=; b=eKOOfrW6UH7mWuL7 4nnbYDR3A8MgWCNOVGTu61028VIhm9Z8zCuCBpMN8IvV5t2BIMpOlDinZLeQCNiD Yy3CFtNtcvSslBoiBmTak9GCRiLeoPC9XuQXux9n9zjE7xfaaFcVqiq+Rivwyte4 WGC90U/JYJjx6pJgXJSNYqlcUGdZEVx2bM9b/wCgwuedqlLCyJ09LeERhf8cDyGV 3YJE8Xbs4g53HNI2UNglrc/vjlNihoZe7+sK2fbhHhMkSL3k0dA0zg6UMjlDx8Em K9ltjDIkAvkiX32vHIeS6zAhriBSZd1QWZTyDd6OtzN24NfkmkwjGYuYlErXeTMt f+TWGw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fke7qgu6a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 10:36:24 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cca5e0a0c9so11210495ad.1 for ; Thu, 23 Jul 2026 03:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784802984; x=1785407784; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8bXNiDzJKS+O8RtIxfJvk28Q/736rLVrJ27qCekjzr8=; b=fdDC4P/vxiSXYrucWJMuLbqtcdEmk1R6CDMbIdMGTdIKzw+gyqJcmAT9am0ub5eNK7 tcXE6aWj97n74ioUDTaB33ck4DIjUUk6JRvwZlgN2WHjZjtaMsGqpf8KEP5hEDjlfePJ Vk7P18WREQh1lyJYO8DRNGNgo/iQZuLqzdlpi5lN4IVtfy429XUjy/OOEDcPqKrDUV5s IBpM2aX6cN0DGQt0mLDIfZFsA/LyuQ4vrI4Bl0RR5/wbAPbIhaHj4sKTQ04sFUBPeFX+ aQf+bsFRU9dBtKFTr1NSHzko/cc+BajOQF6YOJVqAuAOu54KfggsKa5tOGV1obpbKjKI ZJug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784802984; x=1785407784; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8bXNiDzJKS+O8RtIxfJvk28Q/736rLVrJ27qCekjzr8=; b=sLPTvX3boZ4z6356yu0Sf5/aaAnlxR7MD9mTZ55rkeE359Vg0v3FpwcQWH0pYgBMJ7 VJ9kf6NqCWXegePmSS4ytZgGaPhYUgBDU+UZFss+yT7LzvhdCv+j7Wm8ee7HyCk15yAr 9AfHRaG0L582j6MwNJBVlZU79HSCbEFo7jfeYx1fY99xHeu1EBgfdrhuRNeGb/MIi0Ns h2+/mIMfclwTjBCwChpBdiOHfiHA0autG5RjK+Z3p+a94da83CXoi+LlO5jNXEOl22CN QaADrFhIzUHL7N0yAR5luho1DJ6AL0P6IvDYP12stE92lN1Pjla4cJTQdwuTChHS383Z vYuA== X-Forwarded-Encrypted: i=1; AHgh+RovDOPtu5uBj43DTj0D4HBk9qOtCoJ5vbsgXxrqs+t9toLW1kE7zbpxFlL117YL+Y2OegjC4fwMrtFsppM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkq2WccepjTmaZCubyvpNMtL2ahriLK1YbiLNsNdh1jFoLYwkU httFhndgztA7x4v3+gZICi4im7G9bpaBxemV1KWKpaVFtypCpkQ6jL8BY5Ok16LKjiMhyLXi8h9 YQ/1LmimDStx7PPJy57omhWxjoBHiniB6S5KR5dikaqUgMxkuoBJClJXRlL0nE3fFmu4= X-Gm-Gg: AR+sD12Rb2k6/w75dCbleM7S/Q0cHP5LaOEjWFZgERnrJooJDY3PK76xWQjtRLMVttQ hgZvetX4m18o4MSeIcCx+jrnccdn/II3RNbii/UyYqw4/ULnd5A5eiynuMvZ0BbO1KSZavut2eJ 4MCSKxmy5zXTWDIwHG93/2GG0mp82uEDa12S8BmgVzzxXTT123Xk4gH6lLelmb6UqsOQ82td+2N TVXPzT7WUT0Nw3YbMSQSmgE70vqLNsTozP7QNc75ZuBAqxzuUKPRoha8B1yNnKH6gC71CgfKGsR 2/g6S+rMknaRPjvagiigHamMMMMTQx0BJwPv0+3oc5o9bJj+JyLnfuWD5ro1r3o9+meJKEssMun XhBE0HOpLNBrybAja3QXsSTWj9r0= X-Received: by 2002:a17:903:1104:b0:2ca:d172:7228 with SMTP id d9443c01a7336-2cfa6b7d4b5mr32263035ad.11.1784802983550; Thu, 23 Jul 2026 03:36:23 -0700 (PDT) X-Received: by 2002:a17:903:1104:b0:2ca:d172:7228 with SMTP id d9443c01a7336-2cfa6b7d4b5mr32262755ad.11.1784802983091; Thu, 23 Jul 2026 03:36:23 -0700 (PDT) Received: from [10.218.25.31] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8efa2f83sm31382035ad.1.2026.07.23.03.36.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 03:36:22 -0700 (PDT) Message-ID: <4c671695-4266-47e6-acb5-04cf4f690d6c@oss.qualcomm.com> Date: Thu, 23 Jul 2026 16:06:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] media: iris: force stage 1 work mode for CBR RC on encoder To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20260721-iris_multi_slice-v3-0-adc61a687e7e@oss.qualcomm.com> <20260721-iris_multi_slice-v3-1-adc61a687e7e@oss.qualcomm.com> <2pksblzjw3juu4dvi2vzvyeyawbka77f5lpc3e4t5cjghowujp@rdqzk5vwnobe> Content-Language: en-US From: Sachin Kumar Garg In-Reply-To: <2pksblzjw3juu4dvi2vzvyeyawbka77f5lpc3e4t5cjghowujp@rdqzk5vwnobe> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEwNCBTYWx0ZWRfX9J0cG/H91r1y SDuHrgCIMC410PCL3k/w4Q371FrKLDy9NUIaYhObkky6j7h5sAGa1/cKdDDgiII6UVZ9mAXYTf3 I/tNHQyNfgYnYBcQUsiI+wV1Kbk94JU= X-Authority-Analysis: v=2.4 cv=aYxRWxot c=1 sm=1 tr=0 ts=6a61eea8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=pKpYRV-URZkG9pN1C6IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: h_XAj8gK7mhVc6EVIh2YR0Z8NmxmENEd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEwNCBTYWx0ZWRfXyhwkzDzIciCa eWhQzS1ZdMbQvTNYqgCkY+Y/QstGqiIvcIj45E/jjokbh0uqYqd+pi6Xxxn6DvUHfxIjfRyS0Yg dRI04rTWJO9ZJO4hCf+bTlrYppIxPItm6XltI0+XU7xgMj0S2SiOUGW4qTBuS7d7HTH9db/oKln PWH1BAQdH/BFgUrO5q2Euhwd0ET/3qR33wPHKNmXjfrp9EL3mJear5QIk8Xxo0hri3BB8qVUYAS IyV2nVMoYeYMjfXs+PntGIY5WcR4GktbiS1Ez/Ye+xJAuCeJ3xyazSPfd3NBJdcSXJVjCf8918Q oKEo3Y52mALk9D4T7IfrTgDyeD0rEGGlj2+D7bRW33NJdpv3E8+QuEYgJjGhebhrqPZ80xRSw8Y 6F22pG7r1+J5D0ztHXNXZv/o3M/OYZbHDYcU3axMpwNws26KHNSG9N2PVY8fTZdtG291lkGtckf G4ew9VnboJVh6wxqCnw== X-Proofpoint-ORIG-GUID: h_XAj8gK7mhVc6EVIh2YR0Z8NmxmENEd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230104 On 7/22/2026 3:17 AM, Dmitry Baryshkov wrote: > On Tue, Jul 21, 2026 at 03:23:32PM +0530, Sachin Kumar Garg wrote: >> iris_set_stage() currently always picks STAGE_2 for encoder sessions. >> CBR rate control requires stage 1 operation, so force STAGE_1 when >> BITRATE_MODE is set to CBR. >> >> The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type >> since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type, >> so iris_set_properties() would still see the previous hfi_rc_type >> when iris_set_stage() runs during initial config >> >> Reviewed-by: Vishnu Reddy >> Signed-off-by: Sachin Kumar Garg >> --- >> drivers/media/platform/qcom/iris/iris_ctrls.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c >> index 10e33b8a73f6..d7cbf6c3614a 100644 >> --- a/drivers/media/platform/qcom/iris/iris_ctrls.c >> +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c >> @@ -519,8 +519,13 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id >> if (inst->domain == DECODER) { >> if (iris_res_is_less_than(width, height, 1280, 720)) >> work_mode = STAGE_1; >> + } else if (inst->domain == ENCODER) { >> + if (inst->fw_caps[BITRATE_MODE].value == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR) >> + work_mode = STAGE_1; >> } >> >> + inst->fw_caps[cap_id].value = work_mode; > > Separate commit, Fixes tag. > Thanks, Dmitry. Agreed — this is fixed in v4: split into a separate patch ("cache work mode after computing it in iris_set_stage") with a fixes tag. >> + >> return hfi_ops->session_set_property(inst, hfi_id, >> HFI_HOST_FLAGS_NONE, >> iris_get_port_info(inst, cap_id), >> >> -- >> 2.34.1 >> >