From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC96817BA6 for ; Tue, 5 Aug 2025 13:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754401674; cv=none; b=s86mgJ48yv1cN30uGvDDMbiatfo33CFiN4bAwWJA9tzPbRIWEm6ZgHYWnMiiOwCyhOHcGwwWfvsSDWnLMYBoLDXmS6cSyo6bVOuGuEZLl9cPqCauPeogEqql4ecg2dCoWpqB417x76tY2oWW0SBzapnxa4T3kJax7nIblv54GQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754401674; c=relaxed/simple; bh=fVs0QLegblmuEyu09CFHJFY68Aw4hYw45jDhfodxUFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OSIcJTrYeS4CCYp44PPHtyf18H4D+Hi0unxmScWeiyg1d57NXqy7takvp2okoBu0VKyavWQn8SIhQL33dabNnJsuXsprG4vkuvhh+7WJAaZuv1HnjO66FA2g35JYGR/VjAyVUHXR6B6Lp6uUxFsjCN+YJfjAQmF947S7xcEFLMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IGu3b92R; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IGu3b92R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754401671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JCZPG4PRFkWmStclsKNVUS0P5cudUlD8q2j0fKBlVN0=; b=IGu3b92RXcf9CTShd89BMt0WJgH4LXYJLasGCroPTuf1KnxINw4180lmovBqn4Im4rZEcm GDmiJoAfSiP602ZTiO2xI+p9ZecSpUj52n5E8A5gqX4E3tqw51P5Smys+tMuxlQt1xY6DC 5rFA2O0PsiWg+1Fcf9ohc8OBNC9Pih8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-Kw0DgKR5Mu-LOyOXJOHbQw-1; Tue, 05 Aug 2025 09:47:50 -0400 X-MC-Unique: Kw0DgKR5Mu-LOyOXJOHbQw-1 X-Mimecast-MFC-AGG-ID: Kw0DgKR5Mu-LOyOXJOHbQw_1754401669 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3b7889c8d2bso2359544f8f.3 for ; Tue, 05 Aug 2025 06:47:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754401669; x=1755006469; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JCZPG4PRFkWmStclsKNVUS0P5cudUlD8q2j0fKBlVN0=; b=S1iHkq4K4K4Nge8HSz/wfxdviDyBMSoWhYNn2r88okzkrCPZiBXalaJ4lRDuEHrpOO EuquI/7PJqP8mfZ9cEcynHuKTxOA0AszjPMjhAJTQ1YwV1MkqCtiTu6Sq5bfngNGuBNV 2F1EwNJHWfn4f2gePnnt4Edpp4XUdRhONtUnPxkpZcACoRpBcJQe+XWLjRN735/asisR +6d43yTLUnewfoRIRz5iIAMBKdD1sYvvmsMly0Fnifc+b7qB4rTQ1FVLHJ99zgMPmLNY Df7UvV7XrrYoOWyyjxlVBmGmjNvudbXEhLfUy+nrQiNRgF58xyH9AnYgk8GjSK6sysu0 GG6w== X-Forwarded-Encrypted: i=1; AJvYcCXfu7asG90+sCKAEBUO+V/IfgZUEdsK29+CsTQ1YRpNsI2VpC0gc9lrvVwDeSPqonJDd2WJTb5p2y9yDXg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd0kmV1YGMdy50an/1mmBB0J0i70jPNiw8BDAkpAwaxSTyLCwA ZkeQoUXUJsqzzoidIWHS/ct44VerAfLo5kdYCE8alG+2/Lf9acRRctbv70L4SwLjlGpe321nEmZ NxovisZdYmj75f6MoxTQrcs+1tlqeA02ZxS3NaCXfALCQOv0tjgLlDrmg0B0phPxjqw== X-Gm-Gg: ASbGncuqQ1lv7gFMY9hwlfTG2SG/KP3lzW/AycG/W08HCGOhX6wdFHGFGfsdA8PFb0J JNjdMmBkWxAlf/yuAiYtCnNFLz3R2uGfPVXtX708soopbAbpzQsGiakb58bq1ll/CV9rGSv4uM7 1cOdSeH6HCht+T7iWXY1sC1xslMFb83EDOlDS4FT40zk/YmJv6Rw5RS55cPHM1cFqDIJJQ8HhzB Jd+YxXUP4vGlNmSVByXktbzzeIrSERaMopks5pFWDvFon/f/AYxh38T1dptPTDX3AQEy3idF364 QdoHxLmYJ+1+nqgKorWbM+xM+xhFneAKN+l3g9AnDhkJNOBFHLdVzF1xczLM+LddYghKgvHGUDX +69sYEhmcFckxn1ycO79y9loShaD2koLUmBBdkWW6rIBe693LGcIXATbUECzExeB/j/E= X-Received: by 2002:a05:6000:2382:b0:3b5:dc05:79b with SMTP id ffacd0b85a97d-3b8d9470dbcmr12025168f8f.14.1754401669080; Tue, 05 Aug 2025 06:47:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGoBNgG9DHTZL/GHvltXJl3Ksy/Yg1AUSXduvhyK/z2xEluiR9OBlvVhh6LjDXV5JACQ/pyqQ== X-Received: by 2002:a05:6000:2382:b0:3b5:dc05:79b with SMTP id ffacd0b85a97d-3b8d9470dbcmr12025138f8f.14.1754401668575; Tue, 05 Aug 2025 06:47:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2b:b200:607d:d3d2:3271:1be0? (p200300d82f2bb200607dd3d232711be0.dip0.t-ipconnect.de. [2003:d8:2f2b:b200:607d:d3d2:3271:1be0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c48105csm19390080f8f.64.2025.08.05.06.47.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 06:47:47 -0700 (PDT) Message-ID: <4c68eb5d-1e0e-47f3-a1fc-1e063dd1fd47@redhat.com> Date: Tue, 5 Aug 2025 15:47:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] VFIO updates for v6.17-rc1 To: Linus Torvalds , Jason Gunthorpe Cc: Alex Williamson , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lizhe.67@bytedance.com" References: <20250804162201.66d196ad.alex.williamson@redhat.com> <20250804185306.6b048e7c.alex.williamson@redhat.com> <0a2e8593-47c6-4a17-b7b0-d4cb718b8f88@redhat.com> <20250805132558.GA365447@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.08.25 15:36, Linus Torvalds wrote: > On Tue, 5 Aug 2025 at 16:26, Jason Gunthorpe wrote: >> >> David, there is another alternative to prevent this, simple though a >> bit wasteful, just allocate a bit bigger to ensure the allocation >> doesn't end on an exact PAGE_SIZE boundary? > > So I don't mind adding a check for "page_section()", because at least > that makes sense. > > But yes, it would also probably be a good idea to try to minimize > SPARSEMEM without VMEMMAP. I'd love to get rid of it entirely, of > course, but even if that isn't possible, I'd *really* just like people > to try to make sure that it's neve ra valid thing to try to combine > memory across different sections. > > David mentioned the 1GB hugepage folios, and I really thought that > even *those* were all in one section. They *should* be. The memory section size on x86 is always 128 MiB. Even with SPARSEMEM. There are weird interactions between memory section size and memory hotplug / DAX, so we try to keep it small'ish. It's more that we don't care that much about memory section size with SPARSEMEM because nth_page() and everything around that is just plain simple. > > Do we have any relevant architectures that still do SPARSEMEM without > VMEMMAP? Because if it's purely some "legacy architecture" thing (ie > x86-32), how about just saying "no 1GB hugepages for you". arch/arm64/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE arch/loongarch/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE arch/powerpc/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE arch/riscv/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE if 64BIT arch/s390/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE arch/sparc/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE arch/x86/Kconfig: select SPARSEMEM_VMEMMAP_ENABLE if X86_64 But SPARSEMEM_VMEMMAP is still user-selectable. I would assume SPARSEMEM_VMEMMAP_ENABLE support would cover most hugetlb + dax users indeed, at least when it comes to gigantic folios. Would have to figure out why someone would want to disable it (limited vspace? but that should also not really be a problem on 64bit I think). -- Cheers, David / dhildenb