From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>, <roopa@nvidia.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<natechancellor@gmail.com>, <ndesaulniers@google.com>,
<bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR
Date: Mon, 25 Jan 2021 10:23:00 +0200 [thread overview]
Message-ID: <4c68f49c-a537-3f8f-73ed-5f243cb142a9@nvidia.com> (raw)
In-Reply-To: <1611542381-91178-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On 25/01/2021 04:39, Jiapeng Zhong wrote:
> coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code.
>
> Fix the following coccicheck warnings:
>
> ./net/bridge/br_multicast.c:1295:7-13: WARNING: PTR_ERR_OR_ZERO can be
> used.
>
> Reported-by: Abaci <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> net/bridge/br_multicast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 257ac4e..2229d10 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1292,7 +1292,7 @@ static int br_multicast_add_group(struct net_bridge *br,
> pg = __br_multicast_add_group(br, port, group, src, filter_mode,
> igmpv2_mldv1, false);
> /* NULL is considered valid for host joined groups */
> - err = IS_ERR(pg) ? PTR_ERR(pg) : 0;
> + err = PTR_ERR_OR_ZERO(pg);
> spin_unlock(&br->multicast_lock);
>
> return err;
>
This should be targeted at net-next.
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
next prev parent reply other threads:[~2021-01-26 6:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 2:39 Jiapeng Zhong
2021-01-25 8:23 ` Nikolay Aleksandrov [this message]
2021-01-26 2:33 ` Jakub Kicinski
2021-01-26 3:20 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-01-22 9:32 Jiapeng Zhong
2021-01-22 17:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c68f49c-a537-3f8f-73ed-5f243cb142a9@nvidia.com \
--to=nikolay@nvidia.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=bridge@lists.linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®