From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FFAC43382 for ; Fri, 28 Sep 2018 08:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 175C22172C for ; Fri, 28 Sep 2018 08:24:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 175C22172C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729193AbeI1Oqp (ORCPT ); Fri, 28 Sep 2018 10:46:45 -0400 Received: from mail5.windriver.com ([192.103.53.11]:41904 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728062AbeI1Oqp (ORCPT ); Fri, 28 Sep 2018 10:46:45 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id w8S8Mv4j016995 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 28 Sep 2018 01:23:08 -0700 Received: from [128.224.162.216] (128.224.162.216) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 28 Sep 2018 01:22:45 -0700 Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line To: Sergey Senozhatsky , Petr Mladek CC: Sergey Senozhatsky , Steven Rostedt , References: <6c354803-5341-7237-9ee3-7882252c7483@windriver.com> <20180919023932.GA14090@jagdpanzerIV> <20180918224312.6e9aef50@vmware.local.home> <1545bc85-b64a-4b45-d40f-79567ac621dc@windriver.com> <20180920123056.27b2cf18@gandalf.local.home> <20180921073753.mqayzofcofpmhiyu@pathway.suse.cz> <20180925120135.GB523@tigerII.localdomain> <20180925122300.qq5w4skwmxbzi6sy@pathway.suse.cz> <20180925133143.GB601@tigerII.localdomain> <20180926110500.vfroi373mookavua@pathway.suse.cz> <20180928073526.GA1160@jagdpanzerIV> From: He Zhe Message-ID: <4c68fc36-ddce-9a5f-e868-ab9135649792@windriver.com> Date: Fri, 28 Sep 2018 16:22:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928073526.GA1160@jagdpanzerIV> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [128.224.162.216] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年09月28日 15:35, Sergey Senozhatsky wrote: > On (09/26/18 13:05), Petr Mladek wrote: >> First, I would move the check into log_buf_len_update() so that >> we catch the overflow also in other situations. > OK. > >> Second, please, keep only the first line. > OK. > >> It is enough to describe the problem. > OK. > He Zhe, will you pick it up? Yes, I agree, I'll send v3 ASAP. Thanks, Zhe > > -ss >