From: Leo Li <sunpeng.li@amd.com>
To: Harry Wentland <harry.wentland@amd.com>, amd-gfx@lists.freedesktop.org
Cc: ndesaulniers@google.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, arnd@kernel.org,
alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, nathan@kernel.org, linux@roeck-us.net,
llvm@lists.linux.dev
Subject: Re: [PATCH] drm/amd/display: Reduce stack size for dml21_ModeSupportAndSystemConfigurationFull
Date: Thu, 16 Sep 2021 10:34:24 -0400 [thread overview]
Message-ID: <4c709b29-2f1c-aa64-409c-62bcd058f81c@amd.com> (raw)
In-Reply-To: <20210914210508.10627-1-harry.wentland@amd.com>
On 2021-09-14 17:05, Harry Wentland wrote:
> [Why & How]
> With Werror enabled in the kernel we were failing the clang build since
> dml21_ModeSupportAndSystemConfigurationFull's stack frame is 1064 when
> building with clang, and exceeding the default 1024 stack frame limit.
>
> The culprit seems to be the Pipe struct, so pull the relevant block
> out into its own sub-function.
>
> Signed-off-by: Harry Wentland<harry.wentland@amd.com>
> Fixes: 3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")
> Cc: Nick Desaulniers<ndesaulniers@google.com>
> Cc: Linus Torvalds<torvalds@linux-foundation.org>
> Cc:amd-gfx@lists.freedesktop.org
> Cc: Linux Kernel Mailing List<linux-kernel@vger.kernel.org>
> Cc: Arnd Bergmann<arnd@kernel.org>
> Cc: Leo Li<sunpeng.li@amd.com>
> Cc: Alex Deucher<alexander.deucher@amd.com>
> Cc: Christian König<christian.koenig@amd.com>
> Cc: Xinhui Pan<Xinhui.Pan@amd.com>
> Cc: Nathan Chancellor<nathan@kernel.org>
> Cc: Guenter Roeck<linux@roeck-us.net>
> Cc:llvm@lists.linux.dev
> ---
Reviewed-by: Leo Li <sunpeng.li@amd.com>
prev parent reply other threads:[~2021-09-16 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 21:05 Harry Wentland
2021-09-14 21:56 ` Arnd Bergmann
2021-09-16 14:34 ` Leo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c709b29-2f1c-aa64-409c-62bcd058f81c@amd.com \
--to=sunpeng.li@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@kernel.org \
--cc=christian.koenig@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®