From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 058921DFFD for ; Tue, 31 Mar 2026 13:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774963480; cv=none; b=j74NsQLE9uIonAziRDyVRXgRNQQMtxLqm/BjPGAcoQlf99WjdeB7bK5YgokxInxbiB/686w2KVcNT45J3Ej7WEFqEyK9yLXR0dIZrtYepumpU1hXlpwSIou2ccN3tqrXlzf2Ca/QegWvL//hta2i7wgugWSDd+BvKZATms6EXkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774963480; c=relaxed/simple; bh=Uhy4axSEFW2Qezt3TBNhyBcjDSrK7116X2GQnMj67Ds=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C0iNIczTudH6oXLXwFkS/Skvdzu5BjExEeDZBF17jnWXi+n1tmiTSh9aoBS71B3hTBP9ZaVz14IujI0A1Q71cd3C/Dm+Kh4UTVKsGcUFeAwYP3i76W7xLbdSrd0b07HMiho1W/kNWaS8dzKV7/RY2qXgRMKj18i7IInwdM1RU8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Xv8Qufrq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HkkXWSJ7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xv8Qufrq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HkkXWSJ7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774963478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eAEdH/RFIKcmDncsXTS+NqcpAUMnQKgVC83ZaxUTu8=; b=Xv8Qufrq42HFTUgwUYxxxJjD2lbnCVcT/RrLdx3/X2gNU7me4JtfSQp2Laq6NP8hz063+0 +N7ogW/i287KrXTdeZbaAan3CcDdwFO7Ev51rDZ9FJdtmBHHkhj/NN3CXROZEevOUXRB+B +kpIC3LYARwm5B/Aouktpe5RLuwypfg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-KtMQCuc8MgqQLKtpiK0xmQ-1; Tue, 31 Mar 2026 09:24:36 -0400 X-MC-Unique: KtMQCuc8MgqQLKtpiK0xmQ-1 X-Mimecast-MFC-AGG-ID: KtMQCuc8MgqQLKtpiK0xmQ_1774963475 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4852cf0318dso63052405e9.3 for ; Tue, 31 Mar 2026 06:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774963475; x=1775568275; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9eAEdH/RFIKcmDncsXTS+NqcpAUMnQKgVC83ZaxUTu8=; b=HkkXWSJ72hOcCnB9JF0AiZf5Mufa1jDsLMfgMGCEsUoVXMTxM/4HNWMrU8MbW9OEYp vZcWrl/PXnG43wLQVe8hfrfWyedQOBMjuVAo1Vv6LRRkaa3+S9w2UIs8R8KFhsI+RClD FDxmOOqxim71GjEGO9wWm2D+ugU53tdWrHgGHvP7m83h2tb3ikCNhVb0xJW2Ixb2YSR/ YVC31/zYiqzIfzpgHpfjxydHZyKfi2FE+OPGjiqLqFeEL1ep27MjGnwXcAcXmgS5uC0f MURB89EFuF1PB2pxZyOW59H5MNux8FvyhDf2WMV5w04RLz0CqYeP+x4bx1umGi7pLdHV QFPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774963475; x=1775568275; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9eAEdH/RFIKcmDncsXTS+NqcpAUMnQKgVC83ZaxUTu8=; b=Pig5uUJg2W6jIBHT8ZSz9jf5TWT/w2KZntJizevkTJp5yjtC7fHmJbKMNAlch/2A1/ NBH0o1U7lcBCGmx3q65h9qfbimk/+mtI95bHF6UJiKvk+OHU0upwcH4BZeXgVt0yOJND IwIecJH7TwcnPw0und3oHy/T5nsCkid91dYw2RZy26uq3kxpvvDUAinrOSI84XouEZJn l9+YNoQ3iHy5/6+hzN/jGIhbrMlJctpA3rES4PsGzpVGC0Qtg2riGM2zdEA9q6hMGSYX GE2PjerdKIzhFt+PkqTwvK3UwA94sbdn9gQd+qSqU2l5HzFhdvfVEU1WlGxI9OTUgp1H hETQ== X-Forwarded-Encrypted: i=1; AJvYcCVwlC7o6uHi41/pJTtdfwBDLBJdFTOIBU4CIUXonsaoCm2qVlltnIEgWC53MLdPeaMt8zSgezMySXk5kzg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+jcl1C+yQ3XN46TYOFjnJGYT3HOpafp8Ap13CTATXpGRv/pG0 9LGbhTPnICPWAeATh0pH6nTXuh8HSeLzGU7nEmw7eX1Zt8UwqOROet9HF6GZzKMvciYlDi2Ln7C OCXFK1QrKBv9qKJF6ysvkctjKR/1G82e+3V81TlNRlL+w7lia3IxDG+bIqQgYSXEJyA== X-Gm-Gg: ATEYQzykFHGpEjn3lfgWjhwjFL7HWstDe1p+HrOjjN+2zZg+xHwirheA9yO8TrEpY8r fockbz027SVUqAIuCqG8c6Vk1gPZQ0WtLDXuZ2upp1S1n6IaOlJhLgUcnbi5khY9a3YM4MFnXXK MUxOeUG8N0D17x7W183nARbTc23uZRXlCtqJivFJ/Q/fKhZry1y5l9/TKv3R+CFOOogxllk/sOl eQS/dIr6H3bmqDPSXK5exZMWf/Ric0Pv+Po3R6unNyCevyl8JOJ6OlHAQqLd4c6G4kMjpO5VWpo Au0JAxBccvMydSdNs75+NTJb6UaF/iD+jzG48pS6RFlxPolss+sHRiVSQrSM3jW1w5dYM7H2V8T 0Tb8nM4XGvjEsdfXDdQwvWqWsmWbyYLAR9Y6105/cSF2F9Edqx75VSm3B X-Received: by 2002:a05:600c:8b31:b0:485:30f7:6e88 with SMTP id 5b1f17b1804b1-48727efabdemr333299315e9.31.1774963475442; Tue, 31 Mar 2026 06:24:35 -0700 (PDT) X-Received: by 2002:a05:600c:8b31:b0:485:30f7:6e88 with SMTP id 5b1f17b1804b1-48727efabdemr333298965e9.31.1774963474986; Tue, 31 Mar 2026 06:24:34 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c536a7fsm37452055e9.1.2026.03.31.06.24.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 06:24:34 -0700 (PDT) Message-ID: <4c7118f6-425b-4584-86fb-97f2a68c4474@redhat.com> Date: Tue, 31 Mar 2026 15:24:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] net: phy: realtek: support MDI swapping for RTL8226-CG To: Jan Hoffmann , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Daniel Golle , Markus Stockhausen , Damien Dejean Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260327202001.413280-1-jan@3e8.eu> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260327202001.413280-1-jan@3e8.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/27/26 8:32 PM, Jan Hoffmann wrote: > +static int rtl8226_config_mdi_order(struct phy_device *phydev) > +{ > + u32 order; > + int ret; > + > + ret = of_property_read_u32(phydev->mdio.dev.of_node, "enet-phy-pair-order", &order); > + > + /* Property not present, nothing to do */ > + if (ret == -EINVAL || ret == -ENOSYS) > + return 0; > + > + if (ret) > + return ret; > + > + /* Only enabling MDI swapping is supported */ > + if (order != 1) > + return -EINVAL; I guess some existing setup may have "enet-phy-pair-order" == 0, and the above will make them fail. I think you should just pass with no action in such a case. /P