From: Qianfeng Rong <rongqianfeng@vivo.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: powernow: Remove redundant 'ret' variable in powernow_decode_bios()
Date: Wed, 3 Sep 2025 15:54:00 +0800 [thread overview]
Message-ID: <4c7249a4-d4fb-402a-b958-e862b6eb04fc@vivo.com> (raw)
In-Reply-To: <20250903073702.g755d3xtjlkkdbfs@vireshk-i7>
在 2025/9/3 15:37, Viresh Kumar 写道:
> This should have been marked as V4 with details of what changed.
> Sending it separately is fine (though wasn't really required), but you
> still need to maintain the versions.
Thank you for your reminder and for letting me learn about this rule.
>
> On 03-09-25, 15:29, Qianfeng Rong wrote:
>> Remove the unnecessary 'ret' variable from the powernow_decode_bios()
>> function. It is only used once to store the return value of get_ranges(p)
>> before immediately returning it. Simplify the code by directly returning
>> the result of get_ranges(p) instead.
>>
>> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
>> ---
>> drivers/cpufreq/powernow-k7.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
I see you have already added the Acked tag to this patch-do I still
need to send a V4 version with a detailed description of changes in
each version?
Best regards,
Qianfeng
next prev parent reply other threads:[~2025-09-03 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 7:29 Qianfeng Rong
2025-09-03 7:37 ` Viresh Kumar
2025-09-03 7:54 ` Qianfeng Rong [this message]
2025-09-03 7:59 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c7249a4-d4fb-402a-b958-e862b6eb04fc@vivo.com \
--to=rongqianfeng@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®