From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CEE8493 for ; Tue, 14 Jan 2025 21:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736888782; cv=none; b=Cji+McwATOPkHT+9BHLg6MwajJOwdi7W+PmnkS5Gd+FGHERATpQiL/an41M/Ab3+S9Yr/zDnU7zsGKplAGoB9d7SNZPA0psGTrqvg6Y6LUprrOqfQXmMLDtx1E5zpDSZ1AReW4FGsnILrWa+OqGeVkKq7bC4RK3NANDydKBXSCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736888782; c=relaxed/simple; bh=51Q2nrlUfdW/Lc/7yTyFynD+DttY9+jcTg9BgCE4LlE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YEkUfRlEnt2Nzqc2XarmARUQPoQNogHSDu5GE9eVY+6qnfiIork4aOJLxNN+DQpHgybMRr5Yw0wT4Q1tUGUGDH5OMzBtGsrx4V0J1g2Q6ANSZbw2xQz3lS7VwPbmXCiqruFqb+1EhGtgMorQWG80fOu3Ry6mQvWtFGmofH0VuYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=APONJFKs; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="APONJFKs" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-436284cdbe0so7516235e9.3 for ; Tue, 14 Jan 2025 13:06:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736888779; x=1737493579; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Wh00ZVUQdXtx7FYp7M8XVQoCDixad56Rl/xOiGs9l8Y=; b=APONJFKsLSs/vuH33CHi0tE9Y1jEgDv8xAU5IugTUph3oM6fEU0u2bhrihp5ySLTBe McIlN65XTg88M6YaK4ABjyZVaB5xJ8HQLbG5K1jSj8de2JRdw2sFpjKMqkC2FO/QgUQl 7wiMDUXUVCVrG8s8zN4bpiI6MclXeldP0m1CE0p8WFUX1slANbFbkUb+9uxL/JU2oP2+ PiMqWgl5Qpu9KKLOJ4qGhtYeR9ePqoZx7OM8x88yDkl9o9dWATgGoIEfAxidyqH3reqK dKmBLStgDzb6ieFmiicVo+bASh0du9Zo6ivjsI7PThm9vTYV16vbJbn0t/KAuVFH1Ih/ LHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736888779; x=1737493579; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wh00ZVUQdXtx7FYp7M8XVQoCDixad56Rl/xOiGs9l8Y=; b=frgPhmvpX3aBbUUnP0zl27QEZw1R3Jfds50rFmPHufv8KmIUbvSkEE4HihoVJdmGiz cHo1VJwRNJslcytOTNi1+vP4V/wKeeACkuKRNmKy3YwLRg3V9yk81uFiUgaPfjNIjWO9 9+krCpVtBg3eRrdvl77KzZTB0uxhaVlgl1D2fl90yZS8QL+v+xIpaPrymEbPj24JGKsi u40UQjl+A9kN00LrgDscVutl1fczsZ+9jtvTTCeCpgEM0VsJirh257HKJNZ0qBEXayOw RyTyo14zOqn5tCB4XSx5I0m+V7MkfWLhwfQVkj81NNZrwhehFzazTaGsONvZgLzJ1Tsp lSoQ== X-Forwarded-Encrypted: i=1; AJvYcCV1F78K/aPe02xzmtSr8hvusrP+rw+clkQXqYuGn994qSC0h+Vs2k/42AiRx7/wLdI4axBb2otPPfIqX5E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3EX2FbLtBoBUayl+NMDsQXRLZc8W8XSQc1EP8AOWyEcYONhWv Nbk7hMhLe+mAF5Pibo1tT3gUgMOVM5H/HRjsw0dNxrljBvG4VPa4ZP/OXjJE1gA= X-Gm-Gg: ASbGncs9Y076hMhkyYH1f/BGv4AkXRBDvKkWLE7F03zJgXfuSCub/UukgYxdSXedH5I PJMSYJCuz/bNu5ZCc3gujsMo9r/FuR/YBHjyawvT1QyCv2SrA/Vs9dhJVa859cVHAOULRAKhaok 0uSINxSHxPkOdu2hlZkrXfoG/+UsJUOJSHvb77iCL7NfXxUXG0YpL7QaKEiOeAXAPUrDmZl0gNi dHkrbr5JtBUASvBRypw7WP3mdS+Ni9REnnavERjhHPXE/9Gn2/kfKqZZKumvd5oRVRNHdoIi8Cw X-Google-Smtp-Source: AGHT+IEeXSdzS1m6uyUV/OIiskdETkROyZC4FLFot2bkEL/mDiNIRHbH98Ewnj3p1H/ZvDvD6Rm6zA== X-Received: by 2002:a05:600c:1d07:b0:436:1902:23b5 with SMTP id 5b1f17b1804b1-436e26f4abbmr94069265e9.4.1736888778614; Tue, 14 Jan 2025 13:06:18 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d11csm15947752f8f.16.2025.01.14.13.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 13:06:18 -0800 (PST) Message-ID: <4c79c0e4-dbe9-4f4e-8b2a-a5cf58d49a7c@linaro.org> Date: Tue, 14 Jan 2025 22:06:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] media: platform: Use str_enable_disable-like helpers To: Laurent Pinchart Cc: Hans Verkuil , Mauro Carvalho Chehab , Tomasz Figa , Marek Szyprowski , Maxim Levitsky , Sean Young , Olli Salonen , Abylay Ospan , Jemma Denson , Patrick Boettcher , Jacopo Mondi , Kieran Bingham , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Tim Harvey , Andy Walls , Sakari Ailus , Bingbu Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250114-str-enable-disable-media-v1-0-9316270aa65f@linaro.org> <20250114-str-enable-disable-media-v1-5-9316270aa65f@linaro.org> <20250114204240.GA29414@pendragon.ideasonboard.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20250114204240.GA29414@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/01/2025 21:42, Laurent Pinchart wrote: > Hi Krzysztof, > > Thank you for the patch. > > On Tue, Jan 14, 2025 at 08:46:21PM +0100, Krzysztof Kozlowski wrote: >> Replace ternary (condition ? "enable" : "disable") syntax with helpers >> from string_choices.h because: >> 1. Simple function call with one argument is easier to read. Ternary >> operator has three arguments and with wrapping might lead to quite >> long code. > > It's more difficult to read for me. That's obviously subjective, but I am surprised that such stuff is readable for you: data & XCSI_DLXINFR_SOTERR ? "true" : "false", video->hq_mode ? "on" : "off", video->jpeg_hq_quality); or from PCI parts of this set, note that's ternary is split here: dstat & BT848_DSTATUS_HLOC ? "yes" : "no"); > >> 2. Is slightly shorter thus also easier to read. >> 3. It brings uniformity in the text - same string. >> 4. Allows deduping by the linker, which results in a smaller binary >> file. > > I don't see why the linker can't de-dup string in the current code. > > I'm sorry, I just don't see the point in doing this. I'd like to avoid > those changes in the Linux media subsystem, or at the very least in > drivers I maintain. Ack. Best regards, Krzysztof