From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F0C1E51E0 for ; Mon, 29 Dec 2025 18:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767031348; cv=none; b=H1ViCVcLrkBE5ByziiL9cdj7dymMO0RLUQPzzFExJ6LvLbtphgwXpy+93p1FNKDzTdJNEKLQ1Qhe76219ZvSGHOBXJviecsvNbY48nIHJ+fY1ASuPjPDGPw8Wv2tqSpLiVAOLj/bv3Om/dZX/brclbz+FHk8SsDcD9Zdvw9Y51Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767031348; c=relaxed/simple; bh=Wq4FNyNXdL2dOO4wrLWKkEOSeqpU9XuvsacZ1Is3UGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k2eoerhzK2+2VNeKZlMkH5KXa5UA+WmmRzzMGNX7f9hJ+3G3sLr9kcsPnSkHgV7hwVudNkr5/3hF0C5yYziE/Fzo9AX/W5Z0iJM6tbgkCIZU0VzvR3zu/hqUo8v0aJKdVHFSJ82CF91zGjxRCjqohxjOvvUadBkwHUmBooiNZqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=t2wdZ+4w; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="t2wdZ+4w" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-88a2fe9e200so74628796d6.0 for ; Mon, 29 Dec 2025 10:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1767031345; x=1767636145; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xDy1M86lySMiZB+6e+NfnSGr5v4JHWbEjB5Zb9z5vPo=; b=t2wdZ+4w7Ajz9fevd3tA4lUf7mV2qblpu2vBsU0ua3j5homu2HKBkWKh9wqHlG8Y8g rVMsep/LABt5BBO3IcpeuuMFidISDOcw/xMp53tE6lmr+G3HNFx6Z/apYh3HWMruQ2ru Uk4ppvmmIGOOB3vfa3zfKTgRh/lltcPtlgd3wNKuzGHJ0s66P0BAhMGBZRrOFqcWLtNj zSxioC9zTU92v8EaPz6Q2O0P2qGYDlRmrXmXkTvOYNIOm0Hm7ep5HqVbSFS65XuFAZpo bWwZ3r6zlncjEBGD015G3GZwpKOWFLTAQ5ytNnJX8n4wgl6SvwEstNcDvzCr/VhRSd70 8Aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767031345; x=1767636145; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xDy1M86lySMiZB+6e+NfnSGr5v4JHWbEjB5Zb9z5vPo=; b=AQ3q/fkUsWyyV0qY/Kb3DlWAZIPIIan/S6URApfdjF0JGpya90Y9LR/4cwo7RCpn8P Br+1SHimtstJr3B2Wl7c5zKNckpXMhN7jf5h8/SJK0iX0IU5vtYwaYkYvERv8b2bgX/A pbfg8UvSyEAG5OEpNR2DKxo4H1eAoCihvWljbHx/X6mmAN0eZb2vV8zBfEvDPgj7N4yC 9kOOmmCxYHE5FXNMfM6JDN84+aOQB28EjOPPYCIR6aLOr4ofHFNK83QNTxHG1G1mjbCo isPGAoLDvfotumF79l0vkZGMdpzlU2S1TVNrYguCrgk8kPZIUOiwYXrYcGW6IoxQ0xYA UOZA== X-Forwarded-Encrypted: i=1; AJvYcCUi7LZebAgzxaxqkS3BNammFn3Rp2jIqUAYUl0aBLzPFX7gzl4VI8UkkSDt6kvSbD9nMVAcvuTtzdwmgDU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1zONEfRB8EjqaVkpQryPXXV7LmnSX2D392j+SCpdN4uyRolJI nqsTYNXePQlvTPGD0ALmCIQO/nUShXfTZ2LcsVnQ6mN9kNACBeeDBWIyvHW8Il5ArqE= X-Gm-Gg: AY/fxX6Zx5kLGseaGw1fFfVC+Nj+ILKdP87F6freBWqQLfrSeMbf3V2zB5wwNGAcHba 3h620aHaQozTlVpUgr+RKbmJNGtMQCHtO4/ThpCWc9MrPVzFI+rbx/6Lu12xpnZx9bDk59G1735 MA4FHFNgfHIv7TP//HXIfyZOMiv32nP2CnrLPhk1VAVoa/DcVIc40BxC1M6gR+5hdtKhETF6Sqb IN+WJPcsnrcYybCDoSuRvwU7ZTgopgFuDvDlkmWqO6nvX0H55VfJ54ZJwuGQQ+If4MVqAhjZu+B zagDOzwKtcfWgxmoSg+G8mrfkb5hN+SBe5t0jbx1yIJq5KYjshPQDzrmnuoI522INZLr6Ja48T4 qVRSm7was39+dJX2vXXBIc+cIpYpqdAXbFVeS5xNmSU7BhYESDtjAcD7D9Zcyf7buhI/dn8k7Ij Vi1q+sqvfw869vM1OQwpeE5HERtA== X-Google-Smtp-Source: AGHT+IGXtGMT6O6A6KaQIdzPXBUgINz+WinbQ4cwEL4NneioBCpZL0bLeOv1X+9oO0ye3ANqbf5YQw== X-Received: by 2002:a05:6214:3a83:b0:888:7d0a:18db with SMTP id 6a1803df08f44-88d83a78234mr548804566d6.48.1767031345078; Mon, 29 Dec 2025 10:02:25 -0800 (PST) Received: from [10.211.55.5] ([209.81.125.20]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d997ada77sm231925916d6.37.2025.12.29.10.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 10:02:24 -0800 (PST) Message-ID: <4c7c0f69-4732-4f62-970a-2a9273b3b5c7@riscstar.com> Date: Mon, 29 Dec 2025 12:02:23 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled To: Alexandre Belloni , Troy Mitchell Cc: Lee Jones , Yixun Lan , Andi Shyti , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org References: <20251225-p1-kconfig-fix-v4-0-44b6728117c1@linux.spacemit.com> <20251225-p1-kconfig-fix-v4-3-44b6728117c1@linux.spacemit.com> <202512251653368b33c7e7@mail.local> Content-Language: en-US From: Alex Elder In-Reply-To: <202512251653368b33c7e7@mail.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/25/25 10:53 AM, Alexandre Belloni wrote: > On 25/12/2025 15:46:33+0800, Troy Mitchell wrote: >> The RTC driver defaulted to the same value as MFD_SPACEMIT_P1, which >> caused it to be built-in automatically whenever the PMIC support was >> set to y. >> >> This is not always desirable, as the RTC function is not required on >> all platforms using the SpacemiT P1 PMIC. > > But then, can't people simply change the config? I don't feel like > this is an improvement. It's not an improvement for people who want to use the SpacemiT P1 PMIC, but it's an improvement for all the other RISC-V builds using "defconfig" that would rather have that support be modular to avoid needlessly consuming resources. I haven't done any testing on this but it looks fine to me. Acked-by: Alex Elder I think it's a small change worth merging. I don't think doing so does any harm. Your call or course, Alexandre. -Alex >> Signed-off-by: Troy Mitchell >> --- >> drivers/rtc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig >> index 50dc779f7f983074df7882200c90f0df21d142f2..53866493e9bbaf35ff0de85cbfe43e8343eadc1e 100644 >> --- a/drivers/rtc/Kconfig >> +++ b/drivers/rtc/Kconfig >> @@ -410,7 +410,7 @@ config RTC_DRV_SPACEMIT_P1 >> tristate "SpacemiT P1 RTC" >> depends on ARCH_SPACEMIT || COMPILE_TEST >> depends on MFD_SPACEMIT_P1 >> - default MFD_SPACEMIT_P1 >> + default m if MFD_SPACEMIT_P1 >> help >> Enable support for the RTC function in the SpacemiT P1 PMIC. >> This driver can also be built as a module, which will be called >> >> -- >> 2.52.0 >> >