From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D41C3F2D7 for ; Mon, 2 Mar 2020 16:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 091472146E for ; Mon, 2 Mar 2020 16:15:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EOe5Q1Ui" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbgCBQPb (ORCPT ); Mon, 2 Mar 2020 11:15:31 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:21150 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726621AbgCBQPb (ORCPT ); Mon, 2 Mar 2020 11:15:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583165730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mmvLYV8uSGKamG5bn2woan+DsvrYgigNBwpjj5pYtP4=; b=EOe5Q1Ui9U0fPNriM4iABmpmsnggs0woQ7J+hlOO88tX/NfvDKe14HvxzUj+hVTqv9EoIe ePon2HhBehlkmB2v0GFIooYrN+LAl2kbalM1dNvGBbw8KPUICclDNndIhcCrIK0Z+HB23a zBB/tclu50fhzbEEbMFrcJkJhEotqUk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-5yzTkBaBMPuGoPKZwvttvg-1; Mon, 02 Mar 2020 11:15:28 -0500 X-MC-Unique: 5yzTkBaBMPuGoPKZwvttvg-1 Received: by mail-wr1-f70.google.com with SMTP id w11so1817825wrp.20 for ; Mon, 02 Mar 2020 08:15:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mmvLYV8uSGKamG5bn2woan+DsvrYgigNBwpjj5pYtP4=; b=dQHnQG+7/hDVfxenW6LC7c+wZbbvvu82umNjirrzln2YRF2uBcMVeVyyOp802Kzo0p Cwb9u30nRKwtnkSw4DsEWGD2VZTzhGdshSfO7AwjkoDGcQsGATq8bRNOXu9SSAEq+sbs 3OuIeI6vl+oLMbLbs84evNpa22tBAQAUg6Nky2vv47CjBC83GJ+D19g/cAezgSJEckF/ 3ZuDI5MBcGcQu3m31Vl7Wov9A2GWf5Q6J7FR63xuVh5uXHBDg9eTHjafmr1f3uEsf4e3 oLdNGEPB9dk2qcpT9QzdwGBFYuAeO9sHz4S/6JxXiPZTKLWx1JCW7rjAR9E6Ehx70LVp ROpA== X-Gm-Message-State: ANhLgQ3c4eTVR6omWcvJZYMCogcxzicj56F2L0+nIKOBsVk1a1PYzYHh UgoEH/IitTIgcPxqFKt6aaBMYVKKNkbEhKhuV1nTaGwI53P8ZBeMSEMycohbxI4dO82uRfwjr4H TYdd3umo9gWZ0Vk+GgQDapoZb X-Received: by 2002:a5d:5303:: with SMTP id e3mr344176wrv.274.1583165727168; Mon, 02 Mar 2020 08:15:27 -0800 (PST) X-Google-Smtp-Source: ADFU+vuZcTc1H12c5GWZ/vC0FhpVFV4kZ8UauvtLtPuaHd1TfxD7u0doqtcC+cwc3WdkGewCKmPeGQ== X-Received: by 2002:a5d:5303:: with SMTP id e3mr344158wrv.274.1583165726844; Mon, 02 Mar 2020 08:15:26 -0800 (PST) Received: from [192.168.178.40] ([151.30.85.6]) by smtp.gmail.com with ESMTPSA id b24sm5726409wmj.13.2020.03.02.08.15.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2020 08:15:26 -0800 (PST) Subject: Re: [PATCH v2] KVM: Remove unnecessary asm/kvm_host.h includes To: Peter Xu , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jianjay.zhou@huawei.com, Sean Christopherson , Vitaly Kuznetsov References: <20200228183020.398692-1-peterx@redhat.com> From: Paolo Bonzini Message-ID: <4c7c323e-5e5d-01b6-fb94-74390a813ff1@redhat.com> Date: Mon, 2 Mar 2020 17:15:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200228183020.398692-1-peterx@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/20 19:30, Peter Xu wrote: > Remove includes of asm/kvm_host.h from files that already include > linux/kvm_host.h to make it more obvious that there is no ordering issue > between the two headers. linux/kvm_host.h includes asm/kvm_host.h to > pick up architecture specific settings, and this will never change, i.e. > including asm/kvm_host.h after linux/kvm_host.h may seem problematic, > but in practice is simply redundant. > > Signed-off-by: Peter Xu > --- > v2: > - s/unecessary/unnecessary/ > - use Sean's suggested commit message > --- > arch/arm/kvm/coproc.c | 1 - > arch/arm64/kvm/fpsimd.c | 1 - > arch/arm64/kvm/guest.c | 1 - > arch/arm64/kvm/hyp/switch.c | 1 - > arch/arm64/kvm/sys_regs.c | 1 - > arch/arm64/kvm/sys_regs_generic_v8.c | 1 - > arch/powerpc/kvm/book3s_64_vio.c | 1 - > arch/powerpc/kvm/book3s_64_vio_hv.c | 1 - > arch/powerpc/kvm/book3s_hv.c | 1 - > arch/powerpc/kvm/mpic.c | 1 - > arch/powerpc/kvm/powerpc.c | 1 - > arch/powerpc/kvm/timing.h | 1 - > arch/s390/kvm/intercept.c | 1 - > arch/x86/kvm/mmu/page_track.c | 1 - > virt/kvm/arm/psci.c | 1 - > 15 files changed, 15 deletions(-) > > diff --git a/arch/arm/kvm/coproc.c b/arch/arm/kvm/coproc.c > index 07745ee022a1..f0c09049ee99 100644 > --- a/arch/arm/kvm/coproc.c > +++ b/arch/arm/kvm/coproc.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index 525010504f9d..e329a36b2bee 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 2bd92301d32f..23ebe51410f0 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > > #include "trace.h" > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > index dfe8dd172512..f3e0ab961565 100644 > --- a/arch/arm64/kvm/hyp/switch.c > +++ b/arch/arm64/kvm/hyp/switch.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 3e909b117f0c..b95f7b7743c8 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm64/kvm/sys_regs_generic_v8.c b/arch/arm64/kvm/sys_regs_generic_v8.c > index 2b4a3e2d1b89..9cb6b4c8355a 100644 > --- a/arch/arm64/kvm/sys_regs_generic_v8.c > +++ b/arch/arm64/kvm/sys_regs_generic_v8.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c > index ee6c103bb7d5..50555ad1db93 100644 > --- a/arch/powerpc/kvm/book3s_64_vio.c > +++ b/arch/powerpc/kvm/book3s_64_vio.c > @@ -27,7 +27,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/powerpc/kvm/book3s_64_vio_hv.c b/arch/powerpc/kvm/book3s_64_vio_hv.c > index ab6eeb8e753e..6fcaf1fa8e02 100644 > --- a/arch/powerpc/kvm/book3s_64_vio_hv.c > +++ b/arch/powerpc/kvm/book3s_64_vio_hv.c > @@ -24,7 +24,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 2cefd071b848..f065d6956342 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -72,7 +72,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c > index fe312c160d97..23e9c2bd9f27 100644 > --- a/arch/powerpc/kvm/mpic.c > +++ b/arch/powerpc/kvm/mpic.c > @@ -32,7 +32,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 1af96fb5dc6f..c1f23cb4206c 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -32,7 +32,6 @@ > #include > #endif > #include > -#include > > #include "timing.h" > #include "irq.h" > diff --git a/arch/powerpc/kvm/timing.h b/arch/powerpc/kvm/timing.h > index ace65f9fed30..feef7885ba82 100644 > --- a/arch/powerpc/kvm/timing.h > +++ b/arch/powerpc/kvm/timing.h > @@ -10,7 +10,6 @@ > #define __POWERPC_KVM_EXITTIMING_H__ > > #include > -#include > > #ifdef CONFIG_KVM_EXIT_TIMING > void kvmppc_init_timing_stats(struct kvm_vcpu *vcpu); > diff --git a/arch/s390/kvm/intercept.c b/arch/s390/kvm/intercept.c > index a389fa85cca2..3655196f1c03 100644 > --- a/arch/s390/kvm/intercept.c > +++ b/arch/s390/kvm/intercept.c > @@ -12,7 +12,6 @@ > #include > #include > > -#include > #include > #include > #include > diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c > index 3521e2d176f2..0713778b8e12 100644 > --- a/arch/x86/kvm/mmu/page_track.c > +++ b/arch/x86/kvm/mmu/page_track.c > @@ -14,7 +14,6 @@ > #include > #include > > -#include > #include > > #include "mmu.h" > diff --git a/virt/kvm/arm/psci.c b/virt/kvm/arm/psci.c > index 17e2bdd4b76f..14a162e295a9 100644 > --- a/virt/kvm/arm/psci.c > +++ b/virt/kvm/arm/psci.c > @@ -12,7 +12,6 @@ > > #include > #include > -#include > > #include > #include > Queued, thanks. Paolo