mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lei Wei <quic_leiwei@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_kkumarcs@quicinc.com>, <quic_suruchia@quicinc.com>,
	<quic_pavir@quicinc.com>, <quic_linchen@quicinc.com>,
	<quic_luoj@quicinc.com>, <srinivas.kandagatla@linaro.org>,
	<bartosz.golaszewski@linaro.org>, <vsmuthu@qti.qualcomm.com>,
	<john@phrozen.org>
Subject: Re: [PATCH net-next 1/5] dt-bindings: net: pcs: Add Ethernet PCS for Qualcomm IPQ9574 SoC
Date: Mon, 4 Nov 2024 19:01:30 +0800	[thread overview]
Message-ID: <4c849bc5-979f-4f78-bb46-50b93f087d9f@quicinc.com> (raw)
In-Reply-To: <c3kdfqqcgczy3k2odbxnemmjvuaoqmli67zisyrrrdfxd5hu4v@thxnvpv5gzap>



On 11/2/2024 9:34 PM, Krzysztof Kozlowski wrote:
> On Fri, Nov 01, 2024 at 06:32:49PM +0800, Lei Wei wrote:
>> The 'UNIPHY' PCS block in the IPQ9574 SoC includes PCS and SerDes
>> functions. It supports different interface modes to enable Ethernet
>> MAC connections to different types of external PHYs/switch. It includes
>> PCS functions for 1Gbps and 2.5Gbps interface modes and XPCS functions
>> for 10Gbps interface modes. There are three UNIPHY (PCS) instances
>> in IPQ9574 SoC which provide PCS/XPCS functions to the six Ethernet
>> ports.
>>
>> Signed-off-by: Lei Wei <quic_leiwei@quicinc.com>
>> ---
>>   .../bindings/net/pcs/qcom,ipq9574-pcs.yaml         | 230 +++++++++++++++++++++
>>   include/dt-bindings/net/pcs-qcom-ipq.h             |  15 ++
>>   2 files changed, 245 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/pcs/qcom,ipq9574-pcs.yaml b/Documentation/devicetree/bindings/net/pcs/qcom,ipq9574-pcs.yaml
>> new file mode 100644
>> index 000000000000..a33873c7ad73
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/pcs/qcom,ipq9574-pcs.yaml
>> @@ -0,0 +1,230 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/pcs/qcom,ipq9574-pcs.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Ethernet PCS for Qualcomm IPQ SoC
> 
> s/IPQ/IPQ9574/
> 

OK, will update.

>> +
>> +maintainers:
>> +  - Lei Wei <quic_leiwei@quicinc.com>
> 
> ...
> 
>> +    const: 0
>> +
>> +  clocks:
>> +    items:
>> +      - description: system clock
>> +      - description: AHB clock needed for register interface access
>> +
>> +  clock-names:
>> +    items:
>> +      - const: sys
>> +      - const: ahb
>> +
>> +  '#clock-cells':
> 
> Use consistent quotes, either ' or "
> 

OK, will use single quotes ' everywhere.

>> +    const: 1
>> +    description: See include/dt-bindings/net/pcs-qcom-ipq.h for constants
>> +
>> +patternProperties:
>> +  "^pcs-mii@[0-4]$":
>> +    type: object
>> +    description: PCS MII interface.
>> +
>> +    properties:
>> +      reg:
>> +        minimum: 0
>> +        maximum: 4
>> +        description: MII index
>> +
>> +      clocks:
>> +        items:
>> +          - description: PCS MII RX clock
>> +          - description: PCS MII TX clock
>> +
>> +      clock-names:
>> +        items:
>> +          - const: mii_rx
> 
> rx
> 

OK.

>> +          - const: mii_tx
> 
> tx

OK.

> 
>> +
>> +    required:
>> +      - reg
>> +      - clocks
>> +      - clock-names
>> +
>> +    additionalProperties: false
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - '#address-cells'
>> +  - '#size-cells'
>> +  - clocks
>> +  - clock-names
>> +  - '#clock-cells'
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/qcom,ipq9574-gcc.h>
>> +
>> +    pcs0: ethernet-pcs@7a00000 {
> 
> Drop unused labels here and further.
> 

OK, will drop the unused labels "pcs0" and "pcs0_miiX".

>> +        compatible = "qcom,ipq9574-pcs";
>> +        reg = <0x7a00000 0x10000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +        clocks = <&gcc GCC_UNIPHY0_SYS_CLK>,
>> +                 <&gcc GCC_UNIPHY0_AHB_CLK>;
>> +        clock-names = "sys",
>> +                      "ahb";
>> +        #clock-cells = <1>;
>> +
>> +        pcs0_mii0: pcs-mii@0 {
>> +            reg = <0>;
>> +            clocks = <&nsscc 116>,
>> +                     <&nsscc 117>;
>> +            clock-names = "mii_rx",
>> +                          "mii_tx";
>> +        };
>> +
>> +        pcs0_mii1: pcs-mii@1 {
>> +            reg = <1>;
>> +            clocks = <&nsscc 118>,
>> +                     <&nsscc 119>;
>> +            clock-names = "mii_rx",
>> +                          "mii_tx";
>> +        };
>> +
>> +        pcs0_mii2: pcs-mii@2 {
>> +            reg = <2>;
>> +            clocks = <&nsscc 120>,
>> +                     <&nsscc 121>;
>> +            clock-names = "mii_rx",
>> +                          "mii_tx";
>> +        };
>> +
>> +        pcs0_mii3: pcs-mii@3 {
>> +            reg = <3>;
>> +            clocks = <&nsscc 122>,
>> +                     <&nsscc 123>;
>> +            clock-names = "mii_rx",
>> +                          "mii_tx";
>> +        };
>> +    };
>> +
>> +    pcs1: ethernet-pcs@7a10000 {
> 
> One example is enough, drop the rest.
> 

OK.

>> +        compatible = "qcom,ipq9574-pcs";
>> +        reg = <0x7a10000 0x10000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +        clocks = <&gcc GCC_UNIPHY1_SYS_CLK>,
>> +                 <&gcc GCC_UNIPHY1_AHB_CLK>;
>> +        clock-names = "sys",
>> +                      "ahb";
>> +        #clock-cells = <1>;
>> +
>> +        pcs1_mii0: pcs-mii@0 {
>> +            reg = <0>;
>> +            clocks = <&nsscc 124>,
>> +                     <&nsscc 125>;
>> +            clock-names = "mii_rx",
>> +                          "mii_tx";
>> +        };
>> +    };
>> +
>> +    pcs2: ethernet-pcs@7a20000 {
>> +        compatible = "qcom,ipq9574-pcs";
>> +        reg = <0x7a20000 0x10000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +        clocks = <&gcc GCC_UNIPHY2_SYS_CLK>,
>> +                 <&gcc GCC_UNIPHY2_AHB_CLK>;
>> +        clock-names = "sys",
>> +                      "ahb";
>> +        #clock-cells = <1>;
>> +
>> +        pcs2_mii0: pcs-mii@0 {
>> +            reg = <0>;
>> +            clocks = <&nsscc 126>,
>> +                     <&nsscc 127>;
>> +            clock-names = "mii_rx",
>> +                          "mii_tx";
>> +        };
>> +    };
>> diff --git a/include/dt-bindings/net/pcs-qcom-ipq.h b/include/dt-bindings/net/pcs-qcom-ipq.h
>> new file mode 100644
>> index 000000000000..8d9124ffd75d
>> --- /dev/null
>> +++ b/include/dt-bindings/net/pcs-qcom-ipq.h
> 
> Filename matching exactly binding filename.
> 

OK.

> Best regards,
> Krzysztof
> 


  reply	other threads:[~2024-11-04 11:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01 10:32 [PATCH net-next 0/5] Add PCS support " Lei Wei
2024-11-01 10:32 ` [PATCH net-next 1/5] dt-bindings: net: pcs: Add Ethernet PCS " Lei Wei
2024-11-02 13:34   ` Krzysztof Kozlowski
2024-11-04 11:01     ` Lei Wei [this message]
2024-11-01 10:32 ` [PATCH net-next 2/5] net: pcs: Add PCS driver " Lei Wei
2024-11-01 13:00   ` Andrew Lunn
2024-11-04 11:14     ` Lei Wei
2024-11-04 13:43       ` Andrew Lunn
2024-11-07 12:12         ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 3/5] net: pcs: qcom-ipq: Add PCS create and phylink operations for IPQ9574 Lei Wei
2024-11-01 13:21   ` Andrew Lunn
2024-11-01 16:31     ` Jakub Kicinski
2024-11-06  3:16     ` Lei Wei
2024-11-06  3:43       ` Andrew Lunn
2024-11-08 11:31         ` Lei Wei
2024-11-08 11:37           ` Russell King (Oracle)
2024-11-08 13:24           ` Andrew Lunn
2024-11-12 12:48             ` Lei Wei
2024-11-07 19:02   ` Russell King (Oracle)
2024-11-08 12:03     ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 4/5] net: pcs: qcom-ipq: Add USXGMII interface mode " Lei Wei
2024-11-01 10:32 ` [PATCH net-next 5/5] MAINTAINERS: Add maintainer for Qualcomm IPQ PCS driver Lei Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c849bc5-979f-4f78-bb46-50b93f087d9f@quicinc.com \
    --to=quic_leiwei@quicinc.com \
    --cc=andrew@lunn.ch \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=john@phrozen.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_kkumarcs@quicinc.com \
    --cc=quic_linchen@quicinc.com \
    --cc=quic_luoj@quicinc.com \
    --cc=quic_pavir@quicinc.com \
    --cc=quic_suruchia@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vsmuthu@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®