From: "Huang, Kai" <kai.huang@intel.com>
To: "Sun, Yi" <yi.sun@intel.com>
Cc: "Yan, Dongcheng" <dongcheng.yan@intel.com>,
"Su, Heng" <heng.su@intel.com>, "bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"x86@kernel.org" <x86@kernel.org>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"yi.sun@linux.intel.com" <yi.sun@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] x86/tdx: Dump TDX version During the TD Bootup
Date: Fri, 6 Oct 2023 20:40:18 +0000 [thread overview]
Message-ID: <4c8d4075a43e7000e6724e38fe1fa93df10c6109.camel@intel.com> (raw)
In-Reply-To: <ZR/q/VaR8gF1CdOg@ysun46-mobl.ccr.corp.intel.com>
On Fri, 2023-10-06 at 19:09 +0800, Sun, Yi wrote:
> > > +
> > > + /* TDX 1.0 does not have the TDCALL TDG.SYS.RD */
> > > +version_1_0:
> > > + td_sys->vendor_id = TDX_VENDOR_INTEL;
> > > + td_sys->major_version = 1;
> > > + td_sys->minor_version = 0;
> >
> > So the main reason that I think you can just print module version in this
> > function instead of tdx_early_init() is because IIUC you are setting up some
> > random value for TDX module 1.0. Probably it's better to just print it's module
> > 1.0 w/o mentioning major/minor.
>
> Actually, it is not a random value here; it is the fixed value for TDX 1.0
> becasue there is not such version info in TDX 1.0.
> I assume we can state major=1 and minor=0 when TDX 1.0 is detected.
> This will prevent confusion for the users.
I mean we cannot assume minor always being 0, IIUC. I am not sure whether we
should report it just as 0.
next prev parent reply other threads:[~2023-10-06 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 6:28 Yi Sun
2023-10-06 8:11 ` Nikolay Borisov
2023-10-06 10:20 ` Yi Sun
2023-10-06 9:48 ` Huang, Kai
2023-10-06 11:09 ` Sun, Yi
2023-10-06 20:40 ` Huang, Kai [this message]
2023-10-09 1:23 ` Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c8d4075a43e7000e6724e38fe1fa93df10c6109.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dongcheng.yan@intel.com \
--cc=heng.su@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yi.sun@intel.com \
--cc=yi.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®