From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010038.outbound.protection.outlook.com [52.101.193.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20242750FA for ; Tue, 18 Nov 2025 04:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.38 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763440752; cv=fail; b=irCdzXEJ9V9ZorMbobupIofYro7ehaksuTyBspSXHvT4afslCPXK646p7TuGJeO6uX1gJqvlhk7nSQMX64M3g8Y7S3Sgcn177+TnUtM1mTvFhuPtcsVcKkE2f1l16vKP6EEEaY1IbrjazHkkCuE+zv6Q0j+knNIOBU5SXr5Krbw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763440752; c=relaxed/simple; bh=LuEn1i5U2GR9Ctzov27sG5XC2ZvF9PACR0ODeuDuxu8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oTqDW3XEliL1f4pLqsjVFKOztJGCqRFy/MjwplB7ko9RYw/xeW+l5O26BgKRwGJX5xlPhld0wcayA+7sYrH05soDQGHUwn2uYHbfj+Shal+qhw45komRMcfxyblm4p1jFAMdektiRjPVrNK2Kj0FBlOAeBuPJuv9lUPIRqA2x/s= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KNXEp3yE; arc=fail smtp.client-ip=52.101.193.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KNXEp3yE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qjQpbXlCyNKnHLJmGnu119Ob0CUNJb8AXhrTcACGL190TM5aN4budXGwW7dm730y4EiMD73iWX5cUGPlJtwcqWGzvS4mVZaktag5IOY9xxbLyeTj/xDyHqDeKXvQMCCRh1VMqHEX/mufbLiFwZFk+C8T1FTdmjr5AnqMxG63GdVQlc0puP8YiR8E35Bqa/K2ZDwd60wXopZ1AQ7BLuHOb+E9RMIXXIeGzLGf0zUJe80eYh5FX4tLsGGlBrsg3tW87VIdwrwAil4MLH3xa8Ss4XmcyK8vn+fLGZPN2kjPamRc33DFcpCRnKiZYmgpsvo0p30saQ0i8Rnqvzz4J/7izg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F3veNKiqo/wG74ZLRrCEmU+GibtVErP3euL+LVXN17Q=; b=QSM0XNz2g0jF6mQjmjdFl+w5y5dGqUMRbbfBd6ZTFlYjo/+npW2APIc+kK11IvFu3odTXURrMGh1SKBMD2fZ/IrXJ8hIYFk0lEA350M9TOaUpecGab6K/sMdUSJLLp0SfP6UfWEue4Su//lt+7o7xuBpYB+QQLRhoz3n6LQvC9LYPZBLfmsXXFbcs1ZqVH1osM6X1E90UdCKiPv4h5n9Pwe3jCZAXe5d8imIh91zdJPOcmzPTttXID7y5UYTNXGOhd+uXhu/UGOIEF7kLN755d2hO1dQLHx3e6R+fVz0giBE+GDwsow/IL7Va1wnMcvYj8+WnreJ4M2RKmCGl8UPoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3veNKiqo/wG74ZLRrCEmU+GibtVErP3euL+LVXN17Q=; b=KNXEp3yE0Ygi/fDc6Kv66wrto6oA90g99fu4VJ91alIVinWYfHAIFvrBGPJ2/YdpxWmKWskCPCqxsYz+zD8h18pgGPZRwIhQFRoYHYaPVEI1y52TmhZETor9+C5pABlUAh7Mtx6oSMVpqoDO1sFA8fdq3KReq1ertR2Wg3YNSn0= Received: from MN2PR15CA0029.namprd15.prod.outlook.com (2603:10b6:208:1b4::42) by PH8PR12MB7027.namprd12.prod.outlook.com (2603:10b6:510:1be::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.17; Tue, 18 Nov 2025 04:39:04 +0000 Received: from BL02EPF00021F6F.namprd02.prod.outlook.com (2603:10b6:208:1b4:cafe::4a) by MN2PR15CA0029.outlook.office365.com (2603:10b6:208:1b4::42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.23 via Frontend Transport; Tue, 18 Nov 2025 04:39:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF00021F6F.mail.protection.outlook.com (10.167.249.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 04:39:03 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Mon, 17 Nov 2025 20:39:03 -0800 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Nov 2025 22:39:03 -0600 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 17 Nov 2025 20:38:59 -0800 Message-ID: <4c91be40-fcd8-4e5b-a584-7b65ab9dd086@amd.com> Date: Tue, 18 Nov 2025 10:08:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/5] sched/core: Track blocked tasks retained on rq for proxy To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , John Stultz , "Johannes Weiner" , Suren Baghdasaryan , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider References: <20251117185550.365156-1-kprateek.nayak@amd.com> <20251117185550.365156-4-kprateek.nayak@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20251117185550.365156-4-kprateek.nayak@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: None (SATLEXMB05.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6F:EE_|PH8PR12MB7027:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d088b93-e36b-4930-4c78-08de265c66ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFZMQURpSE1TcTRFMjhJdHVKVEx5dTRqT21jaHBDR2d1MXhWZGtpOUd1bXdh?= =?utf-8?B?QzBPa3ZMNlNvOUZpSEZoYzh2MzBBMjJOZnQzOC9xQW83c0IwaFpna1VETHVy?= =?utf-8?B?bkw1STBnSlhiS1NGd0hBbW5pN2FEakpKUW1XdG8xNjM4Z1JZUGhJMlFtSnVZ?= =?utf-8?B?SXZETnJyUDd3S2R5R2RDMk1wQktYN25qcEU3Y3JROVpJbG44ZTVWSjFhaG9W?= =?utf-8?B?S280bUp5UXJHUFRFQytqRnBwdGdxOTNJNXRjODFlclJwNll3aDl6K0lDZGZ6?= =?utf-8?B?UEtaTXkzM0ViNmJwcjg2WEdOOEFrcVR2NkFxRFNvdlQxTEVZbmZ3QXNiWkRL?= =?utf-8?B?ei9OY1kxV05mZDZiY2sydWNuQmJ4RGdGbGF2VlV3RThSNzAxMXlObEczdGU3?= =?utf-8?B?UUFYWVoxUWNkby9hTG9KWmtLZmtvNk80Q042TXZPam9PbitySzhNV1NCSVcv?= =?utf-8?B?WFpFQXhuT2wyL2dyL0xzMWhWMllKQkJYT29yMXdscDdjVzdtODRHMmc3ZUEz?= =?utf-8?B?eHFIMjdqRmJMWFNNNmRMT0ZWNFlVWWlWR3hqTHdPM1hncVJNRVVDZjFhdDJl?= =?utf-8?B?dGxySzBPc1lkQWdPc0Y2Z09VdllGMG5FNjlNeTFQT21xSHU4dVNwc1dsSkdP?= =?utf-8?B?T0VjZG44aTZsWkNhQk9GWU05ZmlkcklmRDRRZnNRQ0dsL1B4QUxZUm1OcHNF?= =?utf-8?B?dDB3Uy9EcUd6MTU2MEQ0RnBId3hvS1B1MndaRUduaTliVTBOT0thNWE2T2w1?= =?utf-8?B?ME1jRVExbnhNQXBsNWo4am13NGRsMjg5ZFNvYkFKc1IxL0dNK2U0eGQxUHI1?= =?utf-8?B?RU9IME5hZnZtNDl5T253NXoyUDJpamhYQkc2K1M0anp4aUdiN002RFFHTktM?= =?utf-8?B?V2ZJSkpLZGpDSGFtemZQaGtNQmtRWEZjYWVBMzRjL1J4QWRUR1duZTJZZzZa?= =?utf-8?B?am1rWnJjdUFNZG44QjJnT21WUzQ5dUNzS2xjaHJQT2dDT1J0eXFFeVBBQzBp?= =?utf-8?B?SzN4N3BWclM3RmxFL0tWWlNxby9VQW5YblRmWmJYcHFrSTJHNzRkcU55bW02?= =?utf-8?B?UWV2SmFyT1hUQlkvRm14a3JwS3ZQd09XK0ZhK1A2eWw1ZkppZ08wNDFJdGhC?= =?utf-8?B?bVNpTnlsUVRzWW9RVm4vVlQrcnR5eFFwa3p4Q2Jva3pIY2YyS2J6UFFaazYy?= =?utf-8?B?UzYrMHVxanRsMlZkWklxSnpnSjBqaFpvOGVQejVUYWRRNGRrSXgyd0thNWNF?= =?utf-8?B?L2M1OHJaRlFCVlozNGRXWDc4bTN6alVpTTZ6NURuNG1Selc5N0xpeWdMRGFF?= =?utf-8?B?dC9Mb2MwTVpjNUVGdkhmMjlGdHcvSlJ5VUFaLzdBbmhVazkvcGZUV0wvc0Y0?= =?utf-8?B?M1pGS1V5cVY4aTV4aWhKam1BcFBFajlocloxZGJMQWRCUWRBTHdZeEFqMVZj?= =?utf-8?B?SkZDRDJKTFNCUXBzZE5YQnk1eGx0VkdKdFdpbEw5TFBvNFpqWHRUOXY4U1RF?= =?utf-8?B?alp5LzBHQ0lqZit5VXo5MlJvbWpvSGFwak9MRVZHM2FWbEVhQ0xjaG1JQ3VN?= =?utf-8?B?U2FuMGlWNXdIWHlYOFNUWVZMNDRZaE0yZFhHM0FhL0QvaEp3U2FQZkFKd2oz?= =?utf-8?B?Zk9rR1grNTNUS3ZpYTM0aE1WUE5YYlFqWWhIMzZWNlZ5UHRGd1hLdEgvd3ow?= =?utf-8?B?U24wVGpWT25CcjVWYUFFdm42VFplcnU0TEd5OHVETm1RYVpKbGIva20vTXFG?= =?utf-8?B?aVJSb2IvMThMRUdjVFZrS1JiWG1wWmtiR3hhZExxRlgyWVdDR1F1OWpzK3Jt?= =?utf-8?B?SmNLeEl5ZFlQL2dDVHVDWHA1NDR4bE4wN1dRMk9hY2taNm5oS3VoYnFpNURj?= =?utf-8?B?UzJpR2xqZ2FYWHp6LzZYNUQvZkR5VE5iazVqMTgzNEVLYUJZUDMwYTdHZEZ1?= =?utf-8?B?aDRCMFp6TCtWT01vRDQ1THRlVlJlRS9yYjFTdFVLWlBLWGVLYjZqTUUxb0Qx?= =?utf-8?B?dDM0OHg1NGtGRE5kQ3NMSSt5aFdldDRNcEJUOFlhWVJzMURRaHRJMVNDanRl?= =?utf-8?B?SFNyRVV4RStCbGtxL1B3RnRIZEwybE45Q3U1M2tucEphLzJTbi9vbGNKVU1l?= =?utf-8?Q?NCUg=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 04:39:03.8565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d088b93-e36b-4930-4c78-08de265c66ef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7027 On 11/18/2025 12:25 AM, K Prateek Nayak wrote: > @@ -6649,6 +6676,9 @@ find_proxy_task(struct rq *rq, struct task_struct *donor, struct rq_flags *rf) > return owner; > } > #else /* SCHED_PROXY_EXEC */ > +bool is_proxy_task(struct task_struct *p) { return false; } > +static inline void set_task_proxy(struct task_struct *p) { } > +static inline void clear_task_proxy(p) { } I clearly messed that up for !CONFIG_SCHED_PROXY_EXEC diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 765365b81b12..d51c35e26d80 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6682,7 +6682,7 @@ find_proxy_task(struct rq *rq, struct task_struct *donor, struct rq_flags *rf) #else /* SCHED_PROXY_EXEC */ bool is_proxy_task(struct task_struct *p) { return false; } static inline void set_task_proxy(struct task_struct *p) { } -static inline void clear_task_proxy(p) { } +static inline void clear_task_proxy(struct task_struct *p) { } static bool __proxy_deactivate(struct rq *rq, struct task_struct *donor) { return false; } static struct task_struct * find_proxy_task(struct rq *rq, struct task_struct *donor, struct rq_flags *rf) > static struct task_struct * > find_proxy_task(struct rq *rq, struct task_struct *donor, struct rq_flags *rf) > { -- Thanks and Regards, Prateek