From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A0352D6E44 for ; Fri, 28 Nov 2025 04:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764303127; cv=none; b=UvYzxWYwOxCYRN/OWrSgZvo9II4n55vBDsjDL/b+zLI9pUraAFzkEPxZdNOLIGqCk/tnRqD+gXNexkxI85FNA2k0JSKULECdZo/5Ne/pcdMzIC6mCtTqhlWRtDyECinQKPFQuZQuLMvA+1MeAAUO5fT0RbrPurg51Wc9oAxfmLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764303127; c=relaxed/simple; bh=1OkvqsnuHvvKMtxEdIDU0jBVTCmEE/rE0VnSDZkSX60=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=LbDQwpDxB/s3SUV42mcoTsFUJ/KPgNwVCo9eEc5vK04YrDSev3BYkpZvzP6LVCmOpijkUo1qo3TgcS7V9BMk67i9WlUx/GcKHh6wnAl8l6VkHf2Knw6ebkNjntq/UpDJsarMl5iPckl7f3X39mx67kr4QdozAhzMmE/ibvfftIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QOa1UOKH; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QOa1UOKH" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-297ea4c2933so1574795ad.0 for ; Thu, 27 Nov 2025 20:12:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764303125; x=1764907925; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Zh2ZhVb3HKdajlhfDvy/KK05hekc0IF7Em5Uv94QADo=; b=QOa1UOKHPGiUKjc4S+1v0vplO0gDx9obBRuscQvMvZLRxkVBhCyrl8nar8Pjg0erM4 Cf0Z/s0ueUpG8/YeLrnfmAEZXEvRFk3W8VLlBd9sg8fq5PzCFogX/hn9vg5gi9rJo9f+ IgwpB/4gRKIa2C5Pa2IcWGS7/WJNgruTpZts/fgDZ+b472UNiL31HOBH6m5Mrnmbv12y ZyrKxiwCO1pcf5QAUSQTbNgunWCFJOJ0+a5U/jaAQD+IrctIJRtX2FibW1ddekSkakBb UqH3xGajciTfqdSdb61mz+InNI6P5zNwF82l/AFnhbuzZejKOURtUbTkuL9Ffo71pKXn L62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764303125; x=1764907925; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zh2ZhVb3HKdajlhfDvy/KK05hekc0IF7Em5Uv94QADo=; b=XNEa9avCtu50evjXGPQJ8KKQCdWV99B5twQJjRns0L9p2EFwx+PDfQmdqGyeo+5Va3 vDxxWm+u9+E17ZGbYp7M8ezvDGmT2JH2XPU38HNPeAIKGAxe7tNUdZCPTeEfl5gF4Phz /NqSxR21pNfw6vnOsuhbRpSKDET9GhNpMSHT7WkPof9QIPxV5gpq4yPby5AFNsPlkGL5 EbGhDiD619RTHbpdL9yDGM6hsBpdP9IEI6e2UZu/gcZ3VF3w90ieBTl+/3RvKv7m83KO skVZQxVi20EvnnEAvmoht0adBXg7GWqX7gYg+Mk2CmuYTRJb6JkMZBKcpwJkPf5jq1bO 5DcQ== X-Forwarded-Encrypted: i=1; AJvYcCWB9mRlPLSwtBDVvqWfArZa1N2SfJuxYV0diDq7ilbtg2149EFOyM4jSQNrTWnLpSO/9+9mVcXDOPbqhgg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/eBjzk9nhsAXMYqWUnk1DW5E/B9B4g/ST9gIltyLrkcbhHICk ZsKMSXyBx1zfq+jY5bCOgb7/jHwT7/HllJS2Ri48C6h0DPeQhdtO3koC X-Gm-Gg: ASbGncu6KLYZ076BEBS6wFt5QJXnSFz4ZpdhK3/xRyAZ9976oaCug8CloqJUxd90mlr TIW8yv1Ajb8mk8uFhcZM5fuIljpzrCc8LPyrPNdGG/Hu78ii9WPGx7xdx+MGSeNFw9qYz0XrFYF Xfh+K2aHhzO6dvilMvRbqGO0KthaTKSgfSBOhBH7mNWiDZRpur75xr99XoqCa6YTRfVRHi8edsk xAJ9hxzJ5edHY+DcixYBJtuLdyaUy08wmRr/w7SadXnD8n1KJXg4dro65ph4bCjkV9tdK5a2cAf +ji9nD1o4s2B0AhdRDK4DgwnC5hCiwKkkW1zOLtXiyzRnUzVvTrclmgICvIMtvC1hHQyx+FF/7l pVK1N2pffbe7z/+F49gsLKjyqlUpCR1UQNPUDenNjHZ6kJPduPOI/tajIKGH+ZBJr9AkfdW6R0H P44/9id/S4YUWFwJ0GUdZrKX5S X-Google-Smtp-Source: AGHT+IGz6a7BqLZK9rwwKjC8VIcpixC76pih5ajsSv8w8cggc9y//rlM6htS2MH52W2TF9bXc/KI2g== X-Received: by 2002:a17:903:1b05:b0:295:70b1:edd6 with SMTP id d9443c01a7336-29b6beae519mr177542275ad.3.1764303125334; Thu, 27 Nov 2025 20:12:05 -0800 (PST) Received: from [192.168.1.13] ([45.144.167.102]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce478762sm30721415ad.45.2025.11.27.20.12.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 20:12:05 -0800 (PST) Message-ID: <4c96af12-cf44-4028-b3c4-4ce9314c4733@gmail.com> Date: Fri, 28 Nov 2025 12:11:59 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Sun Yangkai Subject: Re: [PATCH next] btrfs: tests: Fix double free in remove_extent_ref() To: Dan Carpenter Cc: Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks. My bad. 在 2025/11/27 15:14, Dan Carpenter 写道: > We converted this code to use auto free cleanup.h magic but one old > school free was accidentally left behind which leads to a double free > bug. > > Fixes: a320476ca8a3 ("btrfs: tests: do trivial BTRFS_PATH_AUTO_FREE conversions") > Signed-off-by: Dan Carpenter > --- > fs/btrfs/tests/qgroup-tests.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/btrfs/tests/qgroup-tests.c b/fs/btrfs/tests/qgroup-tests.c > index 05cfda8af422..e9124605974b 100644 > --- a/fs/btrfs/tests/qgroup-tests.c > +++ b/fs/btrfs/tests/qgroup-tests.c > @@ -187,7 +187,6 @@ static int remove_extent_ref(struct btrfs_root *root, u64 bytenr, > ret = btrfs_search_slot(&trans, root, &key, path, -1, 1); > if (ret) { > test_err("couldn't find backref %d", ret); > - btrfs_free_path(path); > return ret; > } > btrfs_del_item(&trans, root, path);