From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68F3F186E45 for ; Mon, 15 Jul 2024 09:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721036148; cv=none; b=gYWoIM/Ubtt+qaTf59zkbHRThKD0EjFUSPFhA3tbEavbWpCzwcV4Fk1o7PU8nWWhcRNQiOF3GaD2XRB2M/eTF+qePInis2J7et0pP5ry6XoJ0118s+BcmK9bT3Qh77y79SXrnrKxnpJ2OBI8lptg25W66Pa8wI2UNx5jMDKbtrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721036148; c=relaxed/simple; bh=GtopQRhjZdMqhoKajS2b1Ym6+Lvaw07qvkz4JVuKQws=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Jek0f9nYERYAS8nvu80ntO9iD/CE8JfuwXXPeno7/W9PUPg9up+V1Wv5LzKhqBMgqRapIOEtKqckNCSY66mbm5/voyq/qMOaEtb+pvgbH0n4KPXjaHC3PQHRquvsrlS75fK1fcIuScCb7YTXrx8txSf6VMAGIYS8QD9hnDRCOz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nhhEvc/T; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nhhEvc/T" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42797bcfc77so28114685e9.2 for ; Mon, 15 Jul 2024 02:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721036145; x=1721640945; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=xQ1DhT4B9bBhDkM5rVQR/SCRZNGVnk+OTdpMykcWYyI=; b=nhhEvc/T2z/x+qae455nz98rNR5Ho6S5ftw4R9hvq1uswR516U3WvIaVqCHPuUgIo1 aJ00OsO2P+T0/WLBdP/nGK4ruHIznOytVfjdAz1L5Uvcp40OU8kgUciq1M4S4N1JYoqv D+Wx/DtYRQHNKNmfe4BCW+YoJUMUaJVqgRXowukiiVzzlsw048mZY31aTXi9IFJn02qG B/qHL3I+CzebD6Q12Owl3dXhA1ascHmXN7/eWhzl8tLKEi2NwGbEBJxdCimo4PlBxQRz p3ZWEBLq1Vc49BK5zzuHkaSD+MQ402f/1WWTyLyqk16W53iNGv5uiE22ZZhf/7tiLP0p NN0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721036145; x=1721640945; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xQ1DhT4B9bBhDkM5rVQR/SCRZNGVnk+OTdpMykcWYyI=; b=F85y5fRSHQsMcfrztb8D6MR/EYwN27nOeUdgvMM2CmmEY6GhTNGrY0baeIhATK2If0 d83xDmMjvCqyfhJYh7WkaUprk1HtlmAEE/NC1XVFtwkUZWweSfhuTNpLSfKd/j97drCP YvHNr+B1aRItAiN4NLxyH0lwLDuF4u06+8EVynxz2quj7Ga7Vhndd1S4c8AxXHgHiEH5 0btwRXm7UwzxNfYFTmSv3DrQXCf9OG3nOcu8j5TPzXQd2cT1YyWxd6hKyOsdk9RlibXc 71S0V2Hvb8p6ZXX6hEw/kZM73BN1J40CqavWJrdhpAwNIdHpgDqSTFLQCvspA/VuO9L6 /DBw== X-Forwarded-Encrypted: i=1; AJvYcCUBQV/5MW0UtJgy3Fn/aWpAnyVEXhxPEJgNXMN1WsdsBL+WasQwYUOm3YDiMOfzq9H4Dn35oVgRWwNzY5oEuHq7MQnoFpdnttn7Y5a0 X-Gm-Message-State: AOJu0YzkfD7DHo44euurf7I02p1etxLjgvrPif0tsBU/0fYiSfW08AcE au9v6MEKGyy6YMfaJkFDV3/9BMfN8RuW6mpGzPngwW/OUTb/lQPzXkDbGxErmlk= X-Google-Smtp-Source: AGHT+IEt2AE9k6+sApK/lAECqtaxkEYJCVi+Z3txvGNNUUQRB7EkyuITgT3naxj0GhwrPFnDxH3P4A== X-Received: by 2002:a05:600c:33a1:b0:426:62c6:4341 with SMTP id 5b1f17b1804b1-426707e3578mr109924655e9.20.1721036144721; Mon, 15 Jul 2024 02:35:44 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e8266asm78927275e9.13.2024.07.15.02.35.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 02:35:44 -0700 (PDT) Message-ID: <4c9a1e2d-2515-4f38-a316-960dee100fbd@linaro.org> Date: Mon, 15 Jul 2024 10:35:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 00/10] perf tools: Fix test "perf probe of function from different CU" From: James Clark To: Chaitanya S Prakash , linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Ian Rogers , Namhyung Kim Cc: anshuman.khandual@arm.com, Josh Poimboeuf , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Chenyuan Mi , Masami Hiramatsu , Ravi Bangoria , =?UTF-8?Q?Ahelenia_Ziemia=C5=84ska?= , Colin Ian King , Changbin Du , Kan Liang , Athira Rajeev , Tiezhu Yang , Alexey Dobriyan , =?UTF-8?Q?Georg_M=C3=BCller?= , Liam Howlett , bpf@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar References: <20240601125946.1741414-1-ChaitanyaS.Prakash@arm.com> <65aaf9bb-ab2c-4185-b5bb-22a717ac7e73@arm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/07/2024 10:34 am, James Clark wrote: > > > On 10/07/2024 8:39 am, Chaitanya S Prakash wrote: >> Gentle ping, are there any updates on the string clean up patch set? >> >> On 6/1/24 18:29, Chaitanya S Prakash wrote: >>> From: Chaitanya S Prakash >>> >>> Perf treated all files beginning with "/tmp/perf-" as a map file despite >>> them always ending in ".map", this caused the test "perf probe of >>> function from different CU" to fail when Perf was built with NO_DWARF=1. >>> As the file was parsed as a map file, the probe...--funcs command output >>> garbage values instead of listing the functions in the binary. After >>> fixing the issue an additional check to test the output of the >>> probe...--funcs command has been added. >>> >>> Additionally, various functions within the codebase have been refactored >>> and restructured. The definition of str_has_suffix() has been adopted >>> from tools/bpf/bpftool/gen.c and added to tools/lib/string.c in an >>> attempt to make the function more generic. The implementation has been >>> retained but the return values have been modified to resemble that of >>> str_has_prefix(), i.e., return strlen(suffix) on success and 0 on >>> failure. In light of the new addition, "ends_with()", a locally defined >>> function used for checking if a string had a given suffix has been >>> deleted and str_has_suffix() has replaced its usage. A call to >>> strtailcmp() has also been replaced as str_has_suffix() seemed more >>> suited for that particular use case. >>> >>> Finally str_has_prefix() is adopted from the kernel and is added to >>> tools/lib/string.c, following which strstarts() is deleted and its use >>> has been replaced with str_has_prefix(). >>> >>> This patch series has been tested on 6.10-rc1 mainline kernel, both on >>> arm64 and x86 platforms. >>> >>> Changes in V3: >>> >>> - Patch adding configs required by "perf probe of function from >>> different >>>    CU" was originally part of the series but has been merged in >>> 6.10-rc1. >>> https://github.com/torvalds/linux/commit/6b718ac6874c2233b8dec369a8a377d6c5b638e6 >>> >>> - Restructure patches according to the maintainer trees. >>> - Add explanation for why '| grep "foo"' is used. >>> - Fix build errors for when perf is built with LLVM=1. >>> >>> Changes in V2: >>> https://lore.kernel.org/all/20240408062230.1949882-1-ChaitanyaS.Prakash@arm.com/ >>> >>> - Add str_has_suffix() and str_has_prefix() to tools/lib/string.c >>> - Delete ends_with() and replace its usage with str_has_suffix() >>> - Replace an instance of strtailcmp() with str_has_suffix() >>> - Delete strstarts() from tools/include/linux/string.h and replace its >>>    usage with str_has_prefix() >>> >>> Changes in V1: >>> https://lore.kernel.org/all/20240220042957.2022391-1-ChaitanyaS.Prakash@arm.com/ >>> >>> Cc: Josh Poimboeuf >>> Cc: Peter Zijlstra >>> Cc: Suzuki K Poulose >>> Cc: Mike Leach >>> Cc: James Clark >>> Cc: John Garry >>> Cc: Will Deacon >>> Cc: Leo Yan >>> Cc: Ingo Molnar >>> Cc: Arnaldo Carvalho de Melo >>> Cc: Namhyung Kim >>> Cc: Mark Rutland >>> Cc: Alexander Shishkin >>> Cc: Jiri Olsa >>> Cc: Ian Rogers >>> Cc: Adrian Hunter >>> Cc: Chenyuan Mi >>> Cc: Masami Hiramatsu >>> Cc: Ravi Bangoria >>> Cc: Ahelenia Ziemiańska >>> Cc: Colin Ian King >>> Cc: Changbin Du >>> Cc: Kan Liang >>> Cc: Athira Rajeev >>> Cc: Tiezhu Yang >>> Cc: Alexey Dobriyan >>> Cc: Georg Müller >>> Cc: Liam Howlett >>> Cc: bpf@vger.kernel.org >>> Cc: coresight@lists.linaro.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: linux-perf-users@vger.kernel.org >>> >>> Chaitanya S Prakash (10): >>>    tools lib: adopt str_has_suffix() from bpftool/gen.c > > LGTM, > > Reviewed-by: James Clark > > The below commit looked like it could be prone to an off by one error > but I debugged it to confirm that it's ok: > >>>    perf util: Delete ends_with() and replace its use with >>>      str_has_suffix() > There were some trivial merge conflicts though, so I'm not sure if it's worth sending a new version out or not. >>>    perf util: Replace an instance of strtailcmp() by str_has_suffix() >>>    tools lib: Adopt str_has_prefix() from kernel >>>    libsubcmd: Replace strstarts() usage with str_has_prefix() >>>    objtool: Replace strstarts() usage with str_has_prefix() >>>    perf tools: Replace strstarts() usage with str_has_prefix() >>>    tools lib: Remove strstarts() as all its usecases have been replaced >>>      by str_has_prefix() >>>    perf tools: Only treat files as map files when they have the >>> extension >>>      .map >>>    perf test: Check output of the probe ... --funcs command >>> >>>   tools/include/linux/string.h                  | 12 ++--- >>>   tools/lib/string.c                            | 48 +++++++++++++++++++ >>>   tools/lib/subcmd/help.c                       |  2 +- >>>   tools/lib/subcmd/parse-options.c              | 18 +++---- >>>   tools/objtool/check.c                         |  2 +- >>>   tools/perf/arch/arm/util/pmu.c                |  4 +- >>>   tools/perf/arch/x86/annotate/instructions.c   | 14 +++--- >>>   tools/perf/arch/x86/util/env.c                |  2 +- >>>   tools/perf/builtin-c2c.c                      |  4 +- >>>   tools/perf/builtin-config.c                   |  2 +- >>>   tools/perf/builtin-daemon.c                   |  2 +- >>>   tools/perf/builtin-ftrace.c                   |  2 +- >>>   tools/perf/builtin-help.c                     |  6 +-- >>>   tools/perf/builtin-kmem.c                     |  2 +- >>>   tools/perf/builtin-kvm.c                      | 14 +++--- >>>   tools/perf/builtin-kwork.c                    | 10 ++-- >>>   tools/perf/builtin-lock.c                     |  6 +-- >>>   tools/perf/builtin-mem.c                      |  4 +- >>>   tools/perf/builtin-sched.c                    |  6 +-- >>>   tools/perf/builtin-script.c                   | 30 ++++-------- >>>   tools/perf/builtin-stat.c                     |  4 +- >>>   tools/perf/builtin-timechart.c                |  2 +- >>>   tools/perf/builtin-trace.c                    |  6 +-- >>>   tools/perf/perf.c                             | 12 ++--- >>>   .../shell/test_uprobe_from_different_cu.sh    |  2 +- >>>   tools/perf/tests/symbols.c                    |  2 +- >>>   tools/perf/ui/browser.c                       |  2 +- >>>   tools/perf/ui/browsers/scripts.c              |  2 +- >>>   tools/perf/ui/stdio/hist.c                    |  2 +- >>>   tools/perf/util/amd-sample-raw.c              |  4 +- >>>   tools/perf/util/annotate.c                    |  2 +- >>>   tools/perf/util/callchain.c                   |  2 +- >>>   tools/perf/util/config.c                      | 12 ++--- >>>   tools/perf/util/map.c                         |  8 ++-- >>>   tools/perf/util/pmus.c                        |  2 +- >>>   tools/perf/util/probe-event.c                 |  2 +- >>>   tools/perf/util/sample-raw.c                  |  2 +- >>>   tools/perf/util/symbol-elf.c                  |  4 +- >>>   tools/perf/util/symbol.c                      |  3 +- >>>   39 files changed, 148 insertions(+), 117 deletions(-) >>> >>