From: Frederic Barrat <fbarrat@linux.ibm.com>
To: zhong jiang <zhongjiang@huawei.com>, gregkh@linuxfoundation.org
Cc: andrew.donnellan@au1.ibm.com, fbarrat@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference
Date: Thu, 4 Oct 2018 13:48:07 +0200 [thread overview]
Message-ID: <4c9c229b-d1ea-580e-1204-a8496fe2e4df@linux.ibm.com> (raw)
In-Reply-To: <1538629373-33217-1-git-send-email-zhongjiang@huawei.com>
Le 04/10/2018 à 07:02, zhong jiang a écrit :
> It is not safe to dereference an object before a null test. It is
> not needed and just remove them. Ftrace can be used instead.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/cxl/guest.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..5d28d9e 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,8 +1018,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>
> void cxl_guest_remove_afu(struct cxl_afu *afu)
> {
> - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> -
> if (!afu)
> return;
>
next prev parent reply other threads:[~2018-10-04 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 5:02 zhong jiang
2018-10-04 11:48 ` Frederic Barrat [this message]
2018-10-04 11:59 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c9c229b-d1ea-580e-1204-a8496fe2e4df@linux.ibm.com \
--to=fbarrat@linux.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®