From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: David Carlier <devnexen@gmail.com>, akpm <akpm@linux-foundation.org>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ocfs2: use get_random_u32() where appropriate
Date: Tue, 7 Apr 2026 09:57:26 +0800 [thread overview]
Message-ID: <4ca39fb7-a927-4657-b526-aa2587eac56d@linux.alibaba.com> (raw)
In-Reply-To: <20260405154720.4732-1-devnexen@gmail.com>
On 4/5/26 11:47 PM, David Carlier wrote:
> Use the typed random integer helpers instead of
> get_random_bytes() when filling a single integer variable.
> The helpers return the value directly, require no pointer
> or size argument, and better express intent.
>
> Signed-off-by: David Carlier <devnexen@gmail.com>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index d7c58fd7d438..b875f01c9756 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2124,7 +2124,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
> osb->osb_cluster_stack[0] = '\0';
> }
>
> - get_random_bytes(&osb->s_next_generation, sizeof(u32));
> + osb->s_next_generation = get_random_u32();
>
> /*
> * FIXME
prev parent reply other threads:[~2026-04-07 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 15:47 David Carlier
2026-04-07 1:57 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca39fb7-a927-4657-b526-aa2587eac56d@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=devnexen@gmail.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®