From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0114DC433E2 for ; Sat, 6 Jun 2020 04:57:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D466620723 for ; Sat, 6 Jun 2020 04:57:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="SvoXuSTI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgFFE5Q (ORCPT ); Sat, 6 Jun 2020 00:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgFFE5O (ORCPT ); Sat, 6 Jun 2020 00:57:14 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B59F3C08C5C4 for ; Fri, 5 Jun 2020 21:57:14 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id s10so6176044pgm.0 for ; Fri, 05 Jun 2020 21:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=AEeRqD/NorCUJBTa2b+IUYMUvQuNtNDzhJImkhNUMwE=; b=SvoXuSTIYbKCNLm3Rf+7U72DNelud+4d639oZBnjG8U23K7zlLH+w3p8CEs0PTD2dU Ja/nHOz6XUh0DjZ6xs6ZDwhhVtT0L8oSWdBRiKcSbDENa6K2+KVDoCZHJi5Hkz1nc1ai gDR8glzNryBj5xK1fylPWU9yiBhf+Lc+RZRZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AEeRqD/NorCUJBTa2b+IUYMUvQuNtNDzhJImkhNUMwE=; b=ukcpkSksuL0qGg2/iowImDsE/2cX2YewO0qaN/3FS9bI78spciAh7fR8sWrVv39M7i llytNF6Dr8PVfyO9QDMNM0J/XapUJRwj64kixNSag6yZMYItQ6lJxKHnwDdRFrrOEsu2 TfE/LsBu9avubAA+pmVjhV4xORJOkHuLraV58wM1cKZNWaWiWayFMKzoJU+1UsVxb1lv 4vkwZyHiIXNfSG0Chlpqbu8ehg2FXeb7Bax7QoG3z1TJcQ8fA47DbFuZKjri7H50OS5z HSi6yM5IiPJZIMGk/4dxijD956xO6dgjeCWlE/yyK1YyCBE558rCG34aSG4ptboRazv2 E/6Q== X-Gm-Message-State: AOAM532wLoGY+fcRxqDt6ouyCKpRP84H+3zq4tG1cHjSl2jOdZYdnnno tJgioJX5BaoxuRb/gyagJHhX5Q== X-Google-Smtp-Source: ABdhPJy1OnrZSXjJCECuXBSjTznNT2AEnf7+8B0WVOWyttYt253hWfCVsp/i4j2CztKv6MOa13rY4Q== X-Received: by 2002:a63:ce0d:: with SMTP id y13mr12145554pgf.90.1591419433926; Fri, 05 Jun 2020 21:57:13 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id k126sm1088049pfd.129.2020.06.05.21.57.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2020 21:57:12 -0700 (PDT) Subject: Re: [PATCH v6 1/8] fs: introduce kernel_pread_file* support To: Matthew Wilcox Cc: Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , Mimi Zohar , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200605225959.12424-1-scott.branden@broadcom.com> <20200605225959.12424-2-scott.branden@broadcom.com> <20200606032011.GM19604@bombadil.infradead.org> From: Scott Branden Message-ID: <4ca91507-90a5-1a99-ab19-c6782423e870@broadcom.com> Date: Fri, 5 Jun 2020 21:56:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200606032011.GM19604@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, On 2020-06-05 8:20 p.m., Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 03:59:52PM -0700, Scott Branden wrote: >> -int kernel_read_file(struct file *file, void **buf, loff_t *size, >> - loff_t max_size, enum kernel_read_file_id id) >> -{ >> - loff_t i_size, pos; >> +int kernel_pread_file(struct file *file, void **buf, loff_t *size, >> + loff_t pos, loff_t max_size, >> + enum kernel_pread_opt opt, >> + enum kernel_read_file_id id) > What is this 'kernel_pread_opt' foolishness? Why not just pass in > ~0UL as max_size if you want the entire file? That is not how existing kernel_read_file api works - max_size is specified. I guess not everyone has unlimited memory to read a file on any size. > >> -int kernel_read_file_from_path_initns(const char *path, void **buf, >> - loff_t *size, loff_t max_size, >> - enum kernel_read_file_id id) >> +extern int kernel_pread_file_from_path_initns(const char *path, void **buf, > extern? really? i'm shocked gcc doesn't vomit on that. A typo.  thanks.  You'll have to ask the compiler gods about your shock.