From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbdJWUFP (ORCPT ); Mon, 23 Oct 2017 16:05:15 -0400 Received: from mail-bl2nam02on0063.outbound.protection.outlook.com ([104.47.38.63]:20645 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750835AbdJWUFM (ORCPT ); Mon, 23 Oct 2017 16:05:12 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v6 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171020023413.122280-1-brijesh.singh@amd.com> <20171020023413.122280-14-brijesh.singh@amd.com> <20171023073429.GA10952@nazgul.tnic> From: Brijesh Singh Message-ID: <4cad8c97-91e4-9358-ed6c-b69847436a13@amd.com> Date: Mon, 23 Oct 2017 15:05:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023073429.GA10952@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR1101CA0007.namprd11.prod.outlook.com (10.174.246.17) To SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87df4c71-7098-4e9f-09b6-08d51a515d2c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:SN1PR12MB0157; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;3:sTMzcKh3XuzH7RcOjFXAbJnXnM+1xV1XUgu+izSzyqwj0Lbd3QiubjKkJRTrsim+bLvxWKHX9KDDoD3JWp6Hlf4OXnXAkSdQ4FW8V/u+mkrltOSENZK4jW3fT6OQ6MTg5DVBT6rKvR7v7g2/I3CO3e7iAsU/Ua1QZi+diAkhZYl9kUyq3krxjgD+PHwP/TJv7cmvLcBRR+bn0llkE6E0Gdq8Dmzhft8J6JMd16DEh3dUBi3BDgEzAmpzexajd+HI;25:ECJ4g49NxLH5hmrfw6KctXi5DbGaG8gfV1JOIk55XWTlDs0a7bXxl0MZvAbpFcUYKKEHZ40jtc3aq7j/qxJFhCG+kIh0tNnypDr/Vrd3r1OPI3YD7qUu5yOFyFOArhEKxl4MnakkYdWRb0EKvRPqhelA1VNz8i4kFHvwLiB1+qO45xp0qsvU560HJwUIhIFsecrOU8rnAXMW9iKPzsxbtPrZR4K1PeDeRIcMXMLQp++BCZG2GY0GejA32GmmgbkFCAUE2IH/8qtGPPaoLsspwnRpuIzUl/SBENLMHoTsXnQtUNfYarijZ+llN4Rh4J6kjn+APTJ0nsB985Cfu044kA==;31:bYQxybsQoRGeqToAnmrKgkZC/mG6oihmAk6bQbuIU5uYaKUXL1wGxwEZNPa7x9DwaAabqiARAI7h1nh9DFUuP0Rn7X1D6TdcxA/UWL1fslhANP3U5nXC4mo3lz0XPMHwOIHybttGQ82OpmLp3V1iojTxX5aBVNCWWUJrFtJPlmxGiq2SSPCeSI/D3mnFfBqTCFc4EczpLljslXea2dkR+1KWbLcskSIztq34P7O1NLc= X-MS-TrafficTypeDiagnostic: SN1PR12MB0157: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;20:XjF3T7CVabgwA4uOG91VwogqwGcXThqzA0vZ5yco4Uv01UWV+3Q8SeZqvl1IkH/qYCH4cp+yubPGiqVS1ERd7gFhkBbaRLkY22kz1dNLL0XbqvJnopkjiCKDfA+DCOUXSkN12ZXWYewbUK9SXIXJw41WdP/gBu2N4SHfhL7Rv7NBubnCPQU33htb+GATFPgDzCOm62AeoxUUIworhJiCC6+Uddd4qZ44AbwuN/VM7dtuT6Ev7/egTLO/esahvlTrDGm4ZPvSi0zYbfcIzo71/E0Ep7Lu5IhjXSwz9LxrUgKvKbo4KumiQw4+ZHowtSz+QcKQvc08VMMGFy1nFFenXOt2UpSa5hinvJUOkdIA7+6S8nVzm94zZOBPeRUS37OpnGmbPo2tG4EfF7f9qXNqRAMWXikbcpazPVZWqSoeoADV5QHxD7IHobBkXQY2Y5787pMWkOfjF4tT+yRC1P+TdrifPr77KWYxRa8cmbFl9WiRkx6FNRpL3o631qsXTUn5;4:2SgaeQFIhwUZYSQeJDQ3LxpsYDMikjx0pj5wcr2cgA2kMUV26h0KkIMVhScKDy58p1iRkJBWMM+/BJXRItkqY0h2rmLpzvmd6ZZQEpxT5LpWouHFi1954/JSiuZO+1jegD0cU2pW4d8jbMG1BThb0G2OYyY68zaxhYmoBwv3vJG8JtSi+kw1Qa74VGmOWYjlu4F+3WsroqHSE3BU3+fQfuleQ6l8KrBjaSlcQe0IAyMgZUVX6SVe6KRF5Oa9pftq X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(3231020)(6055026)(6041248)(20161123558100)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0157;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0157; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(346002)(39860400002)(24454002)(189002)(199003)(7736002)(97736004)(230700001)(36756003)(54356999)(50986999)(76176999)(316002)(189998001)(6116002)(101416001)(106356001)(8936002)(16526018)(229853002)(64126003)(8676002)(3846002)(16576012)(50466002)(6486002)(25786009)(6246003)(77096006)(90366009)(81156014)(81166006)(33646002)(4326008)(68736007)(65826007)(31696002)(5660300001)(65806001)(83506002)(47776003)(2950100002)(31686004)(6916009)(86362001)(66066001)(305945005)(23676002)(53546010)(58126008)(65956001)(2906002)(6666003)(105586002)(54906003)(53936002)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0157;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU3OzIzOitsdmJpNEVuNjNycFJxMW9uNWdFc3ZsSU9v?= =?utf-8?B?d1hmQmxsSDFhQ3RPcXM4NzZ6d2dzV3A3WDlkU1hReG8wMjRYVkVMQ2VFRkVT?= =?utf-8?B?STBaMUxLc3VlZU1PaHN5bEttdlEzNjkyVThDVVZhSmtseDV3RHVkR0hmOE8x?= =?utf-8?B?Vk9pd05qUVkwWXNuZmJGdjhHZC82enlPQ1FDenlyNjcybGxwUDJQT3FubGVC?= =?utf-8?B?aFJUWmRBNXBHbmRWT2RoY0Vrbm10ZVpyeURIQ1U0MjFoNU9ubm9EUFBsZmRU?= =?utf-8?B?UllLN00xUjl1U044TnMrWXJmQm5iWDYyMjMzaGI1L2oyZ1hqcTh6bmY3cldL?= =?utf-8?B?WU1rWjN2NWZ4c1JnMXRNRzArSTkweDJGNXVkT25JVnhPWU01Y28xWDM4QWZQ?= =?utf-8?B?ZWVjVTJ2bmQ1eThjcndPd2JNNE5WdTh2SDU0cWhXSEZXSjNmZWNjVCt0dzZ5?= =?utf-8?B?Y0NydnIyMVpmT3psNXhDck96MFZPeUZYSXh0TmFrcUg5bkhiMWJ4UlYyY1hX?= =?utf-8?B?dnVBdy9TOVJPcXV6NWo3eEk3MWFRZHY3bFo4MTdKbWVFdkZ6SDlxdjRWRkEz?= =?utf-8?B?dWRXbXBkY0hES1VjcTcvWmgwWUlBNkJkK3RHOVBhK0xwTDI3UFMyZ1RpWmdo?= =?utf-8?B?TGNMUFpaNm9hY294QjB0Vlh3OCtHcTJxRTM0aFBBUlFRbGxLcUNkWVUwUHl2?= =?utf-8?B?TDUxTHplSjBtbW9WUHZFaHI2S1l2VURsMEdaUFpBQ0x2SnZLODlsSDhaaFJU?= =?utf-8?B?T3UvemtRS0tCY28wMkNPYTZ6bzdCWEVaVnFuaHJ4aW1SYmJNMi9qVUNEL25z?= =?utf-8?B?OVBXN3hjZW4zRkJqb3RSYWJKejVCS2ZxMnU5RUJZTFE4MUJWcW14RzR5YkNZ?= =?utf-8?B?bjJvVXJLbVR1MGM3MHc2dUxScGxjMzBMRkxGc3Vkd2szZ1BQbnlSUi9yUUxU?= =?utf-8?B?bjFSZUtrUVQxcjFXekpTRjkzQ0FUSkNFTGsvQmFvdHZqTnFjaTM2Vnp0MmZu?= =?utf-8?B?WVZYUlIyT29XOE5ZaXhaRkNqaURRUGFraWZJZHFEcEM5UHBFNDZsbCtjRCtF?= =?utf-8?B?RnRTdWczNUNMUjFkZnVJamovQ28wbmt5RjU0cG0zRkk4dWpkU2FkbDJDSnYx?= =?utf-8?B?RytOTXhSWkxUb2pjQjhsMzBNZTJYZk9Ma0plNGgvMHdoTlVXRFdpa0pNWjZi?= =?utf-8?B?VnZvTmJlbUFjS0xNVm8yaitnMWNnVEd6Y05scFZmZnhZamRQMWxGOUxoTGhz?= =?utf-8?B?NTZjcDFMbWl6UjE4N2l5eG5Pd1dxVW5FUEVNUTZOaXEraG1sNG1DNENiT3dI?= =?utf-8?B?RzdGbUszcXM5MkhtYTNUeGJuR3VuL0tsSWduNCtnQjlqTXE0VzZtTW1aak1H?= =?utf-8?B?MFZmWU5WUFRHd2hmNVZ3S3gwSWo3c3pYMkFKVzFGR1Q4ODRBSEZUUHJKYm9L?= =?utf-8?B?dHcybGdjR3NGUVR1cnF2a3RMTHdJWlBXR254M2dNLytLbUhpejE3SjBqOHU3?= =?utf-8?B?R0E2N2FSejhZSDkrQjQ3dUFYVm5UQjBRUEJoQkZsbWI4OGtjeUVwWStyOFFi?= =?utf-8?B?K2RjQktRR3BGTEF4QVl1MUJRME9scXNVemd1TERTQ2FSQ3kxWkFydmRRZUJM?= =?utf-8?B?OHd6aUdtS09lV1dEWFNJbmY1WVo1MXhRYjBWdHBBcW1iLzhPbzhWVlducFhE?= =?utf-8?B?ckFUaG1qWk92NVp0aGdEdVdUeUp3QXBrbldTWlkzNHVJM3N2bUF3Vkx5Ukc1?= =?utf-8?B?VFVKN2NEeWY1TnA5QmZSTWJFU3c1VU9nUytnaitrcFVrUFgvNFNOTGdUNW1v?= =?utf-8?B?T2lDN3h2RGZMYzYxZDlhdHlURVAxbWlBV0k4SVh1aXV6azhoYkRHdjVaZGlq?= =?utf-8?Q?8oCoTwckoUE=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;6:tc9xpv2CsTlxgZouGUzJid3HFKfOiN/+MmbGE5iKVKi4gAmiAVTau/Jd6Nd2FYuq8FvsMiwkBWPgNJJbRVKJ8DnkFoM5tzlHxR9rBXzF5EXxmU74ivLS6n42GrV4ke1zm+tzeEyyvXL3fVUFP7DDmW6lCgA0aRDAHKSJpgHWtrX3i0dbpMs8HJtEfYQpTCu1Nk/MhaE72MtAIO607RM1cklUUeLPUD2OEz4Hq1cV8sB8bVr27uVv7msiQipgCCp8WYUIiD+nGEHT54cFjigOyqm6x7Mt9xP6a2mo90nuFJpZQ5UW+A7nLcDIxBLqMs0QetcBU7o5q+vp3h7Eo4ArYg==;5:KUfYrCEour1uiePcaVuyeCWynvSp4nuS/RBNs9d5OM0Qb9FhDkQMbkXums3i55VVRsRWsecUcrXdN+obSba52go9xcbhmRmb+aSd8ocOotbFjSoT+bTfAyahI1WTvb89YCLbK93s6hHdsHAQaTeqxQ==;24:w4byhFc69pFgc2FC0W04dizvWRyleoqunBcWFL2SomBkoyBQLJdpCYnprVZ6L+VZ9UFn0i3wD+hxeWCqPRwFMmcn8bx7mZR5FVSnMp2J1PI=;7:EDIGwXLUJw2l/5Jv01oFORhu5JHCnys9ij+RNhnUOdoWS0inXEtr1ms6c6nitMCy99JNjUaI0DdL4M3Hi9uY32ybWLIibSfsdmgvVdZVLkDaL8l+D4bWLJjvJGDpQhrDy0HMe0UCHDVr3vLoLUn45omjNMUvMJbLftZVEnjVgG4zTCjdS4+eLD2ssQUdFpQaQutRd/p+mPvw2p5RmJ9TPmqk13Mb9YPMjEJjDyWIw4g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;20:VwCKpuFpUZLBW/q+sowsU5kzywLszGdR2ct1eCFAYxznxpwVEfxeyyAQ6Ek0+inJLJjxg01/UOKRRBMRuHSR96GX30Xl21mt55FryLlKENAGmH8zLZzjjr6YufhKvGmnLBrtj6Qa6VcoZFIuZCyQb7CVSZlIEJn1GBE1+Y0w99/IXf/Lsb7/p3dxzp1lW6sGJ76TDf9L5cDsROYtLWal8W7/cvVwPBcTAkwKsQ5GHp2EGvdPF5rjAKYXLudgtyS2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 20:05:09.1883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87df4c71-7098-4e9f-09b6-08d51a515d2c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0157 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2017 02:34 AM, Borislav Petkov wrote: ... > > Just minor cleanups: > Thanks Boris, I have applied your cleanups. -Brijesh > --- > diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c > index e9966d5fc6c4..f9a9a6e6ab99 100644 > --- a/drivers/crypto/ccp/psp-dev.c > +++ b/drivers/crypto/ccp/psp-dev.c > @@ -31,7 +31,7 @@ > static DEFINE_MUTEX(sev_cmd_mutex); > static DEFINE_MUTEX(fw_init_mutex); > > -static struct sev_misc_dev *sev_misc_dev; > +static struct sev_misc_dev *misc_dev; > static int fw_init_count; > > static struct psp_device *psp_alloc_struct(struct sp_device *sp) > @@ -299,14 +299,14 @@ static int sev_ops_init(struct psp_device *psp) > * sev_do_cmd() finds the right master device to which to issue the > * command to the firmware. > */ > - if (!sev_misc_dev) { > + if (!misc_dev) { > struct miscdevice *misc; > > - sev_misc_dev = devm_kzalloc(dev, sizeof(*sev_misc_dev), GFP_KERNEL); > - if (!sev_misc_dev) > + misc_dev = devm_kzalloc(dev, sizeof(*misc_dev), GFP_KERNEL); > + if (!misc_dev) > return -ENOMEM; > > - misc = &sev_misc_dev->misc; > + misc = &misc_dev->misc; > misc->minor = MISC_DYNAMIC_MINOR; > misc->name = DEVICE_NAME; > misc->fops = &sev_fops; > @@ -315,13 +315,13 @@ static int sev_ops_init(struct psp_device *psp) > if (ret) > return ret; > > - kref_init(&sev_misc_dev->refcount); > + kref_init(&misc_dev->refcount); > } else { > - kref_get(&sev_misc_dev->refcount); > + kref_get(&misc_dev->refcount); > } > > init_waitqueue_head(&psp->sev_int_queue); > - psp->sev_misc = sev_misc_dev; > + psp->sev_misc = misc_dev; > dev_info(dev, "registered SEV device\n"); > > return 0; > @@ -340,9 +340,9 @@ static int sev_init(struct psp_device *psp) > > static void sev_exit(struct kref *ref) > { > - struct sev_misc_dev *sev_dev = container_of(ref, struct sev_misc_dev, refcount); > + struct sev_misc_dev *misc_dev = container_of(ref, struct sev_misc_dev, refcount); > > - misc_deregister(&sev_dev->misc); > + misc_deregister(&misc_dev->misc); > } > > int psp_dev_init(struct sp_device *sp) > @@ -405,7 +405,7 @@ void psp_dev_destroy(struct sp_device *sp) > struct psp_device *psp = sp->psp_data; > > if (psp->sev_misc) > - kref_put(&sev_misc_dev->refcount, sev_exit); > + kref_put(&misc_dev->refcount, sev_exit); > > sp_free_psp_irq(sp, psp); > } > diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h > index 21511419bfe6..eac850a97610 100644 > --- a/include/linux/psp-sev.h > +++ b/include/linux/psp-sev.h > @@ -525,7 +525,7 @@ int sev_platform_shutdown(int *error); > /** > * sev_platform_status - perform SEV PLATFORM_STATUS command > * > - * @init: sev_data_status structure to be processed > + * @status: sev_user_data_status structure to be processed > * @error: SEV command return code > * > * Returns: >