From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 774B51917FB for ; Wed, 18 Mar 2026 23:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773874849; cv=none; b=BIH9M7xNFTJcgCu/NKvvz0QZQ4a9zmyBEj+s4QmS4xyXXJ5h7QkRhLQeHuNbUNl9YOBWyjS9DOej9wJpZrMhhKrmIFpzEgwLqMk1FkDYuO2EgJ3K6AF7ZyNc0Xb0LVvQGzDcKfELbVM04lcK8i/kNuPrhIWdaF4xJXmisqqEU2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773874849; c=relaxed/simple; bh=NvYYBRGAeWtKVYoN67ySXdYRyGcLlgtmbG657mYPVhg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=upCDT13nyD0LO/zwOErq1+Ep9yKkD+yLCNGUhZ06QELzWCcEZuZqX67QPL9AiQLybJk0z2F1YUfwT/sd2XVBS6EK4/VCN9bTePNjK55RsX4t6yHisv3Vypn7tgn4ejjTJBJdLIH3Jv4uL0oae3Y1/McOAt8VAn/aP2FLygKoShI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=OE8gDemK; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="OE8gDemK" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7d74aa6bcdbso247321a34.2 for ; Wed, 18 Mar 2026 16:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773874845; x=1774479645; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gXk/XAl/MQx/OXuZk0UOeHJIU6eSq8cRls/Q/FJTwAA=; b=OE8gDemKQzGDMIqqw4/3ZwA/2dH4vME+TPVVaSXxcbmtON7tpc5uPP8KPMNPFuEgDh 30LrUqeV5c5XmkGg3bJxkTp73tUxIk1NgLiUfRkCzfusoiNX0csnXrnjz73cFcefgSTz GPa/Yh5AWYZ4zKoZaf1Zi4DWJobSclbMAI5GrJSuC28yo7mOWWmvy8yzTkIjFwuyvtIB EKbUGZipAsA0VWJRa7qIKLN6M10fuXfkIvYnP61c+cYF59HRdx4fU1b7EUBPlnVKD1jc bhcl6KAHckiUsGwjXexy3HQ3Rb+vIA1bzkfOXIrCUAKS/cq4lwSBKJzOB3zQMc20ksnv SxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773874845; x=1774479645; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gXk/XAl/MQx/OXuZk0UOeHJIU6eSq8cRls/Q/FJTwAA=; b=eo7Jla+HmGVI/i327gTT2CXVPBDunBiXEDYstg37Cfzx7OZEsVpS2WsJD3HUc+l6AV WqC5l0W1Ym18povLQVi2dRjua8ryRF2P9EhDbSmFRUtHJ6OlUk3NQAMGwZwiY2SrEhiZ imAy6aCXQT3A2EH/YKwP3ulh5VCmJgwu4ye5nposU8fiCb3RACOGSKS653dfj5JJNzlz uNXN6iBlpjhNVoPm2Ka+F1nk1Gvo7MauFK9Lmb2q5oHLyaU5LW9UtyIxN7ywjtODOw+7 q31EvucCpelpo9/lv5Xs4WcJ929cV6vUjZ+VAurAXq73VeUML4k2ew4DHNYLCgdXg9sP GXZw== X-Forwarded-Encrypted: i=1; AJvYcCX2ufi7B3Qrx1tNGR+sIHGJSWAQaXPe1uRtKNgAMUJGSqZk9kN8ij+/iF3OdSgP/nO+jEaRK/MsrhSgba8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+9vups9r4kdwGkTLszHaLUI6aAJETivSoryhXnKRSW5xV2WWl n8xx4IWW4Rw32Of412VlLUw+HqCZPfJJph7N1wziIWjc4fv210dyzxlSS/6MAKmybuI= X-Gm-Gg: ATEYQzxpMbe/I9tM0bF3J4BKuJOE21LybQArxJwYtxp6npp3NQmajlTuev9t7j0EGCh V47hOXanEMAhgH+EW8qF/LWOgOaMx1mLBhrL0DdQcw7GGTVtmK+z13NM3lmwU1/AlgLTtkTj1e9 1eYjV7v9DNZj21SwvDl4MjZ3yAKG4c84QJb3n4nlphakVXUmJUti3oRz9y0duR/lC7a1bjlJbxc wQqYDt4GTGGRrXUVJi+x8HxxsPEOov3zRIlR9ic4Doq0umYow7sIdr3eA/ISaeDf24R7JuxsNzz oaN4MgOR4rXP9bh3ZJTwWRVXtL/HwTWQhDEnfdR05iYK9TtwL8INb31E8712Kj2+DHQPnauKYtD urmpsbFYN0usNyVrGZ+u3GqFGYEJ9x90oRvD1ugpfXZ6OqRtyDyuOP/6SQTzbIySksTzrc+TQPx S4Q7TXXKvSM+kcH2dzWSFlmwfcaaBruMSMwHA4q12QcBNL9iIVkwFBoBTVbb6zcvK650+kfZMUV w== X-Received: by 2002:a05:6830:730e:b0:7d7:4921:897d with SMTP id 46e09a7af769-7d7ca2bda63mr2987245a34.0.1773874845232; Wed, 18 Mar 2026 16:00:45 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:244c:fc8c:8216:1344? ([2600:8803:e7e4:500:244c:fc8c:8216:1344]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d7c9950d99sm3182160a34.6.2026.03.18.16.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 16:00:43 -0700 (PDT) Message-ID: <4cb07b9a-249a-4c13-b09a-6dac9f72265d@baylibre.com> Date: Wed, 18 Mar 2026 18:00:42 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: mmc: mtk-sd: Add support for MT8189 SoC To: Louis-Alexis Eyraud , Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei Cc: kernel@collabora.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> <20251203-mt8189-add-mmc-support-v1-1-f5ce43212fe9@collabora.com> Content-Language: en-US From: David Lechner In-Reply-To: <20251203-mt8189-add-mmc-support-v1-1-f5ce43212fe9@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/3/25 5:45 AM, Louis-Alexis Eyraud wrote: > Add a new compatible for MMC IP in MT8189 SoC. > Even though this is partially compatible with the one found in MT8196 > SoC, the MT8189 SoC register layout has some slight differences and > additional features. > > Signed-off-by: Louis-Alexis Eyraud > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index 6dd26ad314916a3e40cf55ff69a7d93ed63dbdd4..eb3755bdfdf7e001602c3eb870898275085df3e6 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -25,6 +25,7 @@ properties: > - mediatek,mt8135-mmc > - mediatek,mt8173-mmc > - mediatek,mt8183-mmc > + - mediatek,mt8189-mmc I think this can be in the group with fallback to mediatek,mt8183-mmc. I was able to make it work on U-Boot just using the existing match for "mediatek,mt8183-mmc" there. > - mediatek,mt8196-mmc > - mediatek,mt8516-mmc > - items: > @@ -192,6 +193,7 @@ allOf: > - mediatek,mt8183-mmc > - mediatek,mt8186-mmc > - mediatek,mt8188-mmc > + - mediatek,mt8189-mmc > - mediatek,mt8195-mmc > - mediatek,mt8196-mmc > - mediatek,mt8516-mmc > @@ -240,6 +242,7 @@ allOf: > - mediatek,mt7986-mmc > - mediatek,mt7988-mmc > - mediatek,mt8183-mmc > + - mediatek,mt8189-mmc > - mediatek,mt8196-mmc > then: > properties: >