From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93845C7618D for ; Thu, 6 Apr 2023 14:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238931AbjDFOh7 (ORCPT ); Thu, 6 Apr 2023 10:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239180AbjDFOho (ORCPT ); Thu, 6 Apr 2023 10:37:44 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE859B77F for ; Thu, 6 Apr 2023 07:35:04 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id dw14so25911806pfb.6 for ; Thu, 06 Apr 2023 07:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1680791657; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u6B8WILcVPZkFHn7fuQhYBzfHKFx9fU8cwkns1fF9d0=; b=AIbzpnMbfgEcISAfvM0ZqDPjxCflIy7Bjr+w8Hoa9c4tyfutVUcOuhVy1uPqDCLN8o l2hXaWvIar5w34wTkmMTh916W5QufMl6gYWrBx84ksfKr5V0t1J46nv8NyAAgiMxooYH WWKwUSngOqDNX7gSnTmn1D3C9FpkFUV2eC6w69VAeEVKFX9YvDNYhB5ORZs+gPdAkeKR NA7oG+YnIn0VJIgaxex2cbj/BzhIlpmNbjOwjJL8NdWMD5QzdXUPiBJePwezcKHZbwgu BIZaG0rdrX3djh3P4C2XAfMXCQsU3jWticdWb0wXVg4WbhYgQGwpdeEfeYze+HJb4qNR uEPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680791657; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u6B8WILcVPZkFHn7fuQhYBzfHKFx9fU8cwkns1fF9d0=; b=3mtARizcvYAFgbI3GzC2btSzdIvG+UXW8eAs+zH0mm23LI8VarQW75Nnxj31MSIMqf MhaNywFr/R8ZCUpQtdP06RmvbRdICn8p1ptTbfuHNCKFMXRhHBU/EAxpOWWUVxdgdvMg rBj5mRARNf34P9sMDGbL1RJOrtZBWh6wXmbwm4mzB0bs3RlzadLj9fY2CVbrLXh0RNc9 bAQPx0m/060cypzpMUmM5Rr1TIP5F3ofwCk12SDVheNYACGxitPvkWTj/5AJE1tRJSuk s3raIqMfnqpl/1tJV+I+fJBe9jKH786RZ9AKgATzGGy8QXcQ2uY4gRZihUmQXWHZssvu YUzQ== X-Gm-Message-State: AAQBX9ePL2jfp6Sygad7P00Kl0lweSk0TV5oiOkR82JGQRDPUWMi386g jgvIw+CCVL5XPx7n3fWVagGD+g== X-Google-Smtp-Source: AKy350ZAIzvvXjHG1dKqxuD65cj01SveLdRnp/W1/U8iPKSXPOQPdJcAL2U2qXfVTnlM+7Su3FMuCQ== X-Received: by 2002:aa7:9ec8:0:b0:62e:407:fc69 with SMTP id r8-20020aa79ec8000000b0062e0407fc69mr10084557pfq.21.1680791656870; Thu, 06 Apr 2023 07:34:16 -0700 (PDT) Received: from ?IPV6:2409:8a28:e63:f500:18d3:10f7:2e64:a1a7? ([2409:8a28:e63:f500:18d3:10f7:2e64:a1a7]) by smtp.gmail.com with ESMTPSA id m14-20020aa7900e000000b0062d848b7a9esm1440545pfo.153.2023.04.06.07.34.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 07:34:16 -0700 (PDT) Message-ID: <4cb0dfbc-d546-ed1e-b951-e37104a3f691@bytedance.com> Date: Thu, 6 Apr 2023 22:34:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/4] block, bfq: remove BFQ_WEIGHT_LEGACY_DFL To: Tejun Heo Cc: paolo.valente@linaro.org, axboe@kernel.dk, josef@toxicpanda.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230328145701.33699-1-zhouchengming@bytedance.com> Content-Language: en-US From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/30 02:59, Tejun Heo wrote: > On Tue, Mar 28, 2023 at 10:56:58PM +0800, Chengming Zhou wrote: >> BFQ_WEIGHT_LEGACY_DFL is the same as CGROUP_WEIGHT_DFL, which means >> we don't need cpd_bind_fn() callback to update default weight when >> attached to a hierarchy. >> >> This patch remove BFQ_WEIGHT_LEGACY_DFL and cpd_bind_fn(). >> >> Signed-off-by: Chengming Zhou > > For 1-3, > > Acked-by: Tejun Heo > > Thanks. > Thanks, I will drop the last patch and send v2 with the tag.