From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>,
akpm@linux-foundation.org, kapil.hali@broadcom.com
Subject: Re: [PATCH] scripts/gdb: add a Radix Tree Parser
Date: Wed, 5 Apr 2023 14:58:34 -0700 [thread overview]
Message-ID: <4cb63482-82e4-36b5-dce9-078d0946c71e@gmail.com> (raw)
In-Reply-To: <20230404214049.1016811-1-f.fainelli@gmail.com>
On 4/4/23 14:40, Florian Fainelli wrote:
[snip]
> + shift = node['shift'] + constants.LX_RADIX_TREE_MAP_SHIFT
> +
> + while True:
> + offset = (index >> node['shift']) & constants.LX_RADIX_TREE_MAP_MASK
> + slot = node['slots'][offset]
We need to check for slot == 0 here, unless there are other comments, I
will spin a v2 with that change.
--
Florian
prev parent reply other threads:[~2023-04-05 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 21:40 Florian Fainelli
2023-04-05 21:58 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cb63482-82e4-36b5-dce9-078d0946c71e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jan.kiszka@siemens.com \
--cc=kapil.hali@broadcom.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®