From: Sebastien Boisvert <sboisvert@gydle.com>
To: Thomas-Mich Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org
Cc: brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, kan.liang@linux.intel.com,
stable@vger.kernel.org
Subject: Re: [PATCH] perf/stat: Handle different PMU names with common prefix
Date: Mon, 29 Oct 2018 08:50:59 -0400 [thread overview]
Message-ID: <4cba8c1c-e1ec-1972-5d12-97804cf6aa14@gydle.com> (raw)
In-Reply-To: <80512536-d668-489d-5f73-d7e4a4d54e2d@linux.ibm.com>
On 2018-10-29 8:18 a.m., Thomas-Mich Richter wrote:
> Yes, mistake on my side...
> but it is the same type of error , regardless if 6 or 7 characters are
> compared:
>
> strncmp("cpmu_cf", "cpum_cf_diag", 7)
>
> returns 0 when it should not. The device names of both PMUs are different.
>
OK, that works then.
You want to do a full-length comparison of PMU names, instead of comparing prefixes.
Reviewed-by: Sebastien Boisvert <sboisvert@gydle.com>
next prev parent reply other threads:[~2018-10-29 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 15:16 Thomas Richter
2018-10-26 15:04 ` Sébastien Boisvert
2018-10-29 12:18 ` Thomas-Mich Richter
2018-10-29 12:50 ` Sebastien Boisvert [this message]
2018-11-06 19:14 ` [tip:perf/urgent] perf stat: " tip-bot for Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cba8c1c-e1ec-1972-5d12-97804cf6aa14@gydle.com \
--to=sboisvert@gydle.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®