From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B07C73AD507 for ; Tue, 7 Apr 2026 11:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561171; cv=none; b=oK0XDf1rkNcb5FesQYh52G0g0JB2/KfUpT4MgS8NJ/Co3NC1IeN1k0W5aVVrHSJLMPYief1OVcKSCBh2Yl8BHtHwMXw2FFt8yT+5uctWjI3ZAEyHyUVnSz6YyZL4OsgdY/hv1So+MU2tBUrEYdXoGt1xRXVEDdf6Qgf3Ul2IYi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561171; c=relaxed/simple; bh=TREj4zSRns/I55iGHi5fR98mVeIf0b6KlGroZkFaPaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iUyz3el2SWgwD8W/7yl3LVQRQsQJgl+HSWLcVkplb74paYAeuhi++J3Bij6gizhS8afW4k0nxZ99avNx3g1+MdeAK4Gs/Br8PxOmdHvvDZxvqQS6JLA5Z+hMfZc0w77Hu9+8fW7FVY3gG1I8Pw8jgTya9DsLvqCLqvQjPAliXuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f7sXjeCp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OLVCvFRJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f7sXjeCp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OLVCvFRJ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376NNXe2009180 for ; Tue, 7 Apr 2026 11:26:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= REKQESoHGSr2uVq0msHkBfzv1Re/UPMULOTkZTykn2A=; b=f7sXjeCp3uRHccFH 1+ZVj2Pr+ACXfk+4EEs/ZxzAq3EoEzgm2U8gHoFwYAt+QLKmWf5gqw6SxkkrdWXW nNpYT+/d3TV7a/Z+quUmYA37jXEXS625YmX78f6RkFYimUETYdGD7WmmyooGjLyI DIcTdym6Qn79i3mj60bLUXGLpsz5Rss+vLVI7ncaXVBeZuc3CX9wRdiNg5uIZHjw VhrFR4iUw2Rj8wLdAui+cZMedqM0+TppbZbLzFpTQHayNRFqhD8VH4WAT6zJZPoB zlHHhap1oadRbu6Ol0NBIj9C6vAHxh6IkXbk5Lqbk++xcZmwZHBVIhJ8zLcusNQs ApRJFg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrrtftm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:26:09 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-358f058973fso5997709a91.1 for ; Tue, 07 Apr 2026 04:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775561168; x=1776165968; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=REKQESoHGSr2uVq0msHkBfzv1Re/UPMULOTkZTykn2A=; b=OLVCvFRJ+dATNIjkRYFeAJLVXTd1Z29YpqugDLqkzxpFhMygjOODEIq1fHlrP7I1oM pNw6pujpY6QQQm7k568BLzckbS5/dRLcpV9vOok8su9x4zVGuZRqHeLVSs/ReQ32RMW4 8hE90htVm+StkILjX2fzZWAXvwKZ6aPBKyREwlHauYVWr4fUtvJ9p8C1soSFyRMe1w7A hBrT2JczAfqK/2pDsg90dWtNNcCaBWEr+Z+IwJLivpqVLCgw3BBNnAYHMpDDH5qmqME5 KG7LEenk3/m4A+rjEK2iADtwl9MUs2pzJY9F7B93nhzCH0kDaqGbhvU8OiwzX+u4z0Ll mycQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775561168; x=1776165968; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=REKQESoHGSr2uVq0msHkBfzv1Re/UPMULOTkZTykn2A=; b=Ckvf3a3zNQIIqie5BRc5dVDa1CvQknK604QOWnwtkrGFgrNzgforkV8aLsYPIkvwDY cAiuAn/J9/yDGGzeUtYCnPhM1ci5GFVZC9aG9CJ7cztGMMymmK4MgReM0SuZTon3Ndhp +iiOOPBh3V/fpNhC/wx/ytC67BWKHzLmWv++uKgY65KOtGTD3J0aicVN576Ux/RvJUoj CYcQJ0X4SbfZzmBu1jNsaVUqWarEOJ3dcIiSMO0TrsgOU0U+oErtcrScP7uyyP3stTT5 6HGwCeU8u20dR+shkV4WzKyiEuQ8ZLu/F8WuIpX6iaKbg/MmUr+uBKrMNn9WOIRF6wA9 DwnA== X-Forwarded-Encrypted: i=1; AJvYcCXFTkVVbYLbrtPB+rqb46U8spgeAyq0OdTOQpCIeT1WV/VPUcQp+UEAjG+BAqWcW3/aYnXPnsZXYugjmgY=@vger.kernel.org X-Gm-Message-State: AOJu0YznP6bF/o9VZ/QkQXTbvbYnAG3qEKkM7WOpxofGT0UvQjp74P+I OVCX+feq4K7ki2af0aL182KQjo1c/8K86QfHIOExQAQ2a5Z0X8+r9jCLpK9vu8E6iLeA/UOL/y1 3MimdpJlW7RXPmn25kS8blwHs3iBfjrRytKq73d1FgDaQAPVHVxMkgBdjwlJ+mOvbCGM= X-Gm-Gg: AeBDieuMEzCyS7tqhvVzQMDCPwwPPfXCDynR6AR6nkk8SWOQYF3piAxGR+rbKfZ/5Sr 2IGyokKGQXWUShyr2Qf+OjU1gJH9yDy8xv3HijdWjWl/U79FmPZw3p6EbGMRUyNO1AXx7/uaYXg s9d+K1Yc7Abuqn3X0B5OOD6ONoyPANFarv5xQLp/57sXONhHuJmVIYHnNLTaekWlXWUWlFi01C0 8Ci49qZ7FWOmwxaMeauSWspGQbLQCSehU34h8UUqUrvzTWn6lNch8NalQZwMrwJCPIERkcDtM1l DG692M8rjXc43ogb0BHTA901AUZEMj6zvwhcwkbH4XVkZeVumycMvOcDaL3x/2298XKoavzlc/5 Kh1BRJiK2OJABvhQsvy15bU/MLHlcNnH3uJqTjz/ugX54Z3kBpHoA X-Received: by 2002:a05:6a20:6a26:b0:398:dde7:2dcd with SMTP id adf61e73a8af0-39f2ee61d62mr17989474637.21.1775561168376; Tue, 07 Apr 2026 04:26:08 -0700 (PDT) X-Received: by 2002:a05:6a20:6a26:b0:398:dde7:2dcd with SMTP id adf61e73a8af0-39f2ee61d62mr17989444637.21.1775561167862; Tue, 07 Apr 2026 04:26:07 -0700 (PDT) Received: from [10.217.223.92] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c9cbdfsm22309861b3a.53.2026.04.07.04.26.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:26:07 -0700 (PDT) Message-ID: <4cc079a6-0945-4314-982d-2dfe70226ab4@oss.qualcomm.com> Date: Tue, 7 Apr 2026 16:56:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Add iface clock for ice sdhc To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406-ice_emmc_clock_addition-v1-0-e7b237bf7a69@oss.qualcomm.com> <20260406-ice_emmc_clock_addition-v1-1-e7b237bf7a69@oss.qualcomm.com> <8ea92c00-56ca-47cd-95aa-dbf49ecf4118@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwNyBTYWx0ZWRfXxEwgKTUvO/f0 bvp9R4hwsAjg9vkrxYShHje7qw8mopuSGbVHHHFJmNa3rx18u8+tjpOmzO9zqwpqfw8sQCwEH9E mh+qZZMShWHwgBebeIITbaLSHU71t/Qp19oQO63FyBdEb8QIKUzY55+cKnNeS6WjmVIUozxnYVU LGqadIe0jPiq68x+r7qVKdxY86GWRYohfo62HEFL1P+Z2Yhh1TTq7tzUH9AU0UT6S0063tSG1YA BvlNOdZ6HYNTBohA3FDE6vm4RCwo/IzCScDlWVgjzbmQY2Zg6s3E9K5TUmHEp6q5p22TMX7JlPj k8W2lMkFlJyUY18X4NsE60GZ1IOzOfLHBBKg/TYfO7RsdB0waxmFsLnpXBYS9HH/oGQURXyAtiS g8NpBHDGk3TAkCXZExTnhx0lveiv1behiCXswS0onM+4v6wQgHCOOMhoa65vrwkbzMEIWGkjAGX qVjp1KVYFKCqotLxi+g== X-Proofpoint-GUID: ohwIGL7l-MzRnjcNfCXA3HJZiyn0iiCo X-Proofpoint-ORIG-GUID: ohwIGL7l-MzRnjcNfCXA3HJZiyn0iiCo X-Authority-Analysis: v=2.4 cv=LquiDHdc c=1 sm=1 tr=0 ts=69d4e9d1 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=a3xcrG_bGF9vyDdvPo4A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070107 On 4/7/2026 4:48 PM, Konrad Dybcio wrote: > On 4/7/26 1:09 PM, Kuldeep Singh wrote: >>>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> index dda4697a61b7..5e6b659e8719 100644 >>>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> @@ -1082,7 +1082,8 @@ sdhc_ice: crypto@7c8000 { >>>> compatible = "qcom,sc7280-inline-crypto-engine", >>>> "qcom,inline-crypto-engine"; >>>> reg = <0x0 0x007c8000 0x0 0x18000>; >>>> - clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; >>>> + clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; >>>> + clock-names = "core", "iface"; >>> >>> nit: one a line would be preferred, please fix that up as you seemingly >>> need a v2 anyway >> >> Hi Konrad, Didn't get your comment completely. >> >> Do I need to send v2 to just fix clock entries in 2 lines? >> Or some other comment to address and send v2 for that? >> I don't see any other comment on patchset to address. > > I didn't see your reply to Dmitry's initial comment about the DT bindings > requiring an update. Here's my reply to Dmitry's comment. https://lore.kernel.org/linux-arm-msm/f05ac643-1ec4-4700-aace-c1a9d0cd9e07@oss.qualcomm.com/ Bindings are updated with maxItems:2 in dependent patch series. -- Regards Kuldeep