From: Mario Limonciello <mario.limonciello@amd.com>
To: Perry Yuan <perry.yuan@amd.com>,
rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
gautham.shenoy@amd.com, Borislav.Petkov@amd.com,
Ray.Huang@amd.com, Alexander.Deucher@amd.com
Cc: Xinmei.Huang@amd.com, oleksandr@natalenko.name,
Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: amd-pstate: fix code format problems
Date: Sat, 27 Apr 2024 09:30:22 -0500 [thread overview]
Message-ID: <4cc228c0-a9d0-405a-bb5e-5b049ac39d17@amd.com> (raw)
In-Reply-To: <20240427135249.2160493-1-perry.yuan@amd.com>
On 4/27/2024 08:52, Perry Yuan wrote:
> get some code format problems fixed in the amd-pstate driver.
>
> Changes Made:
>
> - Fixed incorrect comment format in the functions.
>
> - Removed unnecessary blank line.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404271148.HK9yHBlB-lkp@intel.com/
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> drivers/cpufreq/amd-pstate.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 83a29b257794..85656342a101 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -792,7 +792,7 @@ static void amd_pstate_update_limits(unsigned int cpu)
> mutex_unlock(&amd_pstate_driver_lock);
> }
>
> -/**
> +/*
> * Get pstate transition delay time from ACPI tables that firmware set
> * instead of using hardcode value directly.
> */
> @@ -807,7 +807,7 @@ static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
> return transition_delay_ns / NSEC_PER_USEC;
> }
>
> -/**
> +/*
> * Get pstate transition latency value from ACPI tables that firmware
> * set instead of using hardcode value directly.
> */
> @@ -822,7 +822,7 @@ static u32 amd_pstate_get_transition_latency(unsigned int cpu)
> return transition_latency;
> }
>
> -/**
> +/*
> * amd_pstate_init_freq: Initialize the max_freq, min_freq,
> * nominal_freq and lowest_nonlinear_freq for
> * the @cpudata object.
> @@ -843,7 +843,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
> u32 boost_ratio, lowest_nonlinear_ratio;
> struct cppc_perf_caps cppc_perf;
>
> -
> ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf);
> if (ret)
> return ret;
prev parent reply other threads:[~2024-04-27 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 13:52 Perry Yuan
2024-04-27 14:30 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cc228c0-a9d0-405a-bb5e-5b049ac39d17@amd.com \
--to=mario.limonciello@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=perry.yuan@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®