mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-parisc@vger.kernel.org
Subject: Re: [PATCH 1/7] Input: gscps2 - clean up driver code style and structure
Date: Tue, 15 Sep 2026 11:51:28 +0200	[thread overview]
Message-ID: <4cc9fe4b-c3c3-46ff-a32f-d2a86c0ce077@gmx.de> (raw)
In-Reply-To: <20260830-gscps2-v1-1-c733d4cae7f9@gmail.com>

Hi Dmitry,

On 8/30/26 22:52, Dmitry Torokhov wrote:
> Clean up code style issues and function ordering in the gscps2 driver:
> - Reorder functions to place gscps2_interrupt() before its callers,
>    allowing removal of its forward declaration.
> - Change gscps2_enable() to accept a boolean parameter and remove the
>    ENABLE and DISABLE macro definitions.
> - Convert printk() calls to dev_dbg() and dev_warn().
> - Fix operator spacing and multi-variable assignment.
> - Add spinlock comment and use cpu_relax() in spin-wait loop.
> 
> Assisted-by: LLM
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>   drivers/input/serio/gscps2.c | 208 +++++++++++++++++++------------------------
>   1 file changed, 91 insertions(+), 117 deletions(-)
you may add for the whole series:

Acked-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>

Thank you!
Helge

  reply	other threads:[~2026-09-15  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 20:52 [PATCH 0/7] Input: gscps2: cleanups and locking fixes Dmitry Torokhov
2026-08-30 20:52 ` [PATCH 1/7] Input: gscps2 - clean up driver code style and structure Dmitry Torokhov
2026-09-15  9:51   ` Helge Deller [this message]
2026-08-30 20:52 ` [PATCH 2/7] Input: gscps2 - use RCU for ps2port_list and manage it in open/close Dmitry Torokhov
2026-08-30 20:52 ` [PATCH 3/7] Input: gscps2 - protect buffer access in read and report helpers Dmitry Torokhov
2026-08-30 20:52 ` [PATCH 4/7] Input: gscps2 - serialize hardware and buffer access in gscps2_flush() Dmitry Torokhov
2026-08-30 20:52 ` [PATCH 5/7] Input: gscps2 - return IRQ_NONE when interrupt is not handled Dmitry Torokhov
2026-08-30 20:52 ` [PATCH 6/7] Input: gscps2 - serialize concurrent interrupt handlers Dmitry Torokhov
2026-08-30 20:52 ` [PATCH 7/7] Input: gscps2 - drop busy-wait and manual interrupt pump on transmit Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cc9fe4b-c3c3-46ff-a32f-d2a86c0ce077@gmx.de \
    --to=deller@gmx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®