From: Nam Cao <namcaov@gmail.com>
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
dan.carpenter@oracle.com
Cc: namcaov@gmail.com, philipp.g.hortmann@gmail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [RFC PATCH v2 3/4] staging: vt6655: remove redundant assignment
Date: Wed, 28 Sep 2022 19:21:49 +0200 [thread overview]
Message-ID: <4ccc5c55d136cb0749cf773e673fa903eebf473c.1664384503.git.namcaov@gmail.com> (raw)
In-Reply-To: <cover.1664384503.git.namcaov@gmail.com>
In function device_rx_srv, the assignment rd->rd0.owner = OWNED_BY_NIC
is redundant because this is already done in device_alloc_rx_buf() which
is called right above. Remove it.
Signed-off-by: Nam Cao <namcaov@gmail.com>
---
drivers/staging/vt6655/device_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 21d10d9fde47..c8cae6df7f51 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -839,7 +839,6 @@ static int device_rx_srv(struct vnt_private *priv, unsigned int idx)
"can not allocate rx buf\n");
break;
}
- rd->rd0.owner = OWNED_BY_NIC;
}
priv->pCurrRD[idx] = rd;
--
2.25.1
next prev parent reply other threads:[~2022-09-28 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 17:21 [RFC PATCH v2 0/4] staging: vt6655: Implement allocation failure handling Nam Cao
2022-09-28 17:21 ` [RFC PATCH v2 1/4] staging: vt6655: remove redundant if condition Nam Cao
2022-09-28 17:21 ` [RFC PATCH v2 2/4] staging: vt6655: change vnt_receive_frame return type to void Nam Cao
2022-09-28 17:21 ` Nam Cao [this message]
2022-09-28 17:21 ` [RFC PATCH v2 4/4] staging: vt6655: implement allocation failure handling Nam Cao
2022-09-29 20:30 ` [RFC PATCH v2 0/4] staging: vt6655: Implement " Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ccc5c55d136cb0749cf773e673fa903eebf473c.1664384503.git.namcaov@gmail.com \
--to=namcaov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®